[refactor](topn) Refactor topn filter push down #59005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 35493 ms |
TPC-DS: Total hot run time: 179478 ms |
ClickBench: Total hot run time: 27.47 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 35151 ms |
TPC-DS: Total hot run time: 178751 ms |
ClickBench: Total hot run time: 27.65 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
BiteTheDDDDt
approved these changes
Dec 16, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
Contributor
|
PR approved by anyone and no changes requested. |
yiguolei
reviewed
Dec 16, 2025
| int64_t index = DORIS_TRY(_contexts[target_node_id].get_field_index()); | ||
| DCHECK(_contexts[target_node_id].predicate != nullptr); | ||
| assert_cast<SharedPredicate*>(_contexts[target_node_id].predicate.get()) | ||
| ->set_column_id(cast_set<uint32_t>(index)); |
yiguolei
reviewed
Dec 16, 2025
| _parent->cast<typename Derived::Parent>()._slot_id_to_slot_desc[slot->slot_id()]; | ||
| return _is_predicate_acting_on_slot(slot, range); | ||
| }; | ||
| auto topn_predicate_checker = [&](const vectorized::VExprSPtrs& children, |
Contributor
There was a problem hiding this comment.
我们为什么在一个函数里，定义这么多lambda，而不是写多个函数呢？
Mryange
approved these changes
Dec 16, 2025
yiguolei
reviewed
Dec 16, 2025
| slot_id_to_slot_desc[get_texpr(target_node_id).nodes[0].slot_ref.slot_id] | ||
| ->col_name(), | ||
| desc.debug_string(), | ||
| slot_id_to_slot_desc[get_texpr(target_node_id).nodes[0].slot_ref.slot_id] |
Gabriel39
added a commit
to Gabriel39/incubator-doris
that referenced
this pull request
Jan 13, 2026
TopN filter should be push down from scan operators like other predicates.
16 tasks
yiguolei
pushed a commit
that referenced
this pull request
Jan 14, 2026
### What problem does this PR solve? pick #57397 #58283 #58290 #58282 #58832 #58905 #58960 #59005 #59088 #59098 #59126 #59187 #59581 #59625 #59775 ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
TopN filter should be push down from scan operators like other predicates.
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)