Skip to content

[fix](nullable) set SlotRef's nullable to right value #59092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Dec 18, 2025
Merged

[fix](nullable) set SlotRef's nullable to right value #59092

morrySnow merged 1 commit into from
Dec 18, 2025

Conversation

@morrySnow
Copy link
Contributor

@morrySnow morrySnow commented Dec 16, 2025 •
edited
Loading

What problem does this PR solve?

Related PR: #57862

Problem Summary:

This pull request refactors how constant and result expressions are handled in set operations and one-row relations, simplifies the logic for handling nullable outputs in joins and assertions, and removes some legacy or redundant code. The changes improve code clarity, maintainability, and correctness, especially around expression translation and output slot nullability.

Set Operation and Expression Handling Improvements:

  • Refactored set operation node construction to directly generate and assign materialized constant and result expression lists (setMaterializedConstExprLists and setMaterializedResultExprLists), removing the finalizeForSetOperationNode method and simplifying the logic in visitPhysicalSetOperation. This ensures expressions are translated and assigned more explicitly and consistently. [1] [2]
  • Updated the handling of PhysicalOneRowRelation to directly assign materialized constant expressions to the UnionNode, streamlining the process and removing unnecessary slot descriptor assignments.

Nullability and Join Output Adjustments:

  • Improved the logic for setting output slots as nullable in hash joins, ensuring that for outer joins, corresponding slot references are created and mapped in the translation context, which enhances correctness for downstream processing.
  • Simplified the construction of AssertNumRowsNode by always generating a new tuple descriptor based on the output, removing redundant code for slot mapping and nullability, and ensuring output nullability is always set in the Thrift conversion. [1] [2] [3]

Code Cleanup and Removal of Legacy Logic:

  • Removed temporary/legacy code for handling special cases like ROWID_COL in join slot descriptor creation, making the codebase more maintainable and focused.
  • Cleaned up unused or redundant code in the load plan info collector and set operation node handling, reducing complexity. [1] [2]

Dependency and Import Updates:

  • Added necessary imports for AssertNumRowsElement to support the refactored assertion handling.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 16, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morrySnow
Copy link
Contributor Author

morrySnow commented Dec 16, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Dec 16, 2025

TPC-H: Total hot run time: 35380 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6f7594efbd9c1dce006384a69ae7dc409213c498, data reload: false

------ Round 1 ----------------------------------
q1	17659	4310	4075	4075
q2	2035	345	241	241
q3	10165	1330	777	777
q4	10219	857	317	317
q5	7537	2133	1932	1932
q6	184	166	137	137
q7	1013	858	717	717
q8	9361	1378	1286	1286
q9	6947	5367	5288	5288
q10	6784	2395	1975	1975
q11	532	328	302	302
q12	678	745	590	590
q13	17797	3657	3045	3045
q14	295	310	286	286
q15	585	539	508	508
q16	675	670	634	634
q17	694	862	460	460
q18	7709	7097	7120	7097
q19	1104	959	619	619
q20	408	373	257	257
q21	4282	3866	3912	3866
q22	1062	1008	971	971
Total cold run time: 107725 ms
Total hot run time: 35380 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4097	4047	4099	4047
q2	337	397	315	315
q3	2118	2690	2270	2270
q4	1344	1724	1251	1251
q5	4272	4626	4634	4626
q6	216	170	133	133
q7	2088	1994	1875	1875
q8	2731	2558	2570	2558
q9	7748	7517	7440	7440
q10	3064	3453	2848	2848
q11	596	518	513	513
q12	713	780	564	564
q13	3560	3882	3563	3563
q14	298	304	294	294
q15	552	521	508	508
q16	649	689	630	630
q17	1212	1441	1441	1441
q18	8209	7725	7633	7633
q19	865	898	891	891
q20	2018	2141	1924	1924
q21	4969	4544	4136	4136
q22	1065	1050	984	984
Total cold run time: 52721 ms
Total hot run time: 50444 ms

@doris-robot
Copy link

doris-robot commented Dec 16, 2025

TPC-DS: Total hot run time: 178109 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6f7594efbd9c1dce006384a69ae7dc409213c498, data reload: false

query5	4409	591	468	468
query6	352	254	221	221
query7	4231	478	275	275
query8	331	253	253	253
query9	8725	2544	2567	2544
query10	485	421	343	343
query11	15505	15212	14598	14598
query12	196	119	116	116
query13	1263	507	390	390
query14	6856	3052	2776	2776
query14_1	2658	2690	2659	2659
query15	214	200	179	179
query16	918	489	449	449
query17	1155	762	601	601
query18	2710	447	351	351
query19	241	242	233	233
query20	127	118	116	116
query21	225	138	118	118
query22	3876	3930	3904	3904
query23	16579	16160	15800	15800
query23_1	16154	16029	15939	15939
query24	7311	1646	1239	1239
query24_1	1259	1243	1229	1229
query25	602	525	457	457
query26	1247	276	174	174
query27	2726	465	320	320
query28	4434	2130	2127	2127
query29	781	531	434	434
query30	314	246	216	216
query31	885	715	638	638
query32	81	76	72	72
query33	538	345	293	293
query34	915	890	539	539
query35	784	829	749	749
query36	851	912	814	814
query37	133	92	77	77
query38	2849	2866	2800	2800
query39	751	737	721	721
query39_1	701	695	694	694
query40	227	135	119	119
query41	66	63	65	63
query42	107	107	109	107
query43	443	422	412	412
query44	1322	756	736	736
query45	193	191	187	187
query46	882	978	609	609
query47	1651	1687	1630	1630
query48	314	319	246	246
query49	615	433	351	351
query50	663	284	227	227
query51	3797	3824	3789	3789
query52	106	111	103	103
query53	328	354	290	290
query54	303	276	278	276
query55	76	74	71	71
query56	310	317	300	300
query57	1136	1132	1096	1096
query58	272	259	253	253
query59	2440	2488	2367	2367
query60	311	321	286	286
query61	163	166	160	160
query62	693	675	642	642
query63	327	291	298	291
query64	4887	1339	1020	1020
query65	4013	4014	3983	3983
query66	1390	449	329	329
query67	15126	15003	14863	14863
query68	5782	1018	743	743
query69	504	346	311	311
query70	1056	989	1002	989
query71	385	301	279	279
query72	6112	4996	5223	4996
query73	689	588	317	317
query74	8839	8753	8531	8531
query75	3257	3150	2794	2794
query76	3942	1131	744	744
query77	534	392	295	295
query78	9553	9753	8955	8955
query79	1592	853	625	625
query80	760	688	581	581
query81	537	273	241	241
query82	474	131	103	103
query83	262	256	245	245
query84	264	122	108	108
query85	930	517	466	466
query86	380	286	280	280
query87	3108	3080	2956	2956
query88	3269	2291	2264	2264
query89	477	429	389	389
query90	2118	159	148	148
query91	177	174	146	146
query92	84	71	65	65
query93	1514	918	562	562
query94	477	311	272	272
query95	580	373	304	304
query96	591	480	213	213
query97	2301	2331	2248	2248
query98	207	192	196	192
query99	1294	1283	1251	1251
Total cold run time: 258533 ms
Total hot run time: 178109 ms

@morrySnow
Copy link
Contributor Author

morrySnow commented Dec 16, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Dec 16, 2025

TPC-H: Total hot run time: 35355 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 253b8f21f2d5d6a4c3b3f09cb822528214a6034c, data reload: false

------ Round 1 ----------------------------------
q1	17658	4339	4144	4144
q2	2037	354	246	246
q3	10208	1353	770	770
q4	10384	877	321	321
q5	9579	2160	1986	1986
q6	223	168	134	134
q7	1016	889	713	713
q8	9377	1425	1269	1269
q9	7176	5315	5360	5315
q10	6851	2379	1999	1999
q11	532	313	297	297
q12	657	727	586	586
q13	17848	3691	2976	2976
q14	296	308	279	279
q15	593	516	522	516
q16	672	758	638	638
q17	734	871	472	472
q18	7506	7301	6997	6997
q19	1114	967	623	623
q20	405	369	259	259
q21	4264	3978	3826	3826
q22	1077	1019	989	989
Total cold run time: 110207 ms
Total hot run time: 35355 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4133	4081	4086	4081
q2	339	415	308	308
q3	2179	2704	2332	2332
q4	1343	1756	1305	1305
q5	4251	4179	4122	4122
q6	212	171	127	127
q7	1935	1823	1723	1723
q8	2558	2442	2356	2356
q9	7080	7033	6989	6989
q10	2911	3102	2672	2672
q11	598	519	501	501
q12	656	710	559	559
q13	3309	3717	3058	3058
q14	293	285	285	285
q15	582	511	520	511
q16	648	668	612	612
q17	1127	1333	1325	1325
q18	7225	7014	7044	7014
q19	854	870	892	870
q20	1916	1975	1805	1805
q21	4707	4255	4232	4232
q22	1119	1036	1013	1013
Total cold run time: 49975 ms
Total hot run time: 47800 ms

@doris-robot
Copy link

doris-robot commented Dec 16, 2025

TPC-DS: Total hot run time: 178717 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 253b8f21f2d5d6a4c3b3f09cb822528214a6034c, data reload: false

query5	856	581	447	447
query6	389	223	212	212
query7	4497	477	278	278
query8	346	270	247	247
query9	7970	2561	2567	2561
query10	537	381	340	340
query11	15483	15146	14527	14527
query12	181	124	118	118
query13	1297	529	409	409
query14	5682	3103	2815	2815
query14_1	2705	2666	2623	2623
query15	219	207	182	182
query16	835	484	500	484
query17	991	677	606	606
query18	2261	432	339	339
query19	234	221	207	207
query20	118	115	114	114
query21	181	138	115	115
query22	3944	3894	3786	3786
query23	16689	16281	16069	16069
query23_1	16073	16067	16052	16052
query24	7219	1673	1231	1231
query24_1	1249	1241	1265	1241
query25	667	473	417	417
query26	1040	275	168	168
query27	2831	462	307	307
query28	4433	2136	2125	2125
query29	987	568	476	476
query30	355	247	217	217
query31	819	699	632	632
query32	80	69	66	66
query33	610	342	293	293
query34	912	906	536	536
query35	845	824	734	734
query36	880	907	834	834
query37	141	96	81	81
query38	2852	2929	2813	2813
query39	757	759	716	716
query39_1	688	703	711	703
query40	224	142	127	127
query41	85	77	65	65
query42	105	105	111	105
query43	424	434	404	404
query44	1395	763	749	749
query45	196	194	184	184
query46	902	1008	618	618
query47	1661	1703	1603	1603
query48	319	334	245	245
query49	784	470	371	371
query50	684	314	222	222
query51	3821	3889	3845	3845
query52	110	110	98	98
query53	330	351	300	300
query54	300	253	243	243
query55	79	74	74	74
query56	301	295	308	295
query57	1138	1153	1076	1076
query58	273	251	251	251
query59	2372	2559	2402	2402
query60	319	309	292	292
query61	162	157	157	157
query62	711	675	617	617
query63	334	304	308	304
query64	4890	1282	1004	1004
query65	3995	3904	3937	3904
query66	1403	447	325	325
query67	15284	15223	14878	14878
query68	2801	1076	784	784
query69	443	374	325	325
query70	1097	1000	989	989
query71	336	315	280	280
query72	5699	5041	5003	5003
query73	482	566	310	310
query74	8812	8767	8571	8571
query75	3130	3166	2806	2806
query76	3105	1164	732	732
query77	487	420	290	290
query78	9527	9720	8962	8962
query79	2259	877	630	630
query80	840	652	566	566
query81	481	272	234	234
query82	1439	133	101	101
query83	266	254	239	239
query84	297	115	103	103
query85	922	521	467	467
query86	347	307	281	281
query87	3071	3094	2966	2966
query88	3300	2283	2243	2243
query89	490	433	398	398
query90	1918	162	160	160
query91	170	170	147	147
query92	86	68	63	63
query93	1142	923	561	561
query94	496	293	290	290
query95	531	374	308	308
query96	591	468	205	205
query97	2248	2273	2227	2227
query98	209	196	189	189
query99	1322	1267	1242	1242
Total cold run time: 243946 ms
Total hot run time: 178717 ms

@doris-robot
Copy link

doris-robot commented Dec 16, 2025

ClickBench: Total hot run time: 27.28 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 253b8f21f2d5d6a4c3b3f09cb822528214a6034c, data reload: false

query1	0.05	0.06	0.05
query2	0.11	0.05	0.04
query3	0.27	0.09	0.09
query4	1.61	0.12	0.11
query5	0.28	0.24	0.26
query6	1.16	0.66	0.64
query7	0.04	0.03	0.02
query8	0.05	0.04	0.05
query9	0.58	0.51	0.52
query10	0.54	0.56	0.56
query11	0.16	0.11	0.10
query12	0.15	0.12	0.12
query13	0.62	0.60	0.60
query14	0.99	0.98	0.98
query15	0.83	0.80	0.79
query16	0.42	0.40	0.39
query17	1.07	1.05	1.05
query18	0.23	0.21	0.22
query19	1.84	1.85	1.83
query20	0.02	0.02	0.01
query21	15.46	0.32	0.15
query22	4.70	0.05	0.05
query23	16.16	0.28	0.11
query24	1.41	1.63	0.24
query25	0.10	0.08	0.05
query26	0.14	0.13	0.13
query27	0.10	0.04	0.06
query28	5.56	1.21	1.02
query29	12.56	4.12	3.22
query30	0.28	0.14	0.15
query31	2.85	0.61	0.40
query32	3.23	0.54	0.45
query33	2.98	2.99	3.04
query34	16.98	5.22	4.50
query35	4.58	4.58	4.57
query36	0.67	0.50	0.49
query37	0.10	0.06	0.06
query38	0.07	0.04	0.04
query39	0.05	0.03	0.04
query40	0.17	0.14	0.13
query41	0.08	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.03	0.03
Total cold run time: 99.33 s
Total hot run time: 27.28 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 16, 2025

FE UT Coverage Report

Increment line coverage 70.37% (38/54) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 16, 2025

FE Regression Coverage Report

Increment line coverage 96.30% (52/54) 🎉
Increment coverage report
Complete coverage report

@morrySnow
Copy link
Contributor Author

morrySnow commented Dec 17, 2025

run buildall

@morrySnow morrySnow marked this pull request as ready for review December 17, 2025 02:32
@morrySnow
Copy link
Contributor Author

morrySnow commented Dec 17, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Dec 17, 2025

TPC-H: Total hot run time: 35003 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1fbf973a7d7d6150165946149cf155ccfc7d0d32, data reload: false

------ Round 1 ----------------------------------
q1	17734	4308	4096	4096
q2	2135	348	233	233
q3	10198	1286	721	721
q4	10248	853	326	326
q5	7513	2149	1893	1893
q6	198	174	137	137
q7	1059	860	710	710
q8	9348	1426	1169	1169
q9	6961	5314	5336	5314
q10	6958	2383	2016	2016
q11	515	321	291	291
q12	675	712	603	603
q13	17853	3754	3177	3177
q14	293	300	282	282
q15	599	520	509	509
q16	727	714	634	634
q17	724	837	581	581
q18	7786	7019	6859	6859
q19	1114	954	619	619
q20	413	358	254	254
q21	4200	4051	3639	3639
q22	1029	1006	940	940
Total cold run time: 108280 ms
Total hot run time: 35003 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4112	4063	4038	4038
q2	334	399	323	323
q3	2130	2678	2260	2260
q4	1354	1756	1288	1288
q5	4203	4851	4577	4577
q6	211	169	135	135
q7	2110	1990	1834	1834
q8	2681	2599	2492	2492
q9	7591	7538	7520	7520
q10	3097	3224	2793	2793
q11	574	513	485	485
q12	846	785	584	584
q13	3682	4040	3365	3365
q14	282	303	287	287
q15	564	510	502	502
q16	646	665	627	627
q17	1243	1503	1465	1465
q18	8021	7538	7330	7330
q19	830	793	812	793
q20	1880	1946	1827	1827
q21	4561	4250	4146	4146
q22	1093	1044	1006	1006
Total cold run time: 52045 ms
Total hot run time: 49677 ms

@doris-robot
Copy link

doris-robot commented Dec 17, 2025

TPC-DS: Total hot run time: 177798 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1fbf973a7d7d6150165946149cf155ccfc7d0d32, data reload: false

query5	5194	601	452	452
query6	336	231	218	218
query7	4216	458	262	262
query8	304	247	235	235
query9	8741	2542	2531	2531
query10	554	385	334	334
query11	15445	14722	14531	14531
query12	169	116	117	116
query13	1256	504	400	400
query14	6087	3003	2753	2753
query14_1	2668	2645	2677	2645
query15	212	210	177	177
query16	1046	457	423	423
query17	1216	719	605	605
query18	2449	446	354	354
query19	243	238	214	214
query20	124	121	111	111
query21	261	146	129	129
query22	4016	3938	3984	3938
query23	16564	16273	16007	16007
query23_1	16117	16101	16023	16023
query24	7349	1666	1248	1248
query24_1	1219	1242	1254	1242
query25	576	508	438	438
query26	1252	274	177	177
query27	2731	463	310	310
query28	4459	2141	2121	2121
query29	825	565	471	471
query30	341	248	220	220
query31	834	698	638	638
query32	79	73	70	70
query33	553	351	300	300
query34	915	905	536	536
query35	778	805	728	728
query36	842	907	828	828
query37	141	100	122	100
query38	2879	2859	2837	2837
query39	764	717	719	717
query39_1	696	699	699	699
query40	227	144	126	126
query41	66	68	63	63
query42	107	103	102	102
query43	425	439	404	404
query44	1332	743	739	739
query45	192	194	184	184
query46	875	997	611	611
query47	1653	1693	1596	1596
query48	325	319	243	243
query49	612	442	345	345
query50	660	295	214	214
query51	3785	3909	3874	3874
query52	108	109	99	99
query53	328	352	297	297
query54	290	252	256	252
query55	75	77	72	72
query56	289	310	287	287
query57	1150	1146	1063	1063
query58	266	248	251	248
query59	2425	2425	2355	2355
query60	316	307	298	298
query61	157	201	153	153
query62	730	685	649	649
query63	344	296	301	296
query64	4952	1282	974	974
query65	4029	3961	3955	3955
query66	1460	441	315	315
query67	15137	15087	14716	14716
query68	8423	1001	718	718
query69	498	355	303	303
query70	1081	1007	997	997
query71	371	305	275	275
query72	6053	5117	4903	4903
query73	670	564	312	312
query74	8775	8775	8648	8648
query75	3230	3174	2821	2821
query76	3917	1156	721	721
query77	545	394	303	303
query78	9355	9544	8791	8791
query79	1783	888	623	623
query80	819	646	542	542
query81	524	274	229	229
query82	408	132	104	104
query83	262	258	244	244
query84	258	123	103	103
query85	912	514	452	452
query86	430	304	283	283
query87	2959	3102	2885	2885
query88	4167	2261	2253	2253
query89	482	441	396	396
query90	2143	158	147	147
query91	180	165	145	145
query92	86	69	62	62
query93	2433	898	554	554
query94	521	288	284	284
query95	578	330	356	330
query96	579	482	207	207
query97	2295	2295	2207	2207
query98	218	195	196	195
query99	1304	1313	1196	1196
Total cold run time: 263539 ms
Total hot run time: 177798 ms

@doris-robot
Copy link

doris-robot commented Dec 17, 2025

ClickBench: Total hot run time: 27.34 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1fbf973a7d7d6150165946149cf155ccfc7d0d32, data reload: false

query1	0.05	0.04	0.04
query2	0.09	0.05	0.05
query3	0.26	0.09	0.08
query4	1.61	0.12	0.11
query5	0.27	0.26	0.25
query6	1.16	0.65	0.62
query7	0.04	0.03	0.02
query8	0.05	0.04	0.05
query9	0.56	0.52	0.49
query10	0.55	0.56	0.56
query11	0.16	0.11	0.11
query12	0.15	0.11	0.13
query13	0.62	0.60	0.61
query14	0.99	0.97	0.98
query15	0.81	0.78	0.80
query16	0.40	0.40	0.39
query17	0.98	1.04	1.02
query18	0.23	0.22	0.21
query19	1.94	1.85	1.87
query20	0.01	0.01	0.02
query21	15.43	0.30	0.15
query22	4.81	0.05	0.04
query23	16.05	0.29	0.10
query24	0.93	0.63	0.30
query25	0.09	0.10	0.06
query26	0.14	0.14	0.14
query27	0.08	0.06	0.05
query28	3.35	1.25	1.02
query29	12.60	3.98	3.29
query30	0.27	0.13	0.13
query31	2.82	0.64	0.40
query32	3.23	0.57	0.47
query33	3.06	3.02	3.04
query34	16.80	5.22	4.48
query35	4.57	4.55	4.57
query36	0.67	0.51	0.48
query37	0.11	0.07	0.07
query38	0.07	0.05	0.04
query39	0.05	0.03	0.03
query40	0.17	0.14	0.12
query41	0.09	0.04	0.03
query42	0.05	0.03	0.03
query43	0.04	0.03	0.04
Total cold run time: 96.41 s
Total hot run time: 27.34 s

@morrySnow
Copy link
Contributor Author

morrySnow commented Dec 17, 2025

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 17, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 17, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 17, 2025

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Dec 17, 2025

TPC-H: Total hot run time: 35277 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b1ba0b445c32d84bf2f86715a671f8830a7fe95e, data reload: false

------ Round 1 ----------------------------------
q1	17633	4280	4078	4078
q2	2039	357	227	227
q3	10171	1373	752	752
q4	10212	801	313	313
q5	7564	2182	1936	1936
q6	188	171	136	136
q7	1005	850	704	704
q8	9365	1524	1167	1167
q9	7162	5385	5393	5385
q10	6884	2405	1959	1959
q11	548	315	310	310
q12	718	739	569	569
q13	17804	3715	3045	3045
q14	306	291	275	275
q15	604	534	513	513
q16	687	680	636	636
q17	699	789	579	579
q18	7602	7198	7090	7090
q19	1476	964	633	633
q20	399	366	248	248
q21	4216	3960	3765	3765
q22	1023	1000	957	957
Total cold run time: 108305 ms
Total hot run time: 35277 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4194	4065	4162	4065
q2	353	415	332	332
q3	2110	2694	2290	2290
q4	1335	1780	1309	1309
q5	4251	4730	4576	4576
q6	250	196	142	142
q7	2099	2049	1840	1840
q8	2784	2461	2552	2461
q9	7508	7605	7567	7567
q10	3086	3270	2853	2853
q11	577	523	493	493
q12	855	767	620	620
q13	3726	3947	3406	3406
q14	305	296	275	275
q15	549	516	506	506
q16	651	704	629	629
q17	1228	1506	1425	1425
q18	7750	7939	7409	7409
q19	911	895	919	895
q20	2035	2088	1979	1979
q21	4705	4273	4137	4137
q22	1082	1020	935	935
Total cold run time: 52344 ms
Total hot run time: 50144 ms

@doris-robot
Copy link

doris-robot commented Dec 17, 2025

TPC-DS: Total hot run time: 178768 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b1ba0b445c32d84bf2f86715a671f8830a7fe95e, data reload: false

query5	4387	600	464	464
query6	334	239	217	217
query7	4213	477	289	289
query8	311	263	266	263
query9	8785	2576	2540	2540
query10	502	399	316	316
query11	15308	14799	14879	14799
query12	184	119	116	116
query13	1281	509	388	388
query14	6109	3023	2789	2789
query14_1	2901	2621	2661	2621
query15	222	197	184	184
query16	877	466	452	452
query17	1156	704	625	625
query18	2498	461	357	357
query19	237	233	204	204
query20	122	118	120	118
query21	223	143	126	126
query22	3824	3960	3859	3859
query23	16634	16328	15997	15997
query23_1	16025	16114	15987	15987
query24	7344	1677	1280	1280
query24_1	1257	1259	1279	1259
query25	589	501	460	460
query26	1270	278	169	169
query27	2718	457	324	324
query28	4486	2141	2140	2140
query29	843	544	445	445
query30	316	242	221	221
query31	821	727	628	628
query32	76	77	67	67
query33	541	327	291	291
query34	893	891	537	537
query35	798	815	718	718
query36	862	908	809	809
query37	123	90	75	75
query38	2864	2845	2831	2831
query39	764	729	709	709
query39_1	707	712	683	683
query40	231	140	119	119
query41	67	64	64	64
query42	107	103	112	103
query43	429	435	398	398
query44	1311	742	744	742
query45	191	192	183	183
query46	884	996	624	624
query47	1681	1668	1621	1621
query48	323	327	240	240
query49	613	433	351	351
query50	658	290	227	227
query51	3829	3882	3905	3882
query52	108	108	96	96
query53	331	362	303	303
query54	289	258	243	243
query55	86	75	73	73
query56	297	307	283	283
query57	1144	1164	1088	1088
query58	282	245	291	245
query59	2425	2562	2309	2309
query60	314	314	274	274
query61	159	161	156	156
query62	717	670	634	634
query63	326	299	297	297
query64	5007	1305	1006	1006
query65	4032	3961	3979	3961
query66	1437	438	315	315
query67	15083	15027	14948	14948
query68	6178	1016	720	720
query69	505	349	307	307
query70	1070	1002	943	943
query71	367	307	278	278
query72	6016	4960	5057	4960
query73	697	626	313	313
query74	8845	8906	8498	8498
query75	3229	3194	2845	2845
query76	3856	1141	741	741
query77	533	432	310	310
query78	9507	9669	8916	8916
query79	1263	910	617	617
query80	926	668	570	570
query81	530	271	242	242
query82	440	141	111	111
query83	269	262	238	238
query84	256	124	106	106
query85	918	516	457	457
query86	319	301	294	294
query87	3102	3081	3019	3019
query88	3323	2292	2264	2264
query89	484	442	407	407
query90	2019	172	161	161
query91	182	167	153	153
query92	77	71	70	70
query93	1153	934	561	561
query94	541	313	276	276
query95	582	343	359	343
query96	609	493	220	220
query97	2288	2342	2245	2245
query98	218	204	206	204
query99	1281	1310	1199	1199
Total cold run time: 257481 ms
Total hot run time: 178768 ms

@doris-robot
Copy link

doris-robot commented Dec 17, 2025

ClickBench: Total hot run time: 27.5 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b1ba0b445c32d84bf2f86715a671f8830a7fe95e, data reload: false

query1	0.06	0.04	0.04
query2	0.10	0.05	0.05
query3	0.26	0.08	0.08
query4	1.61	0.11	0.11
query5	0.27	0.25	0.24
query6	1.16	0.63	0.64
query7	0.03	0.03	0.03
query8	0.05	0.05	0.04
query9	0.58	0.52	0.51
query10	0.56	0.54	0.55
query11	0.16	0.11	0.12
query12	0.15	0.12	0.12
query13	0.63	0.61	0.59
query14	1.00	0.98	0.99
query15	0.82	0.79	0.81
query16	0.40	0.43	0.39
query17	1.07	1.05	1.06
query18	0.24	0.22	0.22
query19	1.94	1.90	1.85
query20	0.01	0.02	0.01
query21	15.42	0.30	0.14
query22	4.81	0.05	0.04
query23	15.92	0.28	0.10
query24	1.40	0.36	0.39
query25	0.09	0.07	0.05
query26	0.15	0.13	0.14
query27	0.06	0.10	0.05
query28	4.19	1.23	1.03
query29	12.56	4.02	3.23
query30	0.28	0.14	0.11
query31	2.83	0.65	0.41
query32	3.24	0.56	0.47
query33	2.98	3.04	3.10
query34	16.87	5.16	4.58
query35	4.57	4.52	4.61
query36	0.65	0.51	0.50
query37	0.11	0.06	0.06
query38	0.07	0.04	0.04
query39	0.05	0.03	0.04
query40	0.17	0.15	0.14
query41	0.09	0.03	0.04
query42	0.04	0.03	0.03
query43	0.04	0.03	0.04
Total cold run time: 97.69 s
Total hot run time: 27.5 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 18, 2025

FE Regression Coverage Report

Increment line coverage 96.30% (52/54) 🎉
Increment coverage report
Complete coverage report

@morrySnow morrySnow merged commit 5a1fce5 into apache:master Dec 18, 2025
27 of 28 checks passed
@morrySnow morrySnow deleted the fix_nullable branch December 18, 2025 06:09
@starocean999 starocean999 mentioned this pull request Dec 24, 2025
Merged
16 tasks
starocean999 added a commit that referenced this pull request Dec 25, 2025
@starocean999
[fix](nullable) set SlotRef's nullable to right value for nestloop jo…
c6585e3 
…in (#59310)

this is follow up of #59092, we need
change nestloop join's nullable info too.

Related PR: #59092
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@englefly englefly englefly approved these changes

@starocean999 starocean999 starocean999 approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@morrySnow @hello-stephen @doris-robot @englefly @starocean999