Skip to content

[fix](core) fix core if hll_from_base64 input invalid #59106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Gabriel39 merged 1 commit into from
Dec 18, 2025
Merged

[fix](core) fix core if hll_from_base64 input invalid #59106

Gabriel39 merged 1 commit into from
Dec 18, 2025

Conversation

@Mryange
Copy link
Contributor

@Mryange Mryange commented Dec 17, 2025 •
edited
Loading

What problem does this PR solve?

mysql>  SELECT hll_from_base64(CAST('AgAAAAAAAABwAAAAAAAAAA==' AS VARCHAR(100))) AS result;
ERROR 1105 (HY000): RpcException, msg: send fragments failed. io.grpc.StatusRuntimeException: UNAVAILABLE: io exception, host: 127.0.0.1

now

mysql>  SELECT hll_from_base64(CAST('AgAAAAAAAABwAAAAAAAAAA==' AS VARCHAR(100))) AS result;
ERROR 1105 (HY000): errCode = 2, detailMessage = (127.0.0.1)[RUNTIME_ERROR]hll_from_base64 decode failed: base64: AgAAAAAAAABwAAAAAAAAAA==

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Mryange Mryange requested a review from zclllyybb as a code owner December 17, 2025 06:20
@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 17, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Mryange Mryange changed the title [fix](function) fix core if hll_from_base64 input invalid [fix](core) fix core if hll_from_base64 input invalid Dec 17, 2025
@Mryange
Copy link
Contributor Author

Mryange commented Dec 17, 2025

run buildall

zclllyybb
zclllyybb approved these changes Dec 17, 2025
View reviewed changes
Copy link
Contributor

@zclllyybb zclllyybb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 17, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 17, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 17, 2025

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Dec 17, 2025

TPC-H: Total hot run time: 35457 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 042b8e78b5a31f2c6d71f295641b9f702e546d47, data reload: false

------ Round 1 ----------------------------------
q1	17626	4205	4055	4055
q2	2033	364	233	233
q3	10162	1351	731	731
q4	10229	878	318	318
q5	7538	2176	1958	1958
q6	244	170	135	135
q7	1022	865	717	717
q8	9371	1467	1223	1223
q9	7290	5378	5340	5340
q10	6857	2389	1979	1979
q11	526	349	308	308
q12	699	733	584	584
q13	17793	3684	3038	3038
q14	289	302	282	282
q15	602	527	530	527
q16	723	683	630	630
q17	709	873	485	485
q18	7470	7127	7135	7127
q19	1108	981	606	606
q20	397	373	258	258
q21	4282	3947	4008	3947
q22	1031	1013	976	976
Total cold run time: 108001 ms
Total hot run time: 35457 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4165	4056	4035	4035
q2	350	384	328	328
q3	2156	2720	2285	2285
q4	1324	1762	1292	1292
q5	4276	4749	4681	4681
q6	249	195	131	131
q7	2058	1955	1832	1832
q8	2690	2570	2636	2570
q9	7469	7640	7550	7550
q10	3084	3239	2822	2822
q11	607	526	506	506
q12	661	958	631	631
q13	3692	3982	3256	3256
q14	294	319	305	305
q15	568	538	520	520
q16	660	736	695	695
q17	1237	1599	1479	1479
q18	7988	7640	7588	7588
q19	892	840	882	840
q20	2005	2163	1815	1815
q21	4652	4273	4169	4169
q22	1053	1062	958	958
Total cold run time: 52130 ms
Total hot run time: 50288 ms

@doris-robot
Copy link

doris-robot commented Dec 17, 2025

TPC-DS: Total hot run time: 178849 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 042b8e78b5a31f2c6d71f295641b9f702e546d47, data reload: false

query5	4705	596	444	444
query6	334	239	218	218
query7	4243	476	271	271
query8	307	269	245	245
query9	8812	2535	2561	2535
query10	501	364	352	352
query11	15387	15152	14845	14845
query12	188	117	123	117
query13	1278	501	393	393
query14	6289	3074	2781	2781
query14_1	2681	2656	2667	2656
query15	221	198	187	187
query16	901	466	446	446
query17	1133	709	612	612
query18	2548	443	361	361
query19	239	235	207	207
query20	123	120	115	115
query21	236	146	121	121
query22	4037	3948	3863	3863
query23	16529	16290	16095	16095
query23_1	16047	16124	15987	15987
query24	7363	1661	1231	1231
query24_1	1271	1230	1268	1230
query25	595	495	440	440
query26	1252	264	162	162
query27	2766	465	313	313
query28	4483	2139	2136	2136
query29	827	602	474	474
query30	320	247	217	217
query31	818	722	657	657
query32	87	73	71	71
query33	563	345	302	302
query34	910	906	544	544
query35	799	868	726	726
query36	867	912	844	844
query37	131	89	79	79
query38	2874	2926	2826	2826
query39	762	738	713	713
query39_1	703	711	702	702
query40	222	136	119	119
query41	69	62	63	62
query42	110	106	108	106
query43	423	434	392	392
query44	1340	755	745	745
query45	200	188	184	184
query46	871	977	607	607
query47	1646	1676	1631	1631
query48	336	329	259	259
query49	615	433	350	350
query50	661	300	212	212
query51	3802	3842	3806	3806
query52	104	115	98	98
query53	322	346	291	291
query54	279	257	262	257
query55	77	73	74	73
query56	306	310	292	292
query57	1159	1139	1082	1082
query58	308	253	259	253
query59	2366	2563	2364	2364
query60	310	314	301	301
query61	166	157	164	157
query62	709	677	626	626
query63	327	291	294	291
query64	4960	1296	1010	1010
query65	4043	3927	3977	3927
query66	1436	444	313	313
query67	15106	14743	14902	14743
query68	8332	998	736	736
query69	506	356	317	317
query70	1080	1001	992	992
query71	383	310	281	281
query72	5999	4875	5088	4875
query73	669	576	312	312
query74	8815	8747	8633	8633
query75	3258	3155	2802	2802
query76	3888	1160	740	740
query77	613	387	302	302
query78	9457	9563	8912	8912
query79	1524	945	610	610
query80	756	667	543	543
query81	536	270	245	245
query82	439	133	104	104
query83	264	253	247	247
query84	277	120	101	101
query85	912	510	456	456
query86	413	316	281	281
query87	3052	3014	2925	2925
query88	3330	2277	2249	2249
query89	465	428	396	396
query90	2161	163	155	155
query91	175	161	143	143
query92	87	75	61	61
query93	1981	897	565	565
query94	477	308	269	269
query95	579	378	311	311
query96	604	475	211	211
query97	2267	2321	2237	2237
query98	220	197	200	197
query99	1296	1343	1220	1220
Total cold run time: 261175 ms
Total hot run time: 178849 ms

@doris-robot
Copy link

doris-robot commented Dec 17, 2025

ClickBench: Total hot run time: 27.4 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 042b8e78b5a31f2c6d71f295641b9f702e546d47, data reload: false

query1	0.05	0.05	0.05
query2	0.10	0.05	0.05
query3	0.26	0.08	0.08
query4	1.61	0.12	0.10
query5	0.27	0.26	0.27
query6	1.17	0.64	0.62
query7	0.03	0.02	0.02
query8	0.06	0.04	0.04
query9	0.58	0.51	0.51
query10	0.56	0.56	0.55
query11	0.15	0.10	0.12
query12	0.15	0.13	0.12
query13	0.61	0.61	0.62
query14	1.00	0.97	1.00
query15	0.81	0.80	0.82
query16	0.39	0.40	0.39
query17	0.99	1.03	1.02
query18	0.23	0.21	0.22
query19	1.99	1.80	1.88
query20	0.02	0.02	0.01
query21	15.44	0.29	0.14
query22	4.71	0.06	0.05
query23	15.94	0.29	0.10
query24	0.98	0.33	0.34
query25	0.09	0.08	0.06
query26	0.14	0.14	0.14
query27	0.06	0.08	0.05
query28	3.34	1.22	1.03
query29	12.65	3.98	3.24
query30	0.28	0.14	0.12
query31	2.82	0.64	0.39
query32	3.23	0.55	0.47
query33	2.97	3.00	3.05
query34	16.68	5.23	4.57
query35	4.53	4.54	4.53
query36	0.67	0.50	0.50
query37	0.11	0.07	0.06
query38	0.08	0.05	0.04
query39	0.04	0.03	0.03
query40	0.17	0.15	0.14
query41	0.09	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.04	0.04
Total cold run time: 96.13 s
Total hot run time: 27.4 s

@doris-robot
Copy link

doris-robot commented Dec 17, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/2) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.43% (18840/35263)
Line Coverage 39.21% (174439/444921)
Region Coverage 33.77% (134997/399715)
Branch Coverage 34.68% (58143/167665)

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 17, 2025

BE Regression && UT Coverage Report

Increment line coverage 100.00% (2/2) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 73.89% (25532/34556)
Line Coverage 61.27% (272240/444306)
Region Coverage 56.13% (226971/404342)
Branch Coverage 58.04% (97791/168476)

HappenLee
HappenLee approved these changes Dec 18, 2025
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mryange
Copy link
Contributor Author

Mryange commented Dec 18, 2025

run external

@Gabriel39 Gabriel39 merged commit 15d2a42 into apache:master Dec 18, 2025
33 of 34 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 18, 2025
@Mryange
[fix](core) fix core if hll_from_base64 input invalid (#59106)
9f1125d 
```
mysql>  SELECT hll_from_base64(CAST('AgAAAAAAAABwAAAAAAAAAA==' AS VARCHAR(100))) AS result;
ERROR 1105 (HY000): RpcException, msg: send fragments failed. io.grpc.StatusRuntimeException: UNAVAILABLE: io exception, host: 127.0.0.1
```


now
```
mysql>  SELECT hll_from_base64(CAST('AgAAAAAAAABwAAAAAAAAAA==' AS VARCHAR(100))) AS result;
ERROR 1105 (HY000): errCode = 2, detailMessage = (127.0.0.1)[RUNTIME_ERROR]hll_from_base64 decode failed: base64: AgAAAAAAAABwAAAAAAAAAA==
```
@github-actions github-actions bot mentioned this pull request Dec 18, 2025
Merged
yiguolei pushed a commit that referenced this pull request Dec 19, 2025
@github-actions @Mryange
branch-4.0: [fix](core) fix core if hll_from_base64 input invalid #59106
3c878bc 
 (#59147)

Cherry-picked from #59106

Co-authored-by: Mryange <yanxuecheng@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HappenLee HappenLee HappenLee approved these changes

@zclllyybb zclllyybb zclllyybb approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Mryange @hello-stephen @doris-robot @HappenLee @zclllyybb @yiguolei @Gabriel39