branch-4.0: [Improvement](Iceberg) Optimize LocationPath.of performance for Iceberg table queries #59217 #59427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rg table queries (#59217) ### What problem does this PR solve? ### Problem When querying Iceberg tables with large number of data files, `LocationPath.of` method consumes significant CPU time. The main bottlenecks are: 1. Repeated regex parsing in `S3URI.create()` for each file path 2. Multiple `String.split()` calls for scheme extraction 3. Repeated `StorageProperties` lookup from map for each file ### Solution This PR introduces several optimizations to reduce CPU overhead: #### 1. Optimize scheme parsing in `LocationPath.parseScheme` - Replace `String.split("://")` with `indexOf` + `substring` to avoid array allocation #### 2. Add fast path for S3-compatible schemes in `S3PropertyUtils.validateAndNormalizeUri` - For simple S3-compatible URIs like `oss://bucket/key`, `s3a://bucket/key`, use direct string replacement instead of full S3URI regex parsing - Only fall back to full S3URI parsing for complex HTTP URLs #### 3. Add path prefix caching in `IcebergScanNode` - Cache `StorageProperties`, schema, and path prefix mapping on first file - For subsequent files with the same prefix, directly transform paths using string replacement - New `LocationPath.ofDirect()` method to create LocationPath without any parsing
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
yiguolei
approved these changes
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #59217