branch-4.0: [Chore](thirdparty) add crc32c-1.1.2 to thirdparty #58462 #59519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doris have crc32c from rocksdb now, but it has poorly performance than google/crc32c. 66663538 rows int crc32c-rocksdb 684.879ms crc32c-google 206.360ms 66663538 rows varchar crc32c-rocksdb 1sec368ms crc32c-google 391.290ms This pull request adds support for the `crc32c` third-party dependency to the build environment. The changes include updating the changelog, adding build logic, and configuring the necessary variables to download and build `crc32c`. **Third-party dependency integration:** * Added `crc32c-1.1.2` to the list of third-party dependencies in the changelog (`thirdparty/CHANGELOG.md`). * Added `crc32c` to the default package build list in `build-thirdparty.sh` to ensure it is built by default. * Implemented the `build_crc32c()` function in `build-thirdparty.sh` to handle the build and installation process for `crc32c`. **Build configuration updates:** * Defined download URL, archive name, source directory, and MD5 checksum for `crc32c` in `vars.sh`. * Added `CRC32C` to the `TP_ARCHIVES` array in `vars.sh` so it is included in the set of managed third-party archives.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
yiguolei
approved these changes
Jan 4, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #58462