Skip to content

[chore](spill) refactor lambda to function #59584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Jan 6, 2026
Merged

[chore](spill) refactor lambda to function #59584

yiguolei merged 1 commit into from
Jan 6, 2026

Conversation

@jacktengg
Copy link
Contributor

@jacktengg jacktengg commented Jan 6, 2026

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@jacktengg
Copy link
Contributor Author

jacktengg commented Jan 6, 2026

run buildall

@doris-robot
Copy link

doris-robot commented Jan 6, 2026

TPC-H: Total hot run time: 32183 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3143b210971a58eadc09d8510df81d6a227e7d7a, data reload: false

------ Round 1 ----------------------------------
q1	17714	4212	4059	4059
q2	2133	357	246	246
q3	10147	1233	708	708
q4	10263	849	320	320
q5	7467	2067	1873	1873
q6	189	172	138	138
q7	921	795	675	675
q8	9258	1330	1253	1253
q9	4872	4595	4540	4540
q10	6897	1790	1404	1404
q11	545	277	294	277
q12	724	733	572	572
q13	17907	3902	3141	3141
q14	288	291	273	273
q15	576	511	501	501
q16	690	678	629	629
q17	738	811	521	521
q18	6756	6469	6850	6469
q19	1124	1039	705	705
q20	403	391	269	269
q21	3272	2566	2716	2566
q22	1176	1117	1044	1044
Total cold run time: 104060 ms
Total hot run time: 32183 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4288	4296	4230	4230
q2	346	421	308	308
q3	2301	2837	2450	2450
q4	1426	1942	1425	1425
q5	4361	4362	4263	4263
q6	222	171	130	130
q7	1897	1884	1788	1788
q8	2586	2398	2403	2398
q9	7267	7092	7087	7087
q10	2449	2673	2260	2260
q11	545	465	455	455
q12	782	761	629	629
q13	3758	3844	3158	3158
q14	264	281	258	258
q15	532	481	499	481
q16	622	643	624	624
q17	1087	1207	1323	1207
q18	7471	7387	7177	7177
q19	833	800	808	800
q20	1894	1979	1869	1869
q21	4746	4411	4316	4316
q22	1124	1067	1054	1054
Total cold run time: 50801 ms
Total hot run time: 48367 ms

@doris-robot
Copy link

doris-robot commented Jan 6, 2026

TPC-DS: Total hot run time: 172791 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3143b210971a58eadc09d8510df81d6a227e7d7a, data reload: false

query5	4759	562	422	422
query6	343	249	229	229
query7	4246	449	271	271
query8	349	255	240	240
query9	8764	2655	2672	2655
query10	537	377	320	320
query11	15315	15114	15045	15045
query12	205	119	116	116
query13	1249	499	373	373
query14	6405	2983	2766	2766
query14_1	2634	2647	2834	2647
query15	200	194	178	178
query16	1066	478	471	471
query17	1085	674	585	585
query18	2519	443	348	348
query19	229	232	198	198
query20	134	120	118	118
query21	483	152	119	119
query22	3882	4045	3954	3954
query23	15942	15611	15303	15303
query23_1	15449	15510	15349	15349
query24	7381	1585	1218	1218
query24_1	1207	1203	1207	1203
query25	562	478	437	437
query26	1279	266	157	157
query27	2728	449	295	295
query28	4516	2150	2157	2150
query29	799	565	488	488
query30	332	239	210	210
query31	775	625	546	546
query32	74	66	66	66
query33	535	332	294	294
query34	866	878	525	525
query35	759	778	691	691
query36	821	818	792	792
query37	149	97	77	77
query38	2711	2688	2604	2604
query39	775	762	721	721
query39_1	739	701	713	701
query40	230	132	118	118
query41	67	63	64	63
query42	107	103	102	102
query43	443	466	418	418
query44	1331	731	725	725
query45	194	185	178	178
query46	865	959	593	593
query47	1412	1444	1397	1397
query48	308	314	244	244
query49	721	418	332	332
query50	628	260	201	201
query51	3812	3879	3835	3835
query52	102	108	98	98
query53	290	325	271	271
query54	283	262	245	245
query55	82	78	72	72
query56	284	280	285	280
query57	1024	1001	898	898
query58	265	251	248	248
query59	2172	2256	1916	1916
query60	316	322	299	299
query61	163	152	158	152
query62	383	350	309	309
query63	299	274	277	274
query64	4876	1293	990	990
query65	3728	3696	3739	3696
query66	1416	434	297	297
query67	15143	15633	14942	14942
query68	6498	999	715	715
query69	491	355	321	321
query70	1066	955	907	907
query71	366	297	287	287
query72	6219	3370	3405	3370
query73	795	722	299	299
query74	8777	8764	8645	8645
query75	2808	2839	2477	2477
query76	3901	1083	646	646
query77	508	363	280	280
query78	9625	9904	9167	9167
query79	975	900	578	578
query80	651	584	494	494
query81	485	262	223	223
query82	212	145	109	109
query83	276	254	240	240
query84	254	123	102	102
query85	887	523	456	456
query86	375	296	307	296
query87	2852	2842	2741	2741
query88	3108	2289	2228	2228
query89	374	367	316	316
query90	1947	152	148	148
query91	170	161	140	140
query92	75	66	67	66
query93	953	905	543	543
query94	569	364	285	285
query95	576	320	362	320
query96	603	448	206	206
query97	2296	2361	2311	2311
query98	237	214	203	203
query99	660	580	503	503
Total cold run time: 252793 ms
Total hot run time: 172791 ms

@doris-robot
Copy link

doris-robot commented Jan 6, 2026

ClickBench: Total hot run time: 27.37 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3143b210971a58eadc09d8510df81d6a227e7d7a, data reload: false

query1	0.06	0.05	0.04
query2	0.14	0.05	0.06
query3	0.27	0.09	0.09
query4	1.60	0.12	0.11
query5	0.28	0.25	0.27
query6	1.15	0.68	0.65
query7	0.02	0.03	0.03
query8	0.06	0.04	0.04
query9	0.58	0.50	0.50
query10	0.55	0.55	0.55
query11	0.16	0.09	0.09
query12	0.15	0.12	0.11
query13	0.60	0.59	0.59
query14	0.94	0.95	0.95
query15	0.80	0.78	0.77
query16	0.41	0.41	0.38
query17	0.99	1.07	1.10
query18	0.23	0.22	0.21
query19	1.90	1.86	1.88
query20	0.02	0.01	0.01
query21	15.43	0.28	0.14
query22	5.16	0.05	0.05
query23	15.98	0.28	0.10
query24	2.36	0.57	1.04
query25	0.09	0.09	0.07
query26	0.14	0.14	0.13
query27	0.06	0.06	0.05
query28	5.84	1.07	0.88
query29	12.60	4.00	3.20
query30	0.28	0.13	0.12
query31	2.83	0.65	0.40
query32	3.24	0.57	0.46
query33	3.01	3.05	3.03
query34	16.81	5.10	4.49
query35	4.53	4.51	4.50
query36	0.64	0.50	0.49
query37	0.13	0.06	0.07
query38	0.08	0.05	0.04
query39	0.06	0.02	0.02
query40	0.18	0.14	0.13
query41	0.09	0.03	0.03
query42	0.05	0.03	0.03
query43	0.04	0.03	0.04
Total cold run time: 100.54 s
Total hot run time: 27.37 s

@doris-robot
Copy link

doris-robot commented Jan 6, 2026

BE UT Coverage Report

Increment line coverage 91.35% (285/312) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.23% (18970/35640)
Line Coverage 39.19% (175766/448500)
Region Coverage 33.70% (136009/403635)
Branch Coverage 34.70% (58758/169312)

@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 6, 2026

BE Regression && UT Coverage Report

Increment line coverage 91.35% (285/312) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 72.19% (25153/34841)
Line Coverage 58.92% (263543/447282)
Region Coverage 53.64% (218731/407755)
Branch Coverage 55.30% (93932/169861)

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 6, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

PR approved by anyone and no changes requested.

@jacktengg
Copy link
Contributor Author

jacktengg commented Jan 6, 2026

run vault_p0

mrhhsg
mrhhsg approved these changes Jan 6, 2026
View reviewed changes
Copy link
Member

@mrhhsg mrhhsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yiguolei yiguolei merged commit a8a92f9 into apache:master Jan 6, 2026
28 of 30 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 6, 2026
@jacktengg
[chore](spill) refactor lambda to function (#59584)
d3df16c 
### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@github-actions github-actions bot mentioned this pull request Jan 6, 2026
Merged
yiguolei pushed a commit that referenced this pull request Jan 7, 2026
@github-actions @jacktengg
branch-4.0: [chore](spill) refactor lambda to function #59584 (#59592)
3fc1c03 
Cherry-picked from #59584

Co-authored-by: TengJianPing <tengjianping@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrhhsg mrhhsg mrhhsg approved these changes

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jacktengg @doris-robot @hello-stephen @mrhhsg @yiguolei