Skip to content

Revert "[Enhancement](sql-dialect) Support multiple sql-converter service urls (#52636)" #59610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 1 commit into from
Jan 7, 2026
Merged

Revert "[Enhancement](sql-dialect) Support multiple sql-converter service urls (#52636)" #59610

morningman merged 1 commit into from
Jan 7, 2026
+38 −599

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Jan 7, 2026

This may cause sql convertor read timeout

@Thearas
Copy link
Contributor

Thearas commented Jan 7, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morningman
Copy link
Contributor Author

morningman commented Jan 7, 2026

run buildall

@morningman morningman mentioned this pull request Jan 7, 2026
Merged
@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 7, 2026

FE UT Coverage Report

Increment line coverage 47.37% (9/19) 🎉
Increment coverage report
Complete coverage report

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 7, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

PR approved by anyone and no changes requested.

@morningman morningman merged commit 4cc3225 into apache:master Jan 7, 2026
31 of 32 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 7, 2026
@morningman
Revert "[Enhancement](sql-dialect) Support multiple sql-converter ser…
50a9604 
…vice urls (#52636)" (#59610)

This may cause sql convertor read timeout
@github-actions github-actions bot mentioned this pull request Jan 7, 2026
Closed
github-actions bot pushed a commit that referenced this pull request Jan 7, 2026
@morningman
Revert "[Enhancement](sql-dialect) Support multiple sql-converter ser…
06b9a3d 
…vice urls (#52636)" (#59610)

This may cause sql convertor read timeout
@github-actions github-actions bot mentioned this pull request Jan 7, 2026
Closed
yiguolei pushed a commit that referenced this pull request Jan 7, 2026
@morningman
branch-4.0: Revert "[Enhancement](sql-dialect) Support multiple sql-c…
bcb9b08 
…onverter service urls (#52636)" (#59611)

bp #59610
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CalvinKirs CalvinKirs CalvinKirs approved these changes

+1 more reviewer

@hubgeter hubgeter hubgeter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.x dev/4.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@morningman @Thearas @hello-stephen @CalvinKirs @hubgeter @yiguolei