-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](nereids) show columns type hide Column Version #59684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](nereids) show columns type hide Column Version #59684
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
morrySnow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a regression test case or ut
|
run buildall |
TPC-H: Total hot run time: 31826 ms |
TPC-DS: Total hot run time: 172961 ms |
FE UT Coverage ReportIncrement line coverage |
|
run buildall |
TPC-H: Total hot run time: 31021 ms |
TPC-DS: Total hot run time: 173235 ms |
…show-columns-hide-version
|
run buildall |
TPC-H: Total hot run time: 31318 ms |
TPC-DS: Total hot run time: 172944 ms |
ClickBench: Total hot run time: 26.75 s |
FE UT Coverage ReportIncrement line coverage |
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 31291 ms |
TPC-DS: Total hot run time: 174023 ms |
ClickBench: Total hot run time: 26.5 s |
FE UT Coverage ReportIncrement line coverage |
FE Regression Coverage ReportIncrement line coverage |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
### What problem does this PR solve?
This update fixes an issue where the `SHOW FULL COLUMNS` statement still
displayed `version` for `date`, `datetime`, and `decimal` data types.
This change aims for better compatibility with MySQL behavior and BI
applications.
```txt
MySQL [(none)]> SHOW FULL COLUMNS FROM `doris_all_types_demo` FROM `tpch`;
+---------------------------+---------------+-----------+------+------+---------+-------+------------+-----------------------------------------------------+
| Field | Type | Collation | Null | Key | Default | Extra | Privileges | Comment |
+---------------------------+---------------+-----------+------+------+---------+-------+------------+-----------------------------------------------------+
| col_09_decimal | decimal(10,2) | | YES | NO | NULL | NONE | | DECIMAL: exact decimal (precision, scale) |
| col_14_date | date | | YES | NO | NULL | NONE | | DATE: date format YYYY-MM-DD |
| col_15_datetime | datetime | | YES | NO | NULL | NONE | | DATETIME: datetime format YYYY-MM-DD HH:MM:SS |
| col_16_datetime_precision | datetime(3) | | YES | NO | NULL | NONE | | DATETIME(3): datetime with millisecond precision |
+---------------------------+---------------+-----------+------+------+---------+-------+------------+-----------------------------------------------------+
```
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [x] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [x] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
What problem does this PR solve?
This update fixes an issue where the
SHOW FULL COLUMNSstatement still displayedversionfordate,datetime, anddecimaldata types. This change aims for better compatibility with MySQL behavior and BI applications.Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)