-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Fix](Streaming) fix get remote meta failed to pause streaming job #59760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR aims to fix an issue where streaming jobs fail to pause correctly when fetching remote metadata fails. The fix addresses the auto-resume mechanism that could incorrectly wake up manually paused jobs.
Changes:
- Added
volatilemodifier to thefailureReasonfield for thread-safe access - Modified error handling in
fetchMeta()to check existing failure reasons before setting new ones - Added logic to pause the job and trigger auto-resume when metadata fetch fails
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...-core/src/main/java/org/apache/doris/job/extensions/insert/streaming/StreamingInsertJob.java
Outdated
Show resolved
Hide resolved
...-core/src/main/java/org/apache/doris/job/extensions/insert/streaming/StreamingInsertJob.java
Show resolved
Hide resolved
...-core/src/main/java/org/apache/doris/job/extensions/insert/streaming/StreamingInsertJob.java
Show resolved
Hide resolved
|
run buildall |
TPC-H: Total hot run time: 32111 ms |
TPC-DS: Total hot run time: 173551 ms |
|
run cloud_p0 |
FE UT Coverage ReportIncrement line coverage |
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 31701 ms |
TPC-DS: Total hot run time: 172533 ms |
|
run cloud_p0 |
FE UT Coverage ReportIncrement line coverage |
FE Regression Coverage ReportIncrement line coverage |
|
run cloud_p0 |
FE Regression Coverage ReportIncrement line coverage |
1 similar comment
FE Regression Coverage ReportIncrement line coverage |
sollhui
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by anyone and no changes requested. |
|
PR approved by at least one committer and no changes requested. |
…pache#59760) ### What problem does this PR solve? fix get remote meta failed to pause streaming job Releate PR: apache#58898
What problem does this PR solve?
fix get remote meta failed to pause streaming job
Releate PR: #58898
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)