-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[enhance](file cache) clear file cache when load failed #59864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
2457f03 to
edbf31e
Compare
|
run buildall |
TPC-H: Total hot run time: 31125 ms |
TPC-DS: Total hot run time: 172837 ms |
ClickBench: Total hot run time: 26.73 s |
edbf31e to
8dec69a
Compare
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
8dec69a to
082a257
Compare
|
run buildall |
TPC-H: Total hot run time: 31735 ms |
TPC-DS: Total hot run time: 173434 ms |
ClickBench: Total hot run time: 27.12 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
1 similar comment
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
liaoxin01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
082a257 to
626051f
Compare
|
run buildall |
TPC-H: Total hot run time: 31772 ms |
TPC-DS: Total hot run time: 174359 ms |
ClickBench: Total hot run time: 26.77 s |
626051f to
5e5f062
Compare
|
run buildall |
TPC-H: Total hot run time: 31839 ms |
TPC-DS: Total hot run time: 174317 ms |
ClickBench: Total hot run time: 26.62 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
liaoxin01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
### What problem does this PR solve? Clear file cache when load failed to eliminate invalid cache data, which can ensure valuable data is cached. **Note: This pr can not solve the issue that some rowset commit success some commit fail or commit transaction fail, and it will be solved in other pr.**
What problem does this PR solve?
Clear file cache when load failed to eliminate invalid cache data, which can ensure valuable data is cached.
Note: This pr can not solve the issue that some rowset commit success some commit fail or commit transaction fail, and it will be solved in other pr.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)