[Opt](function) Optimize like function for non-literal modes #59866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31344 ms |
TPC-DS: Total hot run time: 172554 ms |
ClickBench: Total hot run time: 26.62 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 32201 ms |
TPC-DS: Total hot run time: 173885 ms |
ClickBench: Total hot run time: 26.92 s |
Gabriel39
approved these changes
Jan 15, 2026
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
BiteTheDDDDt
approved these changes
Jan 15, 2026
There was a problem hiding this comment.
Pull request overview
This PR optimizes the LIKE function for non-literal pattern modes by introducing fast-path pattern analysis to avoid regex compilation for simple patterns. The optimization reduces query time from over 4 minutes to 4.5 seconds (a ~54x speedup) for patterns like LIKE concat('%', SearchPhrase, '%').
Changes:
- Added
LikeFastPathenum to categorize pattern types (ALLPASS, EQUALS, STARTS_WITH, ENDS_WITH, SUBSTRING, REGEX) - Introduced
extract_like_fast_pathfunction for lightweight pattern analysis without regex compilation - Modified
like_fn_scalarto use fast-path implementations before falling back to regex
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| be/src/vec/functions/like.h | Added LikeFastPath enum and extract_like_fast_path function for pattern analysis; updated includes to C++ standard headers |
| be/src/vec/functions/like.cpp | Modified like_fn_scalar to implement fast-path matching for simple patterns before falling back to regex |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
run beut |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run p0 |
Contributor
Author
|
run external |
Contributor
Author
|
run vault_p0 |
Contributor
Author
|
run cloud_p0 |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
github-actions bot
pushed a commit
that referenced
this pull request
Jan 16, 2026
before:
```sql
mysql> SELECT count(*) FROM hits_100m WHERE URL LIKE concat('%', SearchPhrase, '%');
+----------+
| count(*) |
+----------+
| 90144150 |
+----------+
1 row in set (4 min 5.15 sec)
```
now:
```sql
mysql> SELECT count(*) FROM hits_100m WHERE URL LIKE concat('%', SearchPhrase, '%');
+----------+
| count(*) |
+----------+
| 90144150 |
+----------+
1 row in set (4.50 sec)
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
before:
now:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)