Skip to content

[fix](azure) Handle rate limit exception for azure client #59867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gavinchou merged 1 commit into from
Jan 16, 2026
Merged

[fix](azure) Handle rate limit exception for azure client #59867

gavinchou merged 1 commit into from
Jan 16, 2026

Conversation

@wyxxxcat
Copy link
Contributor

@wyxxxcat wyxxxcat commented Jan 14, 2026 •
edited
Loading

What problem does this PR solve?

rate limit will throw std::runtime_error, but some functions don't use do_azure_client_call to handle it.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jan 14, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wyxxxcat
Copy link
Contributor Author

wyxxxcat commented Jan 14, 2026

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 14, 2026

Cloud UT Coverage Report

Increment line coverage 0.00% (0/50) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 79.50% (1784/2244)
Line Coverage 64.74% (31735/49018)
Region Coverage 65.43% (15785/24124)
Branch Coverage 55.98% (8383/14974)

@doris-robot
Copy link

doris-robot commented Jan 14, 2026

TPC-H: Total hot run time: 31583 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a57ee2adc66399fc642369a7657cfc3dc420f366, data reload: false

------ Round 1 ----------------------------------
q1	17608	4245	4031	4031
q2	2025	379	245	245
q3	10127	1278	731	731
q4	10235	944	315	315
q5	7524	2082	1855	1855
q6	192	176	139	139
q7	960	789	664	664
q8	9277	1403	1100	1100
q9	5071	4645	4682	4645
q10	6819	1843	1402	1402
q11	537	321	295	295
q12	726	739	572	572
q13	17797	3843	3090	3090
q14	291	290	290	290
q15	611	522	506	506
q16	685	684	628	628
q17	663	739	557	557
q18	6728	6450	6503	6450
q19	1102	959	607	607
q20	388	362	252	252
q21	3027	2505	2246	2246
q22	1024	1033	963	963
Total cold run time: 103417 ms
Total hot run time: 31583 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4133	4041	4049	4041
q2	338	415	331	331
q3	2101	2542	2174	2174
q4	1327	1750	1320	1320
q5	4146	4060	3996	3996
q6	218	190	133	133
q7	1862	1844	1714	1714
q8	2881	2476	2460	2460
q9	7128	7239	7118	7118
q10	2697	2821	2323	2323
q11	574	488	462	462
q12	709	778	630	630
q13	3634	4172	3533	3533
q14	294	300	294	294
q15	551	521	529	521
q16	648	713	653	653
q17	1215	1362	1417	1362
q18	8076	7890	7992	7890
q19	941	862	1005	862
q20	1989	2029	1976	1976
q21	4956	4523	4370	4370
q22	1063	1036	977	977
Total cold run time: 51481 ms
Total hot run time: 49140 ms

@doris-robot
Copy link

doris-robot commented Jan 14, 2026

TPC-DS: Total hot run time: 173367 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a57ee2adc66399fc642369a7657cfc3dc420f366, data reload: false

query5	4394	611	482	482
query6	313	226	208	208
query7	4244	456	262	262
query8	362	248	239	239
query9	8749	2914	2887	2887
query10	507	396	325	325
query11	15254	15303	14941	14941
query12	172	117	124	117
query13	1272	477	393	393
query14	6177	3035	2741	2741
query14_1	2651	2703	2653	2653
query15	204	195	176	176
query16	1017	501	473	473
query17	1121	700	589	589
query18	2500	443	355	355
query19	222	217	204	204
query20	121	119	114	114
query21	215	142	120	120
query22	3797	4123	4089	4089
query23	16611	15605	15276	15276
query23_1	15319	15592	15432	15432
query24	7092	1564	1163	1163
query24_1	1174	1181	1170	1170
query25	562	482	430	430
query26	1242	279	164	164
query27	2737	489	263	263
query28	4514	2162	2128	2128
query29	749	520	441	441
query30	308	242	208	208
query31	823	623	545	545
query32	84	79	75	75
query33	525	341	295	295
query34	868	860	512	512
query35	711	783	679	679
query36	896	926	824	824
query37	133	101	80	80
query38	2759	2743	2639	2639
query39	764	759	723	723
query39_1	694	709	720	709
query40	219	136	119	119
query41	67	63	61	61
query42	102	102	98	98
query43	440	454	420	420
query44	1342	730	730	730
query45	187	181	175	175
query46	822	940	574	574
query47	1358	1502	1407	1407
query48	319	329	230	230
query49	617	422	347	347
query50	618	280	207	207
query51	3782	3781	3832	3781
query52	102	106	95	95
query53	293	315	269	269
query54	291	278	258	258
query55	81	79	75	75
query56	339	308	301	301
query57	974	981	914	914
query58	274	255	257	255
query59	2069	2209	2000	2000
query60	326	335	319	319
query61	163	160	155	155
query62	411	372	308	308
query63	303	260	271	260
query64	4915	1314	967	967
query65	3752	3708	3730	3708
query66	1453	430	310	310
query67	16005	15260	15498	15260
query68	4775	991	710	710
query69	518	360	326	326
query70	1033	889	920	889
query71	364	309	282	282
query72	5720	3636	3586	3586
query73	752	737	299	299
query74	8796	8713	8497	8497
query75	2838	2823	2505	2505
query76	3331	1077	663	663
query77	535	405	347	347
query78	9912	9822	9145	9145
query79	1846	894	546	546
query80	1592	577	491	491
query81	589	263	235	235
query82	417	142	110	110
query83	345	261	241	241
query84	260	115	97	97
query85	913	518	458	458
query86	486	303	281	281
query87	2834	2863	2736	2736
query88	2930	2123	2080	2080
query89	387	334	335	334
query90	1785	181	158	158
query91	172	168	141	141
query92	85	77	75	75
query93	1252	878	521	521
query94	642	327	299	299
query95	572	380	321	321
query96	559	485	195	195
query97	2332	2389	2341	2341
query98	234	201	192	192
query99	579	570	507	507
Total cold run time: 251876 ms
Total hot run time: 173367 ms

@doris-robot
Copy link

doris-robot commented Jan 14, 2026

ClickBench: Total hot run time: 26.69 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a57ee2adc66399fc642369a7657cfc3dc420f366, data reload: false

query1	0.06	0.04	0.05
query2	0.10	0.04	0.04
query3	0.25	0.09	0.09
query4	1.61	0.11	0.11
query5	0.29	0.25	0.25
query6	1.14	0.66	0.65
query7	0.04	0.02	0.02
query8	0.06	0.05	0.04
query9	0.55	0.50	0.49
query10	0.54	0.55	0.53
query11	0.14	0.10	0.10
query12	0.14	0.11	0.11
query13	0.60	0.60	0.59
query14	0.94	0.96	0.94
query15	0.80	0.77	0.76
query16	0.38	0.38	0.40
query17	1.03	1.05	1.09
query18	0.24	0.22	0.21
query19	1.98	1.78	1.83
query20	0.01	0.01	0.02
query21	15.44	0.24	0.14
query22	5.38	0.05	0.05
query23	16.18	0.28	0.10
query24	1.49	0.60	0.17
query25	0.12	0.08	0.06
query26	0.14	0.15	0.13
query27	0.07	0.08	0.05
query28	5.03	1.07	0.88
query29	12.54	3.92	3.19
query30	0.29	0.13	0.11
query31	2.82	0.62	0.40
query32	3.24	0.56	0.45
query33	3.00	3.07	3.08
query34	16.16	5.10	4.45
query35	4.46	4.43	4.48
query36	0.67	0.49	0.49
query37	0.10	0.06	0.06
query38	0.06	0.04	0.04
query39	0.05	0.03	0.03
query40	0.17	0.13	0.12
query41	0.08	0.03	0.04
query42	0.04	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 98.47 s
Total hot run time: 26.69 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 14, 2026

BE UT Coverage Report

Increment line coverage 0.00% (0/49) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.95% (18973/35830)
Line Coverage 39.00% (175793/450712)
Region Coverage 33.65% (136401/405301)
Branch Coverage 34.65% (58909/170003)

@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 16, 2026

BE Regression && UT Coverage Report

Increment line coverage 0.00% (0/49) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 73.88% (25940/35113)
Line Coverage 61.36% (276178/450128)
Region Coverage 56.34% (230886/409813)
Branch Coverage 58.17% (99339/170768)

@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2026

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jan 16, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2026

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 16, 2026

BE Regression && UT Coverage Report

Increment line coverage 0.00% (0/49) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 73.88% (25940/35113)
Line Coverage 61.36% (276178/450128)
Region Coverage 56.34% (230886/409813)
Branch Coverage 58.17% (99339/170768)

@gavinchou gavinchou merged commit efdf08e into apache:master Jan 16, 2026
30 of 31 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 16, 2026
@wyxxxcat
[fix](azure) Handle rate limit exception for azure client (#59867)
1a9af2c 
rate limit will throw `std::runtime_error`, but some functions don't use
`do_azure_client_call` to handle it.
@github-actions github-actions bot mentioned this pull request Jan 16, 2026
Merged
yiguolei pushed a commit that referenced this pull request Jan 17, 2026
@github-actions @wyxxxcat
branch-4.0: [fix](azure) Handle rate limit exception for azure client #…
bbc3aec 
…59867 (#59983)

Cherry-picked from #59867

Co-authored-by: Yixuan Wang <wangyixuan@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@dataroaring dataroaring Awaiting requested review from dataroaring dataroaring is a code owner

@w41ter w41ter Awaiting requested review from w41ter w41ter is a code owner

+1 more reviewer

@Hastyshell Hastyshell Hastyshell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.x dev/4.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@wyxxxcat @Thearas @hello-stephen @doris-robot @gavinchou @Hastyshell @yiguolei