Skip to content

Conversation

@zhangstar333
Copy link
Contributor

@zhangstar333 zhangstar333 commented Jan 15, 2026

What problem does this PR solve?

Problem Summary:
because the external catalog gen db_id and table_id by names.
so new catalog may have same table_id as the drop old catalog.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jan 15, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhangstar333
Copy link
Contributor Author

run buildall

@zhangstar333 zhangstar333 marked this pull request as ready for review January 16, 2026 06:34
@zhangstar333 zhangstar333 changed the title update [bug](analyze) fix the auto analyze column stats not work when have same table id Jan 16, 2026
@doris-robot
Copy link

TPC-H: Total hot run time: 31199 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4943be3c305e853cd30360897f6e495309597314, data reload: false

------ Round 1 ----------------------------------
q1	17597	4201	4083	4083
q2	2047	346	237	237
q3	10179	1245	706	706
q4	10214	857	305	305
q5	7504	2092	1916	1916
q6	189	167	135	135
q7	940	780	668	668
q8	9269	1377	1087	1087
q9	4788	4525	4530	4525
q10	6770	1801	1403	1403
q11	522	295	284	284
q12	688	745	606	606
q13	17772	3785	3072	3072
q14	291	298	287	287
q15	598	504	507	504
q16	690	679	630	630
q17	653	801	491	491
q18	6691	6425	6241	6241
q19	1097	968	597	597
q20	388	354	250	250
q21	2962	2379	2223	2223
q22	1038	1016	949	949
Total cold run time: 102887 ms
Total hot run time: 31199 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4112	4024	4029	4024
q2	322	373	336	336
q3	2108	2599	2199	2199
q4	1292	1750	1342	1342
q5	4098	3994	4070	3994
q6	207	171	128	128
q7	1872	1813	1676	1676
q8	2717	2456	2361	2361
q9	7599	7281	7385	7281
q10	2643	2799	2321	2321
q11	609	491	462	462
q12	736	816	638	638
q13	3654	4132	3476	3476
q14	278	305	273	273
q15	533	507	486	486
q16	632	678	640	640
q17	1159	1365	1504	1365
q18	7898	7823	7743	7743
q19	939	873	846	846
q20	1963	2038	1834	1834
q21	4455	4157	4107	4107
q22	1044	1067	995	995
Total cold run time: 50870 ms
Total hot run time: 48527 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173743 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4943be3c305e853cd30360897f6e495309597314, data reload: false

query5	4446	602	487	487
query6	325	225	207	207
query7	4230	462	248	248
query8	355	244	245	244
query9	8740	2841	2828	2828
query10	533	385	311	311
query11	15068	15302	14921	14921
query12	173	110	111	110
query13	1246	463	369	369
query14	6014	2983	2741	2741
query14_1	2666	2620	2661	2620
query15	194	196	176	176
query16	987	503	456	456
query17	1104	690	561	561
query18	2446	437	336	336
query19	225	223	194	194
query20	122	113	111	111
query21	215	137	118	118
query22	3955	4327	4082	4082
query23	16050	15638	15323	15323
query23_1	15433	15535	15605	15535
query24	7156	1536	1160	1160
query24_1	1140	1171	1170	1170
query25	550	501	384	384
query26	1235	264	149	149
query27	2791	441	271	271
query28	4556	2126	2124	2124
query29	754	504	403	403
query30	311	235	203	203
query31	827	613	569	569
query32	87	77	69	69
query33	510	345	306	306
query34	886	876	540	540
query35	724	747	676	676
query36	894	907	775	775
query37	129	93	80	80
query38	2697	2643	2585	2585
query39	751	764	732	732
query39_1	749	728	716	716
query40	219	133	117	117
query41	65	64	61	61
query42	101	98	97	97
query43	439	456	407	407
query44	1292	736	734	734
query45	181	179	172	172
query46	833	929	565	565
query47	1493	1482	1349	1349
query48	313	313	241	241
query49	596	451	347	347
query50	619	258	205	205
query51	3813	3744	3743	3743
query52	100	109	98	98
query53	286	329	266	266
query54	285	259	252	252
query55	83	87	75	75
query56	310	318	314	314
query57	1037	1012	958	958
query58	266	252	269	252
query59	2130	2035	2066	2035
query60	357	353	307	307
query61	143	148	147	147
query62	400	369	319	319
query63	299	270	267	267
query64	4912	1231	968	968
query65	3816	3690	3756	3690
query66	1449	421	323	323
query67	15558	15582	15388	15388
query68	2490	1065	738	738
query69	449	368	327	327
query70	992	867	932	867
query71	321	304	290	290
query72	5453	3407	3414	3407
query73	607	728	308	308
query74	8762	8805	8581	8581
query75	2763	2832	2446	2446
query76	2279	1055	641	641
query77	367	385	329	329
query78	9825	9768	9146	9146
query79	2225	891	589	589
query80	1693	581	469	469
query81	532	263	227	227
query82	1007	144	113	113
query83	325	252	242	242
query84	253	109	92	92
query85	917	480	421	421
query86	409	291	291	291
query87	2819	2871	2708	2708
query88	3444	2568	2559	2559
query89	383	347	318	318
query90	1988	177	165	165
query91	164	162	138	138
query92	79	70	72	70
query93	1048	876	521	521
query94	636	336	293	293
query95	573	329	369	329
query96	641	493	232	232
query97	2331	2398	2371	2371
query98	205	200	193	193
query99	640	588	501	501
Total cold run time: 248465 ms
Total hot run time: 173743 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 27.02 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4943be3c305e853cd30360897f6e495309597314, data reload: false

query1	0.06	0.05	0.05
query2	0.09	0.05	0.05
query3	0.26	0.08	0.08
query4	1.60	0.12	0.11
query5	0.28	0.26	0.27
query6	1.15	0.66	0.65
query7	0.03	0.03	0.03
query8	0.06	0.04	0.04
query9	0.56	0.51	0.49
query10	0.54	0.56	0.54
query11	0.15	0.10	0.09
query12	0.14	0.10	0.11
query13	0.62	0.58	0.58
query14	0.94	0.95	0.94
query15	0.78	0.78	0.76
query16	0.41	0.40	0.38
query17	1.07	1.07	1.05
query18	0.22	0.22	0.21
query19	1.87	1.86	1.90
query20	0.02	0.01	0.02
query21	15.45	0.27	0.14
query22	5.06	0.06	0.04
query23	15.88	0.27	0.11
query24	0.98	0.63	0.55
query25	0.06	0.08	0.06
query26	0.14	0.14	0.14
query27	0.07	0.06	0.06
query28	4.77	1.06	0.88
query29	12.54	3.87	3.13
query30	0.29	0.13	0.12
query31	2.81	0.60	0.39
query32	3.23	0.56	0.44
query33	3.00	2.97	3.06
query34	15.95	5.10	4.41
query35	4.51	4.45	4.44
query36	0.65	0.51	0.49
query37	0.11	0.07	0.06
query38	0.07	0.04	0.04
query39	0.04	0.03	0.04
query40	0.18	0.14	0.14
query41	0.09	0.03	0.03
query42	0.04	0.03	0.03
query43	0.05	0.04	0.04
Total cold run time: 96.82 s
Total hot run time: 27.02 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 0.00% (0/3) 🎉
Increment coverage report
Complete coverage report

@zhangstar333
Copy link
Contributor Author

run buildall

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jan 16, 2026
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@yujun777 yujun777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doris-robot
Copy link

TPC-H: Total hot run time: 31369 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9f62ce70bc5ceccb187d9e8d8cfcaa801925d0af, data reload: false

------ Round 1 ----------------------------------
q1	17612	4199	4053	4053
q2	2030	351	247	247
q3	10140	1271	706	706
q4	10212	846	308	308
q5	7485	2088	1832	1832
q6	188	166	139	139
q7	901	788	673	673
q8	9277	1378	1092	1092
q9	4951	4617	4620	4617
q10	6759	1768	1379	1379
q11	533	300	288	288
q12	690	741	561	561
q13	17791	3794	3067	3067
q14	285	290	277	277
q15	590	509	520	509
q16	706	687	634	634
q17	647	838	450	450
q18	7112	6454	6450	6450
q19	1110	964	614	614
q20	393	358	257	257
q21	3010	2446	2262	2262
q22	1036	1018	954	954
Total cold run time: 103458 ms
Total hot run time: 31369 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4092	4056	4040	4040
q2	331	410	325	325
q3	2092	2600	2186	2186
q4	1367	1792	1316	1316
q5	4163	4135	4164	4135
q6	214	172	134	134
q7	1887	1879	1829	1829
q8	2824	2480	2529	2480
q9	7274	7374	7408	7374
q10	2586	2767	2395	2395
q11	579	496	456	456
q12	760	792	648	648
q13	3757	4251	3647	3647
q14	291	323	294	294
q15	562	507	511	507
q16	680	706	653	653
q17	1218	1495	1489	1489
q18	8004	8056	7746	7746
q19	884	885	853	853
q20	2004	2040	1911	1911
q21	4878	4295	4048	4048
q22	1125	1037	983	983
Total cold run time: 51572 ms
Total hot run time: 49449 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173942 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9f62ce70bc5ceccb187d9e8d8cfcaa801925d0af, data reload: false

query5	4413	609	461	461
query6	349	223	213	213
query7	4225	461	263	263
query8	341	257	256	256
query9	8725	2923	2877	2877
query10	558	384	361	361
query11	15264	15186	14809	14809
query12	173	118	121	118
query13	1266	490	374	374
query14	5972	3004	2792	2792
query14_1	2701	2686	2684	2684
query15	203	192	178	178
query16	1000	478	469	469
query17	1097	656	571	571
query18	2444	428	332	332
query19	218	216	191	191
query20	124	116	114	114
query21	209	138	118	118
query22	3941	3999	3969	3969
query23	16198	15947	15401	15401
query23_1	15642	15585	15620	15585
query24	7161	1555	1164	1164
query24_1	1186	1172	1179	1172
query25	545	457	415	415
query26	1255	266	157	157
query27	2775	448	284	284
query28	4520	2195	2205	2195
query29	724	511	420	420
query30	312	242	207	207
query31	786	640	580	580
query32	81	75	76	75
query33	513	350	303	303
query34	899	886	541	541
query35	729	757	682	682
query36	893	892	836	836
query37	130	100	84	84
query38	2700	2740	2663	2663
query39	777	749	729	729
query39_1	714	705	741	705
query40	217	137	117	117
query41	69	61	63	61
query42	105	102	98	98
query43	420	442	415	415
query44	1324	758	763	758
query45	183	187	182	182
query46	817	938	588	588
query47	1431	1433	1307	1307
query48	305	330	235	235
query49	612	425	341	341
query50	615	268	208	208
query51	3815	3805	3821	3805
query52	102	109	103	103
query53	288	325	273	273
query54	287	260	261	260
query55	81	81	78	78
query56	309	322	317	317
query57	1137	1039	888	888
query58	271	266	260	260
query59	1974	2086	2176	2086
query60	331	342	317	317
query61	151	152	149	149
query62	384	359	313	313
query63	297	281	265	265
query64	4861	1268	981	981
query65	3822	3773	3729	3729
query66	1464	415	314	314
query67	15403	15549	15352	15352
query68	2430	1099	773	773
query69	455	369	318	318
query70	970	949	913	913
query71	326	307	289	289
query72	5261	3070	3267	3070
query73	631	750	322	322
query74	8788	8837	8520	8520
query75	2742	2820	2464	2464
query76	2272	1085	664	664
query77	366	415	312	312
query78	9757	9847	9221	9221
query79	2256	906	620	620
query80	1725	570	473	473
query81	548	272	224	224
query82	1001	153	111	111
query83	325	261	237	237
query84	246	124	90	90
query85	905	486	439	439
query86	403	287	292	287
query87	2894	2877	2705	2705
query88	3494	2588	2575	2575
query89	382	340	338	338
query90	1823	174	172	172
query91	169	159	134	134
query92	72	74	70	70
query93	1096	893	545	545
query94	643	316	303	303
query95	582	389	315	315
query96	655	494	230	230
query97	2356	2392	2343	2343
query98	204	202	202	202
query99	603	603	499	499
Total cold run time: 248207 ms
Total hot run time: 173942 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 26.99 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9f62ce70bc5ceccb187d9e8d8cfcaa801925d0af, data reload: false

query1	0.05	0.05	0.05
query2	0.10	0.05	0.04
query3	0.25	0.08	0.08
query4	1.61	0.12	0.11
query5	0.28	0.26	0.24
query6	1.16	0.66	0.65
query7	0.03	0.02	0.03
query8	0.05	0.04	0.04
query9	0.58	0.50	0.49
query10	0.56	0.53	0.56
query11	0.14	0.10	0.10
query12	0.15	0.11	0.11
query13	0.60	0.59	0.59
query14	0.94	0.95	0.95
query15	0.79	0.77	0.77
query16	0.39	0.38	0.42
query17	1.02	1.07	1.07
query18	0.23	0.21	0.22
query19	1.93	1.82	1.77
query20	0.02	0.01	0.01
query21	15.42	0.29	0.14
query22	5.18	0.05	0.04
query23	16.02	0.29	0.10
query24	1.84	0.56	0.57
query25	0.08	0.14	0.05
query26	0.14	0.13	0.13
query27	0.08	0.08	0.06
query28	4.37	1.10	0.88
query29	12.53	3.88	3.16
query30	0.27	0.14	0.12
query31	2.81	0.63	0.39
query32	3.23	0.55	0.45
query33	2.95	2.96	3.00
query34	16.02	5.08	4.40
query35	4.45	4.48	4.47
query36	0.63	0.51	0.51
query37	0.10	0.07	0.06
query38	0.07	0.04	0.04
query39	0.04	0.03	0.03
query40	0.17	0.15	0.13
query41	0.09	0.04	0.04
query42	0.04	0.03	0.03
query43	0.04	0.03	0.03
Total cold run time: 97.45 s
Total hot run time: 26.99 s

@zhangstar333 zhangstar333 merged commit 74373aa into apache:master Jan 16, 2026
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants