Skip to content

Conversation

@github-actions
Copy link
Contributor

Cherry-picked from #59965

…ng insert (#59965)

### What problem does this PR solve?

Related PR: #58166

Problem Summary:

When Observer FE receives edit logs from Master FE after a Hive insert
operation, it may miss adding new partitions to its partition values
cache. This happens because:

1. When inserting into a new partition, Master FE refreshes its cache
and gets the partition into its partition values cache
2. Master FE records the partition as MODIFIED (not NEW) in the edit log
if it already exists in HMS
3. Observer FE processes only newPartNames when updating partition
values cache, missing partitions marked as MODIFIED

Fix by merging both modifiedPartNames and newPartNames before adding to
the partition values cache, ensuring Observer FE stays synchronized with
Master FE.
@github-actions github-actions bot requested a review from yiguolei as a code owner January 17, 2026 15:37
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Jan 17, 2026
@hello-stephen
Copy link
Contributor

run buildall

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 0.00% (0/4) 🎉
Increment coverage report
Complete coverage report

@yiguolei yiguolei merged commit e7e8d45 into branch-4.0 Jan 18, 2026
25 of 28 checks passed
@github-actions github-actions bot deleted the auto-pick-59965-branch-4.0 branch January 18, 2026 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants