Skip to content

Conversation

@csun5285
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jan 19, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@csun5285
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 31955 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 30949dfad995503b522576c9f694a69df565efe6, data reload: false

------ Round 1 ----------------------------------
q1	17638	4172	4034	4034
q2	2101	356	240	240
q3	10128	1263	743	743
q4	10214	843	299	299
q5	7477	2022	1868	1868
q6	187	175	140	140
q7	946	786	643	643
q8	9258	1390	1122	1122
q9	4871	4657	4507	4507
q10	6715	1785	1407	1407
q11	504	299	300	299
q12	685	793	593	593
q13	17746	3823	3135	3135
q14	296	300	277	277
q15	568	513	511	511
q16	668	680	629	629
q17	637	774	537	537
q18	6607	6437	6807	6437
q19	1152	1081	697	697
q20	461	380	254	254
q21	3209	2645	2534	2534
q22	1174	1117	1049	1049
Total cold run time: 103242 ms
Total hot run time: 31955 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4281	4521	4265	4265
q2	349	398	313	313
q3	2268	2849	2450	2450
q4	1484	1929	1427	1427
q5	4492	4310	4278	4278
q6	253	170	130	130
q7	1954	1880	1773	1773
q8	2509	2610	2505	2505
q9	7198	7054	7126	7054
q10	2499	2701	2307	2307
q11	564	460	447	447
q12	673	772	639	639
q13	3611	4116	3135	3135
q14	269	294	255	255
q15	528	496	477	477
q16	620	669	605	605
q17	1111	1340	1351	1340
q18	7376	7321	7319	7319
q19	814	786	794	786
q20	1874	1943	1777	1777
q21	4455	4257	4029	4029
q22	1028	1014	1012	1012
Total cold run time: 50210 ms
Total hot run time: 48323 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173564 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 30949dfad995503b522576c9f694a69df565efe6, data reload: false

query5	4427	631	486	486
query6	329	233	203	203
query7	4231	458	256	256
query8	336	255	235	235
query9	8714	2887	2892	2887
query10	526	383	325	325
query11	15322	15097	14784	14784
query12	176	117	112	112
query13	1253	489	385	385
query14	6470	2985	2755	2755
query14_1	2696	2653	2645	2645
query15	200	191	170	170
query16	974	491	493	491
query17	1089	657	550	550
query18	2561	433	329	329
query19	221	218	191	191
query20	118	119	115	115
query21	218	145	114	114
query22	3969	3956	3982	3956
query23	15983	15794	15297	15297
query23_1	15364	15481	15464	15464
query24	7149	1535	1149	1149
query24_1	1135	1164	1156	1156
query25	501	417	356	356
query26	1233	274	145	145
query27	2759	437	273	273
query28	4543	2179	2181	2179
query29	764	512	405	405
query30	312	239	207	207
query31	829	617	585	585
query32	80	78	76	76
query33	541	378	301	301
query34	927	866	532	532
query35	733	741	688	688
query36	863	899	856	856
query37	121	95	83	83
query38	2644	2730	2684	2684
query39	766	748	739	739
query39_1	713	705	703	703
query40	221	130	114	114
query41	68	61	64	61
query42	100	101	100	100
query43	426	426	409	409
query44	1307	744	751	744
query45	181	180	178	178
query46	817	927	578	578
query47	1426	1457	1424	1424
query48	332	313	241	241
query49	596	423	335	335
query50	604	280	201	201
query51	3817	3776	3741	3741
query52	102	102	91	91
query53	285	320	266	266
query54	294	261	253	253
query55	86	79	76	76
query56	316	301	309	301
query57	1001	991	936	936
query58	273	256	262	256
query59	2077	2155	2034	2034
query60	329	312	300	300
query61	144	139	140	139
query62	388	367	332	332
query63	296	265	257	257
query64	4863	1217	936	936
query65	3821	3728	3736	3728
query66	1425	418	303	303
query67	15541	15578	15454	15454
query68	2411	1097	774	774
query69	451	367	326	326
query70	1016	872	931	872
query71	321	310	286	286
query72	5412	3257	3354	3257
query73	585	717	318	318
query74	8699	8703	8492	8492
query75	2742	2789	2464	2464
query76	2292	1037	644	644
query77	366	405	303	303
query78	9816	9957	9105	9105
query79	1069	890	582	582
query80	1312	555	469	469
query81	565	268	229	229
query82	990	141	115	115
query83	364	248	234	234
query84	251	114	94	94
query85	879	475	412	412
query86	409	293	276	276
query87	2863	2795	2735	2735
query88	3478	2573	2555	2555
query89	386	341	319	319
query90	1963	168	155	155
query91	180	154	128	128
query92	78	76	71	71
query93	983	897	539	539
query94	644	334	293	293
query95	583	324	358	324
query96	647	501	229	229
query97	2363	2422	2337	2337
query98	206	209	198	198
query99	624	591	530	530
Total cold run time: 246563 ms
Total hot run time: 173564 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 26.74 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 30949dfad995503b522576c9f694a69df565efe6, data reload: false

query1	0.05	0.04	0.04
query2	0.09	0.05	0.04
query3	0.26	0.09	0.08
query4	1.60	0.11	0.11
query5	0.27	0.25	0.25
query6	1.13	0.65	0.65
query7	0.03	0.03	0.03
query8	0.05	0.03	0.03
query9	0.58	0.50	0.50
query10	0.54	0.55	0.53
query11	0.14	0.09	0.10
query12	0.14	0.10	0.11
query13	0.60	0.58	0.59
query14	0.96	0.94	0.94
query15	0.80	0.77	0.78
query16	0.38	0.39	0.39
query17	1.04	1.04	1.05
query18	0.23	0.21	0.21
query19	1.88	1.84	1.82
query20	0.02	0.02	0.01
query21	15.43	0.25	0.14
query22	5.15	0.05	0.05
query23	15.96	0.28	0.10
query24	2.21	0.47	0.33
query25	0.06	0.06	0.05
query26	0.15	0.14	0.12
query27	0.07	0.08	0.06
query28	3.20	1.08	0.88
query29	12.55	3.88	3.11
query30	0.28	0.14	0.13
query31	2.81	0.64	0.39
query32	3.25	0.56	0.45
query33	2.97	2.99	3.11
query34	16.11	5.08	4.46
query35	4.44	4.43	4.42
query36	0.65	0.49	0.49
query37	0.10	0.07	0.06
query38	0.08	0.04	0.04
query39	0.05	0.03	0.03
query40	0.17	0.14	0.14
query41	0.09	0.04	0.03
query42	0.04	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 96.65 s
Total hot run time: 26.74 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.39% (19040/36340)
Line Coverage 35.69% (176301/494021)
Region Coverage 32.24% (136581/423611)
Branch Coverage 33.13% (59032/178158)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 73.13% (26048/35619)
Line Coverage 56.10% (276832/493463)
Region Coverage 53.93% (230873/428114)
Branch Coverage 55.60% (99482/178919)

eldenmoon
eldenmoon previously approved these changes Jan 20, 2026
Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 20, 2026
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@csun5285
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jan 20, 2026
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 20, 2026
@doris-robot
Copy link

TPC-H: Total hot run time: 31703 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8f46a1e93a6c447f2edcb072aeec322220b3ae3d, data reload: false

------ Round 1 ----------------------------------
q1	17611	4259	4068	4068
q2	2077	350	230	230
q3	10162	1248	696	696
q4	10217	845	306	306
q5	7505	2042	1874	1874
q6	182	165	136	136
q7	903	776	651	651
q8	9262	1421	1136	1136
q9	4886	4636	4516	4516
q10	6769	1777	1370	1370
q11	502	288	282	282
q12	694	783	625	625
q13	17790	3790	3074	3074
q14	284	289	267	267
q15	579	496	527	496
q16	688	685	627	627
q17	663	833	472	472
q18	6553	6278	6797	6278
q19	1345	1129	669	669
q20	404	379	258	258
q21	3333	2698	2644	2644
q22	1134	1050	1028	1028
Total cold run time: 103543 ms
Total hot run time: 31703 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4334	4295	4308	4295
q2	341	422	345	345
q3	2216	2778	2518	2518
q4	1425	1862	1345	1345
q5	4539	4382	4178	4178
q6	213	166	126	126
q7	1943	2137	1799	1799
q8	2523	2420	2327	2327
q9	7183	7200	7260	7200
q10	2480	2689	2352	2352
q11	539	453	442	442
q12	663	710	543	543
q13	3314	3787	3065	3065
q14	279	278	260	260
q15	515	502	478	478
q16	597	675	608	608
q17	1084	1262	1286	1262
q18	7364	7180	7257	7180
q19	823	793	791	791
q20	1865	1939	1792	1792
q21	4494	4251	4126	4126
q22	1017	991	964	964
Total cold run time: 49751 ms
Total hot run time: 47996 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173014 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8f46a1e93a6c447f2edcb072aeec322220b3ae3d, data reload: false

query5	4754	631	475	475
query6	315	222	212	212
query7	4218	453	263	263
query8	329	236	228	228
query9	8720	2884	2858	2858
query10	530	365	337	337
query11	15269	15112	14842	14842
query12	179	113	112	112
query13	1245	496	390	390
query14	6515	3003	2745	2745
query14_1	2680	2627	2660	2627
query15	205	186	169	169
query16	1002	499	453	453
query17	1039	611	527	527
query18	2665	413	316	316
query19	209	204	185	185
query20	115	112	111	111
query21	212	130	112	112
query22	3869	3974	3835	3835
query23	15950	15692	15175	15175
query23_1	15443	15362	15327	15327
query24	7151	1518	1157	1157
query24_1	1139	1132	1163	1132
query25	511	425	367	367
query26	1239	267	150	150
query27	2774	443	276	276
query28	4533	2174	2158	2158
query29	718	485	407	407
query30	312	240	206	206
query31	807	613	568	568
query32	82	70	72	70
query33	509	340	314	314
query34	883	866	528	528
query35	744	748	664	664
query36	870	905	813	813
query37	139	100	82	82
query38	2678	2691	2641	2641
query39	760	745	723	723
query39_1	699	713	720	713
query40	218	134	115	115
query41	67	64	66	64
query42	101	98	98	98
query43	448	460	406	406
query44	1377	744	748	744
query45	185	188	173	173
query46	824	935	574	574
query47	1392	1486	1418	1418
query48	317	319	232	232
query49	593	419	347	347
query50	605	262	196	196
query51	3723	3835	3845	3835
query52	103	105	94	94
query53	290	323	268	268
query54	286	249	252	249
query55	79	77	78	77
query56	284	290	303	290
query57	1029	1033	912	912
query58	263	247	246	246
query59	2131	2169	2179	2169
query60	324	327	311	311
query61	144	142	142	142
query62	385	355	309	309
query63	298	268	264	264
query64	4822	1240	959	959
query65	3817	3757	3752	3752
query66	1407	404	318	318
query67	15400	15536	15485	15485
query68	2465	1109	757	757
query69	451	357	321	321
query70	995	953	900	900
query71	326	305	285	285
query72	5284	3003	3329	3003
query73	577	719	311	311
query74	8642	8771	8586	8586
query75	2748	2793	2456	2456
query76	2283	1058	671	671
query77	373	381	335	335
query78	9651	9825	9087	9087
query79	1086	895	593	593
query80	636	609	496	496
query81	474	261	232	232
query82	1354	149	112	112
query83	370	261	249	249
query84	257	114	94	94
query85	889	549	483	483
query86	352	328	322	322
query87	2877	2896	2784	2784
query88	3532	2587	2557	2557
query89	394	341	330	330
query90	1856	172	166	166
query91	180	172	192	172
query92	83	74	67	67
query93	921	914	531	531
query94	459	308	284	284
query95	573	325	371	325
query96	642	492	238	238
query97	2357	2353	2288	2288
query98	210	197	194	194
query99	585	603	534	534
Total cold run time: 246058 ms
Total hot run time: 173014 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 26.6 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8f46a1e93a6c447f2edcb072aeec322220b3ae3d, data reload: false

query1	0.05	0.04	0.05
query2	0.11	0.05	0.04
query3	0.26	0.08	0.08
query4	1.61	0.12	0.11
query5	0.27	0.25	0.26
query6	1.14	0.66	0.65
query7	0.03	0.02	0.03
query8	0.05	0.04	0.03
query9	0.57	0.50	0.50
query10	0.55	0.53	0.55
query11	0.15	0.09	0.09
query12	0.14	0.12	0.11
query13	0.59	0.58	0.58
query14	0.95	0.96	0.93
query15	0.79	0.76	0.80
query16	0.40	0.36	0.39
query17	1.03	1.04	1.01
query18	0.23	0.21	0.21
query19	1.84	1.83	1.87
query20	0.01	0.03	0.01
query21	15.43	0.27	0.14
query22	5.06	0.05	0.04
query23	15.83	0.28	0.12
query24	1.43	0.28	0.37
query25	0.11	0.07	0.05
query26	0.14	0.13	0.14
query27	0.06	0.06	0.07
query28	3.16	1.06	0.88
query29	12.63	3.91	3.13
query30	0.27	0.14	0.12
query31	2.81	0.65	0.39
query32	3.23	0.55	0.46
query33	2.96	2.97	3.01
query34	15.88	5.07	4.44
query35	4.46	4.42	4.49
query36	0.66	0.50	0.47
query37	0.11	0.07	0.07
query38	0.07	0.04	0.04
query39	0.04	0.03	0.03
query40	0.17	0.15	0.13
query41	0.09	0.04	0.03
query42	0.05	0.03	0.03
query43	0.04	0.03	0.03
Total cold run time: 95.46 s
Total hot run time: 26.6 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.39% (19040/36340)
Line Coverage 35.69% (176319/494036)
Region Coverage 32.23% (136549/423607)
Branch Coverage 33.14% (59032/178155)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.47% (25458/35619)
Line Coverage 54.01% (266516/493478)
Region Coverage 51.69% (221293/428110)
Branch Coverage 53.08% (94965/178916)

Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eldenmoon eldenmoon merged commit 400ab21 into apache:master Jan 20, 2026
29 of 32 checks passed
yiguolei pushed a commit that referenced this pull request Jan 20, 2026
…ing #60035 (#60065)

Cherry-picked from #60035

Co-authored-by: Sun Chenyang <sunchenyang@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.3-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants