[Chore](pick) pick #59906 #59786

[BiteTheDDDDt]

#59906
#59786

[hello-stephen]

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?

[BiteTheDDDDt]

run buildall

[Copilot]

Pull request overview

This PR is a pick of two previous pull requests that refactor runtime filter handling and remove stale UDF-related code. The main changes include refactoring the try_append_late_arrival_runtime_filter interface to use references instead of pointers, removing redundant methods, adding thread safety with mutexes, and simplifying conjunct management logic in scanners.

Changes:

• Refactored RuntimeFilterConsumerHelper::try_append_late_arrival_runtime_filter to use reference parameters instead of pointers and changed parameter order
• Added mutex protection for _conjuncts access in ScanLocalStateBase with new methods update_late_arrival_runtime_filter and clone_conjunct_ctxs
• Removed the _discard_conjuncts helper method and simplified conjunct lifecycle management in scanners
• Made Scanner::is_open() a const method
• Updated all call sites to use the new API signatures

Reviewed changes

Copilot reviewed 66 out of 66 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
be/test/runtime_filter/runtime_filter_consumer_helper_test.cpp	Updated test to use new API signature with reference parameters and reordered arguments
be/src/vec/exec/scan/scanner.h	Made is_open() const and removed _discard_conjuncts() helper method
be/src/vec/exec/scan/scanner.cpp	Refactored runtime filter logic to use new ScanLocalStateBase methods for thread safety
be/src/vec/exec/scan/file_scanner.cpp	Simplified conjunct handling by directly assigning vectors instead of cloning
be/src/runtime_filter/runtime_filter_consumer_helper.h	Changed interface to use references and removed clone_conjunct_ctxs method
be/src/runtime_filter/runtime_filter_consumer_helper.cpp	Updated implementation to match new interface and removed cloning method
be/src/pipeline/exec/scan_operator.h	Added mutex and new methods for thread-safe runtime filter updates
be/src/pipeline/exec/scan_operator.cpp	Implemented new thread-safe methods with proper locking
be/src/pipeline/exec/multi_cast_data_stream_source.cpp	Updated to use new API signature with appropriate comment about single-threaded execution

Comments suppressed due to low confidence (1)

be/src/vec/exec/scan/scanner.cpp:210

• The critical assignment _applied_rf_num = arrived_rf_num; is missing after cloning the conjuncts. This was present in the original code but was accidentally removed during refactoring. Without this update, the scanner will keep trying to append late-arrival runtime filters on every call even though they have already been applied, causing unnecessary work and incorrect behavior. The _applied_rf_num field needs to be updated to arrived_rf_num after successfully cloning the conjuncts to track which runtime filters have been applied.

Status Scanner::close(RuntimeState* state) {

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.