[fix](tablet) fix stale_version_count() returning wrong value #60070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stale_version_count() was incorrectly returning _rs_metas.size() instead of _stale_rs_metas.size(), causing incorrect calculation of total version count in places like rowset_builder.cpp and push_handler.cpp where it's used as: version_count() + stale_version_count() This was effectively calculating version_count * 2 instead of the intended total of active + stale versions.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Member
|
run buildall |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
liutang123
approved these changes
Jan 20, 2026
TPC-H: Total hot run time: 31295 ms |
TPC-DS: Total hot run time: 172950 ms |
ClickBench: Total hot run time: 26.88 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Member
|
run nonConcurrent |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31526 ms |
TPC-DS: Total hot run time: 173144 ms |
ClickBench: Total hot run time: 26.79 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31179 ms |
TPC-DS: Total hot run time: 172901 ms |
ClickBench: Total hot run time: 26.61 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
TabletMeta::stale_version_count()was incorrectly returning_rs_metas.size()instead of_stale_rs_metas.size().Bug Analysis
// Before (wrong)
inline size_t TabletMeta::stale_version_count() const {
return _rs_metas.size(); // ❌ should be _stale_rs_metas
}
// After (correct)
inline size_t TabletMeta::stale_version_count() const {
return _stale_rs_metas.size(); // ✅
}
This was effectively calculating version_count * 2 instead of the intended total of active + stale versions.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)