Skip to content

Conversation

@github-actions
Copy link
Contributor

Cherry-picked from #59354

### What problem does this PR solve?

Not print stack when peer read meet err

```
W20251225 11:05:21.592509 399889 status.h:445] meet error status: [INTERNAL_ERROR]PStatus: read cache file error

        0#  doris::Status doris::Status::create<true>(doris::PStatus const&) at /var/local/ldb-toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/basic_string.h:187
        1#  doris::io::PeerFileCacheReader::fetch_blocks(std::vector<std::shared_ptr<doris::io::FileBlock>, std::allocator<std::shared_ptr<doris::io::FileBlock> > > const&, unsigned long, doris::Slice, unsigned long*, unsigned long, doris::io::IOContext const*) at /mnt/disk3/pipeline/repo/selectdb-core_branch-hotfix-selectdb-doris-3.1-c/selectdb-core/be/src/io/cache/peer_file_cache
_reader.cpp:0
        2#  doris::io::(anonymous namespace)::execute_peer_read(std::vector<std::shared_ptr<doris::io::FileBlock>, std::allocator<std::shared_ptr<doris::io::FileBlock> > > const&, unsigned long, unsigned long&, std::unique_ptr<char [], std::default_delete<char []> >&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned long, bool, doris::io::ReadStatistics&, doris::io::IOContext const*) at /mnt/disk3/pipeline/repo/selectdb-core_branch-hotfix-selectdb-doris-3.1-c/selectdb-core/be/src/common/status.h:506
        3#  doris::io::CachedRemoteFileReader::_execute_remote_read(std::vector<std::shared_ptr<doris::io::FileBlock>, std::allocator<std::shared_ptr<doris::io::FileBlock> > > const&, unsigned long, unsigned long&, std::unique_ptr<char [], std::default_delete<char []> >&, doris::io::ReadStatistics&, doris::io::IOContext const*) at /mnt/disk3/pipeline/repo/selectdb-core_branch-hotfix-selectdb-doris-3.1-c/selectdb-core/be/src/io/cache/cached_remote_file_reader.cpp:270
        4#  doris::io::CachedRemoteFileReader::read_at_impl(unsigned long, doris::Slice, unsigned long*, doris::io::IOContext const*) at /mnt/disk3/pipeline/repo/selectdb-core_branch-hotfix-selectdb-doris-3.1-c/selectdb-core/be/src/common/status.h:506
        5#  doris::io::FileReader::read_at(unsigned long, doris::Slice, unsigned long*, doris::io::IOContext const*) at /mnt/disk3/pipeline/repo/selectdb-core_branch-hotfix-selectdb-doris-3.1-c/selectdb-core/be/src/common/status.h:506
        6#  doris::segment_v2::PageIO::read_and_decompress_page_(doris::segment_v2::PageReadOptions const&, doris::segment_v2::PageHandle*, doris::Slice*, doris::segment_v2::PageFooterPB*) at /mnt/disk3/pipeline/repo/selectdb-core_branch-hotfix-selectdb-doris-3.1-c/selectdb-core/be/src/common/status.h:506
        7#  doris::segment_v2::PageIO::do_read_and_decompress_page(doris::segment_v2::PageReadOptions const&, doris::segment_v2::PageHandle*, doris::Slice*, doris::segment_v2::PageFooterPB*) at /mnt/disk3/pipeline/repo/selectdb-core_branch-hotfix-selectdb-doris-3.1-c/selectdb-core/be/src/olap/rowset/segment_v2/page_io.h:157
        8#  doris::segment_v2::PageIO::read_and_decompress_page(doris::segment_v2::PageReadOptions const&, doris::segment_v2::PageHandle*, doris::Slice*, doris::segment_v2::PageFooterPB*) at /mnt/disk3/pipeline/repo/selectdb-core_branch-hotfix-selectdb-doris-3.1-c/selectdb-core/be/src/common/status.h:501
        9#  doris::segment_v2::FileColumnIterator::_read_data_page(doris::segment_v2::OrdinalPageIndexIterator const&) at /mnt/disk3/pipeline/repo/selectdb-core_branch-hotfix-selectdb-doris-3.1-c/selectdb-core/be/src/olap/rowset/segment_v2/column_reader.cpp:0
        10# doris::segment_v2::FileColumnIterator::_load_next_page(bool*) at /mnt/disk3/pipeline/repo/selectdb-core_branch-hotfix-selectdb-doris-3.1-c/selectdb-core/be/src/common/status.h:506
        11# doris::segment_v2::FileColumnIterator::next_batch(unsigned long*, COW<doris::vectorized::IColumn>::mutable_ptr<doris::vectorized::IColumn>&, bool*) at /mnt/disk3/pipeline/repo/selectdb-core_branch-hotfix-selectdb-doris-3.1-c/selectdb-core/be/src/common/status.h:506
        12# doris::segment_v2::SegmentIterator::_read_columns_by_index(unsigned int, unsigned int&, bool) at /mnt/disk3/pipeline/repo/selectdb-core_branch-hotfix-selectdb-doris-3.1-c/selectdb-core/be/src/common/status.h:506
        13# doris::segment_v2::SegmentIterator::_next_batch_internal(doris::vectorized::Block*) at /mnt/disk3/pipeline/repo/selectdb-core_branch-hotfix-selectdb-doris-3.1-c/selectdb-core/be/src/common/status.h:506
        14# doris::segment_v2::SegmentIterator::next_batch(doris::vectorized::Block*) at /mnt/disk3/pipeline/repo/selectdb-core_branch-hotfix-selectdb-doris-3.1-c/selectdb-core/be/src/common/status.h:506
        15# doris::vectorized::VerticalMergeIteratorContext::_load_next_block() at /mnt/disk3/pipeline/repo/selectdb-core_branch-hotfix-selectdb-doris-3.1-c/selectdb-core/be/src/common/status.h:506
        16# doris::vectorized::VerticalHeapMergeIterator::next_batch(doris::vectorized::Block*) at /mnt/disk3/pipeline/repo/selectdb-core_branch-hotfix-selectdb-doris-3.1-c/selectdb-core/be/src/common/status.h:506
        17# doris::vectorized::VerticalBlockReader::_direct_next_block(doris::vectorized::Block*, bool*) at /mnt/disk3/pipeline/repo/selectdb-core_branch-hotfix-selectdb-doris-3.1-c/selectdb-core/be/src/common/status.h:506
        18# doris::vectorized::VerticalBlockReader::next_block_with_aggregation(doris::vectorized::Block*, bool*) at /var/local/ldb-toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/basic_string.h:907
        19# doris::Merger::vertical_compact_one_group(std::shared_ptr<doris::BaseTablet>, doris::ReaderType, doris::TabletSchema const&, bool, std::vector<unsigned int, std::allocator<unsigned int> > const&, doris::vectorized::RowSourcesBuffer*, std::vector<std::shared_ptr<doris::RowsetReader>, std::allocator<std::shared_ptr<doris::RowsetReader> > > const&, doris::RowsetWriter*, long, doris::Merger::Statistics*, std::vector<unsigned int, std::allocator<unsigned int> >, long, doris::CompactionSampleInfo*) at /mnt/disk3/pipeline/repo/selectdb-core_branch-hotfix-selectdb-doris-3.1-c/selectdb-core/be/src/olap/merger.cpp:0
        20# doris::Merger::vertical_merge_rowsets(std::shared_ptr<doris::BaseTablet>, doris::ReaderType, doris::TabletSchema const&, std::vector<std::shared_ptr<doris::RowsetReader>, std::allocator<std::shared_ptr<doris::RowsetReader> > > const&, doris::RowsetWriter*, long, long, doris::Merger::Statistics*) at /mnt/disk3/pipeline/repo/selectdb-core_branch-hotfix-selectdb-doris-3.1-c/selectdb-core/be/src/olap/merger.cpp:481
        21# doris::Compaction::merge_input_rowsets() at /mnt/disk3/pipeline/repo/selectdb-core_branch-hotfix-selectdb-doris-3.1-c/selectdb-core/be/src/olap/compaction.cpp:204
        22# doris::CloudCompactionMixin::execute_compact_impl(long) at /mnt/disk3/pipeline/repo/selectdb-core_branch-hotfix-selectdb-doris-3.1-c/selectdb-core/be/src/common/status.h:506
        23# doris::CloudCompactionMixin::execute_compact() at /mnt/disk3/pipeline/repo/selectdb-core_branch-hotfix-selectdb-doris-3.1-c/selectdb-core/be/src/common/status.h:506
        24# doris::CloudBaseCompaction::execute_compact() at /mnt/disk3/pipeline/repo/selectdb-core_branch-hotfix-selectdb-doris-3.1-c/selectdb-core/be/src/common/status.h:392
        25# std::_Function_handler<void (), doris::CloudStorageEngine::_submit_base_compaction_task(std::shared_ptr<doris::CloudTablet> const&)::$_0>::_M_invoke(std::_Any_data const&) at /mnt/disk3/pipeline/repo/selectdb-core_branch-hotfix-selectdb-doris-3.1-c/selectdb-core/be/src/common/status.h:392
        26# doris::ThreadPool::dispatch_thread() at /var/local/ldb-toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/shared_ptr_base.h:730
        27# doris::Thread::supervise_thread(void*) at /var/local/ldb-toolchain/bin/../usr/include/pthread.h:562
        28# ?
        29# ?
```
@github-actions github-actions bot requested a review from yiguolei as a code owner January 27, 2026 07:19
@Thearas
Copy link
Contributor

Thearas commented Jan 27, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Jan 27, 2026
@Thearas
Copy link
Contributor

Thearas commented Jan 27, 2026

run buildall

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/10) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.72% (18900/35850)
Line Coverage 35.84% (175538/489808)
Region Coverage 32.46% (135807/418417)
Branch Coverage 33.33% (58866/176599)

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 28, 2026
@github-actions
Copy link
Contributor Author

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor Author

PR approved by anyone and no changes requested.

@yiguolei
Copy link
Contributor

skip buildall

@yiguolei yiguolei merged commit 9475aa7 into branch-4.0 Jan 28, 2026
27 of 29 checks passed
@github-actions github-actions bot deleted the auto-pick-59354-branch-4.0 branch January 28, 2026 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants