Skip to content

Conversation

@englefly
Copy link
Contributor

What problem does this PR solve?

当in predicate 里同时包含常量和列时,计算出错
Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@englefly
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32016 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 26b73f37f3ea393c78966a1702b2ee25aeb11c61, data reload: false

------ Round 1 ----------------------------------
q1	17624	5246	5104	5104
q2	2004	315	223	223
q3	10197	1328	752	752
q4	10241	821	310	310
q5	8071	2180	1878	1878
q6	242	182	148	148
q7	902	769	601	601
q8	9271	1363	1067	1067
q9	5369	4918	4931	4918
q10	6860	1959	1571	1571
q11	496	301	274	274
q12	391	375	216	216
q13	17769	4083	3271	3271
q14	233	230	227	227
q15	897	813	819	813
q16	671	710	631	631
q17	641	781	518	518
q18	6769	6500	6696	6500
q19	2985	1090	603	603
q20	570	344	227	227
q21	2655	2002	1887	1887
q22	357	322	277	277
Total cold run time: 105215 ms
Total hot run time: 32016 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5546	5303	5327	5303
q2	333	344	258	258
q3	2169	2652	2283	2283
q4	1356	1780	1332	1332
q5	4216	4110	4158	4110
q6	234	186	138	138
q7	1949	1834	1726	1726
q8	2484	2292	2278	2278
q9	7011	6940	6963	6940
q10	2621	2804	2453	2453
q11	546	488	444	444
q12	630	709	569	569
q13	3524	4052	3267	3267
q14	294	303	271	271
q15	842	796	833	796
q16	653	685	660	660
q17	1089	1257	1329	1257
q18	7540	7380	7366	7366
q19	826	815	801	801
q20	2019	2047	1873	1873
q21	4470	4346	4120	4120
q22	599	565	521	521
Total cold run time: 50951 ms
Total hot run time: 48766 ms

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

ClickBench: Total hot run time: 28.26 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 26b73f37f3ea393c78966a1702b2ee25aeb11c61, data reload: false

query1	0.06	0.05	0.05
query2	0.10	0.05	0.05
query3	0.26	0.08	0.09
query4	1.60	0.12	0.11
query5	0.26	0.25	0.24
query6	1.16	0.67	0.68
query7	0.04	0.02	0.02
query8	0.05	0.04	0.04
query9	0.56	0.50	0.49
query10	0.55	0.53	0.56
query11	0.14	0.10	0.10
query12	0.14	0.10	0.10
query13	0.62	0.61	0.62
query14	1.06	1.04	1.07
query15	0.88	0.86	0.86
query16	0.39	0.40	0.39
query17	1.17	1.16	1.15
query18	0.22	0.21	0.20
query19	2.01	1.99	2.01
query20	0.02	0.02	0.02
query21	15.40	0.26	0.14
query22	4.99	0.06	0.05
query23	16.06	0.29	0.10
query24	0.96	0.24	0.18
query25	0.08	0.12	0.08
query26	0.15	0.13	0.13
query27	0.09	0.06	0.07
query28	3.33	1.15	1.00
query29	12.56	3.95	3.17
query30	0.27	0.14	0.12
query31	2.80	0.64	0.41
query32	3.24	0.59	0.49
query33	3.19	3.27	3.23
query34	16.22	5.39	4.73
query35	4.81	4.78	4.74
query36	0.66	0.50	0.49
query37	0.11	0.07	0.07
query38	0.07	0.04	0.04
query39	0.05	0.04	0.04
query40	0.18	0.17	0.15
query41	0.09	0.04	0.03
query42	0.05	0.03	0.03
query43	0.05	0.04	0.04
Total cold run time: 96.7 s
Total hot run time: 28.26 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 0.00% (0/2) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.72% (19255/36526)
Line Coverage 36.09% (178874/495664)
Region Coverage 32.56% (138827/426351)
Branch Coverage 33.48% (60041/179341)

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 28, 2026
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (2/2) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 69.92% (25033/35804)
Line Coverage 52.39% (259017/494431)
Region Coverage 49.97% (215205/430669)
Branch Coverage 51.21% (92205/180057)

@yiguolei yiguolei merged commit e3f901e into apache:master Jan 28, 2026
31 of 32 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 28, 2026
…ins both SlotRef and Constant (#60302)

### What problem does this PR solve?
当in predicate 里同时包含常量和列时,计算出错
Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
yiguolei pushed a commit that referenced this pull request Jan 28, 2026
…dicate contains both SlotRef and Constant #60302 (#60316)

Cherry-picked from #60302

Co-authored-by: minghong <zhouminghong@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.3-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants