Skip to content

[minor](field) Refine Field#60481

Merged
Gabriel39 merged 2 commits intoapache:masterfrom
Gabriel39:minor_0204
Feb 4, 2026
Merged

[minor](field) Refine Field#60481
Gabriel39 merged 2 commits intoapache:masterfrom
Gabriel39:minor_0204

Conversation

@Gabriel39
Copy link
Contributor

@Gabriel39 Gabriel39 commented Feb 4, 2026 •
edited
Loading

What problem does this PR solve?

Move functions implements to the corresponding CPP file so we can print the type name in logs.

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Feb 4, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Gabriel39
Copy link
Contributor Author

Gabriel39 commented Feb 4, 2026

run buildall

@Gabriel39
Copy link
Contributor Author

Gabriel39 commented Feb 4, 2026

run buildall

@doris-robot
Copy link

doris-robot commented Feb 4, 2026

TPC-H: Total hot run time: 31965 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 69879d4e0cdb5bf476511cdc767425c4f1399c88, data reload: false

------ Round 1 ----------------------------------
q1	17687	5289	5052	5052
q2	2074	312	192	192
q3	10308	1300	725	725
q4	10214	893	319	319
q5	7526	2130	1903	1903
q6	195	180	150	150
q7	911	727	595	595
q8	9264	1379	1068	1068
q9	5216	4850	4952	4850
q10	6817	1939	1553	1553
q11	531	281	277	277
q12	329	368	216	216
q13	17790	4023	3189	3189
q14	227	236	214	214
q15	889	832	811	811
q16	676	667	625	625
q17	629	775	515	515
q18	6752	6597	7513	6597
q19	1085	1017	640	640
q20	415	367	236	236
q21	2838	2219	1939	1939
q22	360	338	299	299
Total cold run time: 102733 ms
Total hot run time: 31965 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5489	5553	5625	5553
q2	271	339	279	279
q3	2358	2859	2567	2567
q4	1489	1817	1446	1446
q5	4635	4630	4431	4431
q6	222	179	144	144
q7	2091	1906	1710	1710
q8	2573	2398	2531	2398
q9	7579	7614	7518	7518
q10	2812	2913	2399	2399
q11	508	451	436	436
q12	639	689	557	557
q13	3519	3957	3210	3210
q14	274	283	261	261
q15	830	794	798	794
q16	639	694	644	644
q17	1069	1191	1257	1191
q18	7482	7443	7245	7245
q19	797	769	761	761
q20	1937	2044	1885	1885
q21	4535	4236	4175	4175
q22	594	538	509	509
Total cold run time: 52342 ms
Total hot run time: 50113 ms

@doris-robot
Copy link

doris-robot commented Feb 4, 2026

ClickBench: Total hot run time: 28.15 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 69879d4e0cdb5bf476511cdc767425c4f1399c88, data reload: false

query1	0.05	0.05	0.05
query2	0.09	0.04	0.04
query3	0.25	0.08	0.08
query4	1.61	0.11	0.10
query5	0.28	0.27	0.25
query6	1.16	0.69	0.68
query7	0.03	0.02	0.02
query8	0.06	0.04	0.04
query9	0.57	0.50	0.49
query10	0.55	0.55	0.56
query11	0.14	0.10	0.09
query12	0.14	0.10	0.10
query13	0.63	0.62	0.62
query14	1.06	1.08	1.05
query15	0.87	0.86	0.86
query16	0.39	0.41	0.37
query17	1.14	1.16	1.12
query18	0.22	0.20	0.21
query19	2.02	1.95	2.10
query20	0.03	0.02	0.01
query21	15.44	0.25	0.14
query22	5.46	0.05	0.05
query23	15.98	0.29	0.10
query24	2.14	1.16	0.34
query25	0.06	0.06	0.08
query26	0.14	0.15	0.13
query27	0.05	0.05	0.06
query28	4.43	1.16	0.96
query29	12.55	3.86	3.13
query30	0.28	0.13	0.11
query31	2.81	0.65	0.41
query32	3.24	0.59	0.48
query33	3.19	3.30	3.24
query34	16.22	5.37	4.69
query35	4.81	4.72	4.80
query36	0.66	0.50	0.48
query37	0.11	0.07	0.07
query38	0.07	0.05	0.04
query39	0.04	0.03	0.03
query40	0.19	0.16	0.15
query41	0.09	0.04	0.03
query42	0.05	0.03	0.03
query43	0.05	0.04	0.04
Total cold run time: 99.35 s
Total hot run time: 28.15 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Feb 4, 2026

BE UT Coverage Report

Increment line coverage 85.00% (17/20) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.62% (19386/36840)
Line Coverage 36.08% (180091/499126)
Region Coverage 32.45% (139653/430373)
Branch Coverage 33.45% (60469/180795)

@hello-stephen
Copy link
Contributor

hello-stephen commented Feb 4, 2026

BE Regression && UT Coverage Report

Increment line coverage 100.00% (20/20) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.61% (25853/36104)
Line Coverage 54.21% (269927/497928)
Region Coverage 51.79% (225191/434787)
Branch Coverage 53.19% (96546/181523)

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 4, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

hello-stephen commented Feb 4, 2026

BE Regression && UT Coverage Report

Increment line coverage 100.00% (20/20) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.61% (25853/36104)
Line Coverage 54.21% (269927/497928)
Region Coverage 51.79% (225191/434787)
Branch Coverage 53.19% (96546/181523)

@Gabriel39 Gabriel39 merged commit 76f6775 into apache:master Feb 4, 2026
28 of 31 checks passed
Gabriel39 added a commit to Gabriel39/incubator-doris that referenced this pull request Feb 6, 2026
@Gabriel39
[minor](field) Refine Field (apache#60481)
112d2d6 
Move functions implements to the corresponding CPP file so we can print
the type name in logs.
@Gabriel39 Gabriel39 mentioned this pull request Feb 6, 2026
Merged
16 tasks
yiguolei pushed a commit that referenced this pull request Feb 7, 2026
@Gabriel39
[branch-4.0](pick) pick PR (#60566)
a0b0042 
### What problem does this PR solve?

Pick #60253 #60393 #60481 #56956 #60334 #60494

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhangstar333 zhangstar333 zhangstar333 approved these changes

+1 more reviewer

@Mryange Mryange Mryange approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.4-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Gabriel39 @Thearas @doris-robot @hello-stephen @Mryange @zhangstar333 @yiguolei