Skip to content

Conversation

@gary-cloud
Copy link
Contributor

@gary-cloud gary-cloud commented Feb 9, 2026

What problem does this PR solve?

  1. Set enable_variant_schema_auto_cast to true by default.
  2. Improve the implementation and expand test coverage for auto-cast (see PR [feature](variant) schema template auto cast #60362).
  3. Add support for multi-cast scenarios when validating match expressions.
  4. Update test_predefine_typed_to_sparse to explicitly set enable_variant_schema_auto_cast = false.

Issue Number: close #xxx

Related PR: #60362

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Feb 9, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@gary-cloud
Copy link
Contributor Author

run buildall

1 similar comment
@gary-cloud
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 30228 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 929172a48577294d61cd3c99769efad13e9a1584, data reload: false

------ Round 1 ----------------------------------
q1	17640	4484	4277	4277
q2	2011	340	232	232
q3	10180	1278	699	699
q4	10190	776	314	314
q5	7497	2131	1950	1950
q6	196	182	150	150
q7	906	721	621	621
q8	9276	1422	1104	1104
q9	4702	4609	4583	4583
q10	6823	1928	1526	1526
q11	521	303	294	294
q12	341	371	216	216
q13	17813	4000	3231	3231
q14	234	240	215	215
q15	888	814	802	802
q16	664	664	623	623
q17	702	830	505	505
q18	6553	5880	5844	5844
q19	1397	983	604	604
q20	509	491	381	381
q21	2516	1830	1792	1792
q22	353	313	265	265
Total cold run time: 101912 ms
Total hot run time: 30228 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4361	4320	4304	4304
q2	259	351	258	258
q3	2068	2652	2238	2238
q4	1340	1704	1241	1241
q5	4252	4237	4310	4237
q6	215	176	135	135
q7	1860	1790	1662	1662
q8	2434	2694	2456	2456
q9	7654	7499	7535	7499
q10	2758	3039	2655	2655
q11	556	474	444	444
q12	703	761	631	631
q13	3820	4475	3469	3469
q14	298	431	294	294
q15	875	812	812	812
q16	688	726	704	704
q17	1193	1334	1354	1334
q18	8234	7822	8033	7822
q19	892	837	852	837
q20	2200	2160	2042	2042
q21	4720	4505	4169	4169
q22	580	553	490	490
Total cold run time: 51960 ms
Total hot run time: 49733 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.31 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 929172a48577294d61cd3c99769efad13e9a1584, data reload: false

query1	0.05	0.05	0.05
query2	0.09	0.04	0.04
query3	0.25	0.10	0.08
query4	1.60	0.11	0.12
query5	0.28	0.26	0.26
query6	1.18	0.67	0.67
query7	0.04	0.02	0.03
query8	0.05	0.03	0.04
query9	0.56	0.51	0.49
query10	0.55	0.55	0.54
query11	0.14	0.09	0.09
query12	0.14	0.10	0.10
query13	0.64	0.61	0.62
query14	1.07	1.05	1.05
query15	0.88	0.86	0.88
query16	0.40	0.39	0.38
query17	1.08	1.12	1.14
query18	0.22	0.21	0.21
query19	2.11	2.00	2.02
query20	0.02	0.01	0.01
query21	15.39	0.25	0.14
query22	5.03	0.05	0.06
query23	15.78	0.28	0.10
query24	1.18	0.26	0.66
query25	0.11	0.12	0.09
query26	0.15	0.15	0.13
query27	0.07	0.09	0.06
query28	4.32	1.14	0.96
query29	12.54	3.90	3.16
query30	0.27	0.14	0.13
query31	2.82	0.64	0.41
query32	3.25	0.59	0.49
query33	3.32	3.23	3.21
query34	16.28	5.46	4.71
query35	4.73	4.82	4.81
query36	0.65	0.49	0.49
query37	0.11	0.06	0.06
query38	0.08	0.04	0.04
query39	0.04	0.03	0.03
query40	0.20	0.17	0.16
query41	0.09	0.04	0.03
query42	0.04	0.03	0.03
query43	0.04	0.04	0.04
Total cold run time: 97.84 s
Total hot run time: 28.31 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.71% (19441/36882)
Line Coverage 36.19% (180904/499901)
Region Coverage 32.54% (140319/431169)
Branch Coverage 33.60% (60827/181049)

@gary-cloud
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 29989 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 799b8dde08f97b225e48e88c30a558e7e08dbfe7, data reload: false

------ Round 1 ----------------------------------
q1	17626	4568	4294	4294
q2	2031	366	260	260
q3	10127	1277	715	715
q4	10196	780	304	304
q5	7550	2195	1907	1907
q6	193	174	144	144
q7	876	729	592	592
q8	9248	1411	1078	1078
q9	4702	4623	4572	4572
q10	6831	1942	1537	1537
q11	520	306	285	285
q12	339	369	218	218
q13	17770	4041	3221	3221
q14	224	234	217	217
q15	895	823	788	788
q16	680	663	620	620
q17	696	857	488	488
q18	6635	5900	5687	5687
q19	1242	1030	625	625
q20	511	492	373	373
q21	2570	1866	1779	1779
q22	362	317	285	285
Total cold run time: 101824 ms
Total hot run time: 29989 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4403	4383	4317	4317
q2	276	346	260	260
q3	2130	2706	2260	2260
q4	1379	1779	1301	1301
q5	4360	4267	4248	4248
q6	220	182	138	138
q7	1867	1915	1770	1770
q8	2498	2817	2522	2522
q9	7711	7431	7642	7431
q10	2866	2925	2683	2683
q11	554	483	458	458
q12	691	743	639	639
q13	3952	4345	3672	3672
q14	318	314	291	291
q15	874	786	803	786
q16	660	768	693	693
q17	1132	1345	1364	1345
q18	8061	7895	7968	7895
q19	861	833	841	833
q20	2072	2148	1992	1992
q21	4997	4157	4152	4152
q22	544	551	497	497
Total cold run time: 52426 ms
Total hot run time: 50183 ms

@gary-cloud
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 30589 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4220e19c29eefebc0f27a3cd77083fbeb6bef22d, data reload: false

------ Round 1 ----------------------------------
q1	17624	4469	4317	4317
q2	2010	367	277	277
q3	10118	1282	742	742
q4	10201	781	327	327
q5	7545	2215	1957	1957
q6	200	187	152	152
q7	918	778	605	605
q8	9265	1444	1192	1192
q9	4723	4689	4601	4601
q10	6883	1929	1570	1570
q11	525	306	287	287
q12	341	379	230	230
q13	17778	4095	3250	3250
q14	249	237	213	213
q15	904	812	803	803
q16	682	660	616	616
q17	699	837	554	554
q18	6567	5847	5746	5746
q19	1223	990	631	631
q20	529	495	402	402
q21	2631	1861	1833	1833
q22	360	326	284	284
Total cold run time: 101975 ms
Total hot run time: 30589 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4396	4371	4395	4371
q2	264	344	248	248
q3	2198	2793	2318	2318
q4	1453	1828	1353	1353
q5	4509	4526	4609	4526
q6	202	175	142	142
q7	1871	1741	1646	1646
q8	2827	2629	2514	2514
q9	7705	7510	7456	7456
q10	2738	3055	2746	2746
q11	558	478	485	478
q12	697	751	598	598
q13	4010	4379	3655	3655
q14	296	309	286	286
q15	871	793	795	793
q16	668	750	861	750
q17	1144	1346	1380	1346
q18	8341	7798	7908	7798
q19	1005	901	942	901
q20	2214	2185	1990	1990
q21	4854	4313	4094	4094
q22	568	527	509	509
Total cold run time: 53389 ms
Total hot run time: 50518 ms

@gary-cloud
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 30360 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 07f1ba43efc6e00fd5599f55d8b5099abeca663f, data reload: false

------ Round 1 ----------------------------------
q1	17613	4431	4287	4287
q2	2017	348	262	262
q3	10142	1345	755	755
q4	10194	790	313	313
q5	7511	2184	1960	1960
q6	194	179	146	146
q7	907	738	603	603
q8	9288	1398	1183	1183
q9	4750	4709	4642	4642
q10	6833	1944	1511	1511
q11	520	292	278	278
q12	341	366	218	218
q13	17778	4104	3222	3222
q14	241	240	214	214
q15	872	813	798	798
q16	688	713	616	616
q17	703	847	496	496
q18	6543	6048	5781	5781
q19	1225	991	609	609
q20	509	494	377	377
q21	2586	1867	1804	1804
q22	361	322	285	285
Total cold run time: 101816 ms
Total hot run time: 30360 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4370	4345	4351	4345
q2	252	338	255	255
q3	2075	2768	2253	2253
q4	1363	1758	1322	1322
q5	4270	4220	4211	4211
q6	222	178	135	135
q7	1884	1777	1686	1686
q8	2486	2350	2300	2300
q9	7030	7010	7002	7002
q10	2675	2821	2424	2424
q11	535	479	453	453
q12	619	689	590	590
q13	3589	4089	3227	3227
q14	279	301	266	266
q15	839	814	798	798
q16	655	695	646	646
q17	1089	1290	1323	1290
q18	7530	7458	7440	7440
q19	829	840	811	811
q20	1949	2058	1887	1887
q21	4634	4233	4105	4105
q22	577	565	515	515
Total cold run time: 49751 ms
Total hot run time: 47961 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.53 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 07f1ba43efc6e00fd5599f55d8b5099abeca663f, data reload: false

query1	0.06	0.05	0.04
query2	0.10	0.04	0.05
query3	0.25	0.08	0.08
query4	1.61	0.12	0.11
query5	0.27	0.24	0.24
query6	1.16	0.67	0.67
query7	0.04	0.02	0.02
query8	0.05	0.04	0.04
query9	0.57	0.48	0.49
query10	0.54	0.56	0.54
query11	0.14	0.11	0.10
query12	0.14	0.10	0.10
query13	0.63	0.62	0.61
query14	1.05	1.05	1.06
query15	0.86	0.87	0.86
query16	0.39	0.41	0.41
query17	1.13	1.18	1.15
query18	0.23	0.21	0.22
query19	2.12	2.01	2.08
query20	0.02	0.02	0.01
query21	15.40	0.27	0.15
query22	5.08	0.06	0.05
query23	15.81	0.28	0.10
query24	0.90	0.68	0.52
query25	0.07	0.06	0.06
query26	0.15	0.14	0.14
query27	0.11	0.08	0.04
query28	4.35	1.16	0.96
query29	12.65	3.91	3.14
query30	0.28	0.14	0.13
query31	2.82	0.63	0.40
query32	3.24	0.60	0.49
query33	3.27	3.26	3.30
query34	16.04	5.42	4.70
query35	4.85	4.83	4.76
query36	0.66	0.50	0.49
query37	0.11	0.07	0.06
query38	0.07	0.05	0.04
query39	0.04	0.03	0.04
query40	0.20	0.17	0.15
query41	0.09	0.03	0.02
query42	0.05	0.03	0.03
query43	0.05	0.04	0.04
Total cold run time: 97.65 s
Total hot run time: 28.53 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.71% (19450/36897)
Line Coverage 36.20% (181077/500188)
Region Coverage 32.59% (140597/431456)
Branch Coverage 33.63% (60936/181215)

@gary-cloud
Copy link
Contributor Author

run cloud_p0

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 57.34% (20730/36152)
Line Coverage 40.30% (201094/498949)
Region Coverage 36.99% (161222/435836)
Branch Coverage 37.76% (68692/181919)

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 66.67% (6/9) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 57.34% (20730/36152)
Line Coverage 40.30% (201094/498949)
Region Coverage 36.99% (161222/435836)
Branch Coverage 37.76% (68692/181919)

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 66.67% (6/9) 🎉
Increment coverage report
Complete coverage report

Copy link
Contributor

@csun5285 csun5285 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 10, 2026
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@eldenmoon eldenmoon merged commit 1227bc7 into apache:master Feb 10, 2026
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/4.1.x reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants