Skip to content

Conversation

@zclllyybb
Copy link
Contributor

@zclllyybb zclllyybb commented Feb 10, 2026

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Dictionary refresh tasks build load command internally, which didn't set originSql of it. this may cause some usage fail because of dependency of not null originSql.

  1. Change construct method to fix null originSql of dictionary refresh tasks.
  2. add defensive check in checkBlockSql to avoid failure.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Feb 10, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zclllyybb
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 30042 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3ebfd9de0e7d191675f3e9cac25615210c087b54, data reload: false

------ Round 1 ----------------------------------
q1	17604	4544	4273	4273
q2	2051	366	236	236
q3	10134	1266	741	741
q4	10192	774	311	311
q5	7501	2149	1922	1922
q6	195	173	143	143
q7	852	720	595	595
q8	9268	1363	1170	1170
q9	4651	4590	4549	4549
q10	6814	1963	1544	1544
q11	517	309	288	288
q12	336	363	221	221
q13	17814	4019	3239	3239
q14	245	231	216	216
q15	878	807	803	803
q16	677	683	626	626
q17	698	867	468	468
q18	6355	5690	5696	5690
q19	1236	998	578	578
q20	496	493	373	373
q21	2501	1796	1774	1774
q22	360	314	282	282
Total cold run time: 101375 ms
Total hot run time: 30042 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4378	4328	4328	4328
q2	258	338	248	248
q3	2123	2635	2222	2222
q4	1347	1712	1271	1271
q5	4242	4231	4399	4231
q6	210	178	135	135
q7	1794	1801	1702	1702
q8	2482	2566	2525	2525
q9	7635	7544	7721	7544
q10	2966	3068	2666	2666
q11	582	490	464	464
q12	674	756	631	631
q13	3826	4421	3640	3640
q14	338	377	295	295
q15	876	830	794	794
q16	664	748	662	662
q17	1156	1313	1359	1313
q18	8182	7910	7894	7894
q19	977	839	850	839
q20	2122	2150	1975	1975
q21	4777	4460	4120	4120
q22	570	537	493	493
Total cold run time: 52179 ms
Total hot run time: 49992 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.3 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3ebfd9de0e7d191675f3e9cac25615210c087b54, data reload: false

query1	0.05	0.04	0.05
query2	0.10	0.05	0.05
query3	0.26	0.09	0.08
query4	1.61	0.12	0.11
query5	0.29	0.26	0.24
query6	1.16	0.67	0.68
query7	0.03	0.03	0.02
query8	0.06	0.05	0.04
query9	0.57	0.49	0.50
query10	0.55	0.53	0.55
query11	0.14	0.09	0.10
query12	0.14	0.11	0.11
query13	0.63	0.62	0.61
query14	1.07	1.05	1.04
query15	0.88	0.87	0.89
query16	0.40	0.39	0.40
query17	1.15	1.13	1.17
query18	0.23	0.21	0.21
query19	2.02	2.04	1.98
query20	0.02	0.01	0.02
query21	15.42	0.25	0.15
query22	5.30	0.05	0.05
query23	15.89	0.30	0.12
query24	1.69	0.60	0.32
query25	0.09	0.06	0.06
query26	0.13	0.13	0.15
query27	0.06	0.06	0.05
query28	3.68	1.16	0.97
query29	12.58	3.96	3.16
query30	0.27	0.13	0.12
query31	2.80	0.64	0.40
query32	3.24	0.61	0.50
query33	3.25	3.25	3.26
query34	16.08	5.36	4.71
query35	4.78	4.74	4.73
query36	0.65	0.49	0.49
query37	0.11	0.07	0.07
query38	0.07	0.05	0.03
query39	0.05	0.03	0.04
query40	0.19	0.16	0.16
query41	0.09	0.04	0.03
query42	0.04	0.03	0.02
query43	0.04	0.04	0.04
Total cold run time: 97.86 s
Total hot run time: 28.3 s

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 71.43% (5/7) 🎉
Increment coverage report
Complete coverage report

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 10, 2026
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@zclllyybb zclllyybb merged commit 22a2d5a into apache:master Feb 10, 2026
32 of 33 checks passed
@zclllyybb zclllyybb deleted the dict_block_check branch February 10, 2026 07:20
github-actions bot pushed a commit that referenced this pull request Feb 10, 2026
…0631)

Dictionary refresh tasks build load command internally, which didn't set
`originSql` of it. this may cause some usage fail because of dependency
of not null `originSql`.

1. Change construct method to fix null `originSql` of dictionary refresh
tasks.
2. add defensive check in `checkBlockSql` to avoid failure.
yiguolei pushed a commit that referenced this pull request Feb 12, 2026
…riginSql #60631 (#60641)

Cherry-picked from #60631

Co-authored-by: zclllyybb <zhaochangle@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.4-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants