Skip to content

[Fix](regexp) make dot not match newline in REGEXP by default#60806

Closed
linrrzqqq wants to merge 1 commit intoapache:masterfrom
linrrzqqq:regexp-dot-nl
Closed

[Fix](regexp) make dot not match newline in REGEXP by default#60806
linrrzqqq wants to merge 1 commit intoapache:masterfrom
linrrzqqq:regexp-dot-nl

Conversation

@linrrzqqq
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@linrrzqqq linrrzqqq requested a review from zclllyybb as a code owner February 24, 2026 08:44
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@linrrzqqq
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 29036 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5b12f4a094028a2cf2cfbd41476234a60fb41ed4, data reload: false

------ Round 1 ----------------------------------
============================================
q1	17608	4472	4293	4293
q2	q3	10647	796	524	524
q4	4688	364	255	255
q5	7555	1208	1025	1025
q6	176	173	150	150
q7	778	846	664	664
q8	9477	1483	1384	1384
q9	4849	4722	4721	4721
q10	6862	1852	1645	1645
q11	472	262	246	246
q12	756	570	471	471
q13	17761	4238	3427	3427
q14	234	233	216	216
q15	937	798	807	798
q16	754	724	686	686
q17	720	913	437	437
q18	6060	5364	5156	5156
q19	1242	965	650	650
q20	520	508	393	393
q21	4828	1992	1636	1636
q22	402	321	259	259
Total cold run time: 97326 ms
Total hot run time: 29036 ms

----- Round 2, with runtime_filter_mode=off -----
============================================
q1	4624	4554	4529	4529
q2	q3	1784	2201	1821	1821
q4	875	1223	800	800
q5	4130	4365	4402	4365
q6	190	176	145	145
q7	1815	1687	1556	1556
q8	2471	2702	2593	2593
q9	7574	7621	7568	7568
q10	2786	2884	2405	2405
q11	526	436	422	422
q12	545	597	467	467
q13	4230	4400	3729	3729
q14	329	299	269	269
q15	869	792	817	792
q16	706	763	729	729
q17	1159	1599	1321	1321
q18	7160	6771	6957	6771
q19	954	944	906	906
q20	2086	2159	2012	2012
q21	4020	3493	3365	3365
q22	498	477	405	405
Total cold run time: 49331 ms
Total hot run time: 46970 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 184248 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5b12f4a094028a2cf2cfbd41476234a60fb41ed4, data reload: false

query5	4327	629	528	528
query6	340	229	211	211
query7	4215	469	273	273
query8	344	244	236	236
query9	8721	2766	2767	2766
query10	534	387	338	338
query11	16956	17383	17495	17383
query12	219	153	144	144
query13	1390	506	385	385
query14	7133	3391	3151	3151
query14_1	2919	3151	2966	2966
query15	219	217	196	196
query16	999	496	451	451
query17	1186	725	634	634
query18	2766	449	349	349
query19	214	206	178	178
query20	138	130	150	130
query21	223	137	117	117
query22	5969	5071	4926	4926
query23	17169	16763	16578	16578
query23_1	16607	16664	16665	16664
query24	7053	1622	1211	1211
query24_1	1201	1239	1220	1220
query25	587	466	391	391
query26	1243	254	144	144
query27	2779	469	305	305
query28	4478	1851	1861	1851
query29	792	564	465	465
query30	312	249	212	212
query31	906	744	649	649
query32	83	69	77	69
query33	530	338	294	294
query34	913	928	546	546
query35	642	677	617	617
query36	1085	1099	939	939
query37	141	96	83	83
query38	3018	2932	2935	2932
query39	895	863	843	843
query39_1	829	820	824	820
query40	229	154	137	137
query41	63	60	57	57
query42	113	103	105	103
query43	384	382	355	355
query44	
query45	195	190	184	184
query46	892	968	599	599
query47	2136	2111	2040	2040
query48	320	318	248	248
query49	624	473	389	389
query50	674	277	211	211
query51	4113	4090	4035	4035
query52	113	111	102	102
query53	290	348	290	290
query54	287	280	259	259
query55	92	85	81	81
query56	307	319	312	312
query57	1338	1322	1261	1261
query58	289	285	274	274
query59	2541	2672	2526	2526
query60	335	335	339	335
query61	152	142	150	142
query62	626	580	547	547
query63	327	277	278	277
query64	4851	1312	987	987
query65	
query66	1396	448	365	365
query67	16279	16466	16191	16191
query68	
query69	406	308	289	289
query70	1000	909	945	909
query71	347	308	303	303
query72	2923	2662	2492	2492
query73	551	552	328	328
query74	9983	9911	9761	9761
query75	2889	2789	2487	2487
query76	2321	1044	682	682
query77	392	396	323	323
query78	11180	11400	10731	10731
query79	1140	800	594	594
query80	1352	646	572	572
query81	547	285	265	265
query82	1333	150	116	116
query83	338	272	256	256
query84	261	118	106	106
query85	1031	584	520	520
query86	399	323	322	322
query87	3143	3115	2997	2997
query88	3572	2682	2663	2663
query89	436	371	351	351
query90	1914	179	176	176
query91	181	155	132	132
query92	78	74	72	72
query93	894	840	506	506
query94	568	313	297	297
query95	631	333	328	328
query96	642	518	231	231
query97	2461	2460	2400	2400
query98	225	215	218	215
query99	990	998	915	915
Total cold run time: 254522 ms
Total hot run time: 184248 ms

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 100.00% (2/2) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.55% (19578/37255)
Line Coverage 36.18% (182698/505012)
Region Coverage 32.49% (141653/436017)
Branch Coverage 33.46% (61424/183587)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (2/2) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.58% (26119/36488)
Line Coverage 54.32% (273484/503512)
Region Coverage 51.72% (227659/440185)
Branch Coverage 53.13% (97842/184173)

@zclllyybb zclllyybb self-assigned this Feb 24, 2026
@linrrzqqq linrrzqqq closed this Feb 24, 2026
@linrrzqqq linrrzqqq deleted the regexp-dot-nl branch February 25, 2026 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants