Skip to content

branch-4.0: [fix](stream-load) Fix LZ4 compressed stream load decompress made no progress error #60852#60980

Merged
yiguolei merged 1 commit intobranch-4.0from
auto-pick-60852-branch-4.0
Mar 3, 2026
Merged

branch-4.0: [fix](stream-load) Fix LZ4 compressed stream load decompress made no progress error #60852#60980
yiguolei merged 1 commit intobranch-4.0from
auto-pick-60852-branch-4.0

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Mar 3, 2026

Cherry-picked from #60852

…progress error (#60852)

Problem Summary:
When LZ4F_decompress produces output from its internal buffer (tmpOut)
without consuming new input, input_read_bytes is 0 but decompressed_len
is positive. The original condition only checked input_read_bytes == 0
and incorrectly treated this as "no progress", returning an error.

Add decompressed_len == 0 check to the condition so that real progress
(output produced from decompressor internal buffer) is not mistakenly
flagged as a stall.

Also add a debug point to shrink the output buffer for regression
testing, and a regression test that uses it to reproduce the bug
scenario.
@github-actions github-actions bot requested a review from yiguolei as a code owner March 3, 2026 09:16
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Mar 3, 2026
@dataroaring dataroaring reopened this Mar 3, 2026
@hello-stephen
Copy link
Contributor

run buildall

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/7) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.98% (19130/36107)
Line Coverage 36.17% (178117/492451)
Region Coverage 32.77% (138024/421174)
Branch Coverage 33.72% (59899/177628)

@yiguolei yiguolei merged commit 912ebd1 into branch-4.0 Mar 3, 2026
26 of 29 checks passed
@github-actions github-actions bot deleted the auto-pick-60852-branch-4.0 branch March 3, 2026 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants