branch-4.0: [fix](point-query) Fix point query ignoring session timezone for functions like from_unixtime #60913#60991
Merged
yiguolei merged 1 commit intobranch-4.0from Mar 3, 2026
Conversation
…tions like from_unixtime (#60913) Point queries on unique key tables with row store incorrectly used the default timezone (Asia/Shanghai) instead of the session timezone when evaluating timezone-sensitive functions like from_unixtime(). This was because PTabletKeyLookupRequest did not carry timezone information, and the RuntimeState created in Reusable::init() always used the default timezone. The fix adds a time_zone field to PTabletKeyLookupRequest, sets it from the session variable in FE PointQueryExecutor, and applies it to the RuntimeState in BE PointQueryExecutor::init(). Changes: - gensrc/proto: Add time_zone field to PTabletKeyLookupRequest - FE: Send session timezone in PointQueryExecutor.getNextInternal() - BE: Add RuntimeState::set_timezone() and use it in PointQueryExecutor::init() - Add regression test for point query timezone handling
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
Contributor
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
yiguolei
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #60913