Skip to content

branch-4.0: [fix](test) make hive compress split assertion BE-aware #60947#61008

Merged
yiguolei merged 1 commit intobranch-4.0from
auto-pick-60947-branch-4.0
Mar 5, 2026
Merged

branch-4.0: [fix](test) make hive compress split assertion BE-aware #60947#61008
yiguolei merged 1 commit intobranch-4.0from
auto-pick-60947-branch-4.0

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Mar 3, 2026

Cherry-picked from #60947

### What problem does this PR solve?

Problem Summary:
`external_table_p0/hive/test_hive_compress_type.groovy` had a fixed
split assertion (`28`) for multi-BE, which is not stable across
environments.
The split behavior for COUNT pushdown depends on both `backendNum` and
`parallel_fragment_exec_instance_num`, so internal 3BE pipeline could
still produce `16` and fail.

This PR makes the assertion BE-aware and deterministic:
- read `backendNum` via `show backends`
- read `parallel_fragment_exec_instance_num` via `show variables`
- compute expected split count with the same condition as FE logic
- add comments to explain why this check differs between environments
@github-actions github-actions bot requested a review from yiguolei as a code owner March 3, 2026 16:01
@Thearas
Copy link
Contributor

Thearas commented Mar 3, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Mar 3, 2026
@dataroaring dataroaring reopened this Mar 3, 2026
@Thearas
Copy link
Contributor

Thearas commented Mar 3, 2026

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 3, 2026
@github-actions
Copy link
Contributor Author

github-actions bot commented Mar 3, 2026

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor Author

github-actions bot commented Mar 3, 2026

PR approved by anyone and no changes requested.

@yiguolei
Copy link
Contributor

yiguolei commented Mar 5, 2026

skip buildall

@yiguolei yiguolei merged commit d96662c into branch-4.0 Mar 5, 2026
31 of 33 checks passed
@github-actions github-actions bot deleted the auto-pick-60947-branch-4.0 branch March 5, 2026 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants