[minor](variant) set variant_nested_group_discard_scalar_on_conflict default to false and refactor nested group interface#61065
Merged
eldenmoon merged 1 commit intoapache:masterfrom Mar 6, 2026
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Member
Author
|
run buildall |
There was a problem hiding this comment.
Pull request overview
Updates the BE configuration default for NestedGroup conflict handling in Variant columns, changing the default behavior when scalar data conflicts with NestedGroup array data.
Changes:
- Set
variant_nested_group_discard_scalar_on_conflictdefault fromtruetofalse.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TPC-H: Total hot run time: 27686 ms |
TPC-DS: Total hot run time: 153378 ms |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
eldenmoon
changed the title
variant_nested_group_discard_scalar_on_conflict default to falsevariant_nested_group_discard_scalar_on_conflict default to false and refactor nested group interface
eldenmoon
changed the title
variant_nested_group_discard_scalar_on_conflict default to false and refactor nested group interfacevariant_nested_group_discard_scalar_on_conflict default to false and refactor nested group interface
Member
Author
|
run buildall |
Member
Author
|
run buildall |
TPC-H: Total hot run time: 27893 ms |
TPC-DS: Total hot run time: 153271 ms |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Member
Author
|
skip check_coverage |
Contributor
|
PR approved by anyone and no changes requested. |
airborne12
approved these changes
Mar 6, 2026
Member
airborne12
left a comment
airborne12
left a comment
There was a problem hiding this comment.
LGTM. Clean minor refactor: safer default for variant_nested_group_discard_scalar_on_conflict (throw on conflict instead of silent discard), and init_readers interface extended with ColumnMetaAccessor for downstream use. All implementations and tests updated consistently.
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
mrhhsg
pushed a commit
that referenced
this pull request
Mar 6, 2026
…` default to false and refactor nested group interface (#61065)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.