[regression] split hive compress-type heavy scan into p2#61073
Open
xylaaaaa wants to merge 1 commit intoapache:masterfrom
Open
[regression] split hive compress-type heavy scan into p2#61073xylaaaaa wants to merge 1 commit intoapache:masterfrom
xylaaaaa wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
There was a problem hiding this comment.
Pull request overview
This PR moves the heavy Hive compression/scan-splitting regression coverage out of the external_table_p0 suite into a new external_table_p2 suite to reduce p0 runtime while keeping large-data validation.
Changes:
- Removed large
test_compress_partitionedscan/split assertions fromexternal_table_p0/hive/test_hive_compress_type.groovy. - Added
external_table_p2/hive/test_hive_compress_type_large_data.groovyto cover the large-datafile_split_sizebehaviors and row-count checks. - Kept lightweight parquet LZ4/LZO checks in the p0 suite.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| regression-test/suites/external_table_p2/hive/test_hive_compress_type_large_data.groovy | Adds a new p2 suite for large-data test_compress_partitioned split-count expectations and count validations (note: currently contains malformed Groovy triple-quote SQL strings on the dt="gzip" or dt="mix" queries, which will fail to parse). |
| regression-test/suites/external_table_p0/hive/test_hive_compress_type.groovy | Removes the heavy scan/split assertions so p0 retains only lightweight parquet compression checks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| suite("test_hive_compress_type_large_data", "p2,external") { | ||
| String enabled = context.config.otherConfigs.get("enableHiveTest") | ||
| if (enabled == null || !enabled.equalsIgnoreCase("true")) { | ||
| logger.info("diable Hive test.") |
There was a problem hiding this comment.
Log message has a typo: "diable Hive test." should be "disable Hive test." (or "disable Hive tests").
Suggested change
| logger.info("diable Hive test.") | |
| logger.info("disable Hive tests.") |
Contributor
Author
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_hive_compress_typeinexternal_table_p0by removing heavytest_compress_partitionedscanstest_hive_compress_type_large_datainexternal_table_p2to cover the moved large-data checksWhy
Details
file_split_size=0andfile_split_size=8388608and validates row counts/scan split expectationsTest