Skip to content

[Fix](mv) Fix ConcurrentModificationException in PartitionCompensator#61145

Open
sahildevgon wants to merge 1 commit intoapache:masterfrom
sahildevgon:fix_bug_ConcurrentModificationException_in_PartitionCompensator
Open

[Fix](mv) Fix ConcurrentModificationException in PartitionCompensator#61145
sahildevgon wants to merge 1 commit intoapache:masterfrom
sahildevgon:fix_bug_ConcurrentModificationException_in_PartitionCompensator

Conversation

@sahildevgon
Copy link

What problem does this PR solve?

This PR fixes the bug causing ConcurrentModificationException in PartitionCompensator.

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@sahildevgon sahildevgon marked this pull request as ready for review March 9, 2026 08:35
@sahildevgon
Copy link
Author

run buildall

@sahildevgon sahildevgon changed the title Fix ConcurrentModificationException bug fix in PartitionCompensator [Fix](mv) Fix ConcurrentModificationException in PartitionCompensator Mar 9, 2026
@doris-robot
Copy link

TPC-H: Total hot run time: 27631 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2ae4d283ed635820528bfe2d7fefa746cb91a8ec, data reload: false

------ Round 1 ----------------------------------
============================================
q1	17652	4545	4312	4312
q2	q3	10640	780	508	508
q4	4676	360	249	249
q5	7555	1193	1024	1024
q6	177	179	147	147
q7	774	849	652	652
q8	9309	1446	1286	1286
q9	4757	4666	4712	4666
q10	6263	1904	1634	1634
q11	468	252	232	232
q12	700	603	486	486
q13	18075	2929	2180	2180
q14	232	241	226	226
q15	936	803	806	803
q16	754	716	683	683
q17	750	874	390	390
q18	6048	5464	5325	5325
q19	1250	1011	614	614
q20	510	495	397	397
q21	4634	2110	1544	1544
q22	382	332	273	273
Total cold run time: 96542 ms
Total hot run time: 27631 ms

----- Round 2, with runtime_filter_mode=off -----
============================================
q1	4780	4620	4539	4539
q2	q3	3892	4330	3869	3869
q4	902	1211	759	759
q5	4102	4361	4366	4361
q6	178	179	139	139
q7	1770	1640	1568	1568
q8	2465	2757	2676	2676
q9	7661	7358	7388	7358
q10	3775	4205	3589	3589
q11	518	431	416	416
q12	492	598	453	453
q13	2696	3182	2390	2390
q14	281	299	282	282
q15	865	812	821	812
q16	715	763	686	686
q17	1154	1434	1338	1338
q18	7212	6889	6684	6684
q19	991	908	929	908
q20	2070	2151	1972	1972
q21	3978	3424	3407	3407
q22	460	432	382	382
Total cold run time: 50957 ms
Total hot run time: 48588 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 153205 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2ae4d283ed635820528bfe2d7fefa746cb91a8ec, data reload: false

query5	4326	646	529	529
query6	331	224	207	207
query7	4206	472	263	263
query8	349	240	227	227
query9	8724	2762	2749	2749
query10	476	384	326	326
query11	7344	5831	5582	5582
query12	184	134	128	128
query13	1276	453	352	352
query14	5704	3851	3614	3614
query14_1	2861	2837	2845	2837
query15	207	197	178	178
query16	1021	485	386	386
query17	1114	724	625	625
query18	2447	464	356	356
query19	212	216	180	180
query20	139	135	130	130
query21	229	150	131	131
query22	4921	5118	4851	4851
query23	15995	15536	15288	15288
query23_1	15493	16277	16008	16008
query24	7375	1680	1322	1322
query24_1	1336	1273	1313	1273
query25	608	544	458	458
query26	1282	292	179	179
query27	3055	486	327	327
query28	4805	2013	1914	1914
query29	857	628	547	547
query30	315	252	212	212
query31	1376	1279	1215	1215
query32	83	70	74	70
query33	523	340	285	285
query34	932	926	578	578
query35	660	693	613	613
query36	1116	1173	995	995
query37	136	96	84	84
query38	3001	2914	2924	2914
query39	908	868	852	852
query39_1	830	827	833	827
query40	235	156	135	135
query41	62	59	59	59
query42	301	298	302	298
query43	243	253	234	234
query44	
query45	199	188	190	188
query46	866	979	602	602
query47	2149	2130	2052	2052
query48	313	316	225	225
query49	627	472	381	381
query50	676	275	215	215
query51	4113	4146	4047	4047
query52	288	294	289	289
query53	288	330	282	282
query54	295	270	257	257
query55	95	83	83	83
query56	320	317	295	295
query57	1341	1360	1283	1283
query58	289	277	271	271
query59	1352	1408	1315	1315
query60	338	338	320	320
query61	145	147	182	147
query62	635	587	540	540
query63	318	282	273	273
query64	4999	1283	973	973
query65	
query66	1450	472	366	366
query67	16649	16424	16351	16351
query68	
query69	404	311	289	289
query70	978	933	978	933
query71	349	304	301	301
query72	2824	2704	2393	2393
query73	542	546	323	323
query74	10015	9961	9771	9771
query75	2851	2756	2450	2450
query76	2293	1028	650	650
query77	364	374	311	311
query78	11178	11506	10659	10659
query79	1168	773	620	620
query80	1461	627	579	579
query81	573	280	255	255
query82	991	154	120	120
query83	353	270	245	245
query84	244	122	94	94
query85	1095	490	442	442
query86	410	309	302	302
query87	3214	3133	3033	3033
query88	3560	2664	2650	2650
query89	426	365	345	345
query90	1893	186	187	186
query91	165	156	132	132
query92	85	74	71	71
query93	1054	839	511	511
query94	653	336	289	289
query95	593	339	319	319
query96	637	512	231	231
query97	2484	2462	2395	2395
query98	235	224	217	217
query99	1011	985	927	927
Total cold run time: 234476 ms
Total hot run time: 153205 ms

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 0.00% (0/6) 🎉
Increment coverage report
Complete coverage report

@sahildevgon
Copy link
Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 27535 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2ae4d283ed635820528bfe2d7fefa746cb91a8ec, data reload: false

------ Round 1 ----------------------------------
============================================
q1	17647	4476	4287	4287
q2	q3	10663	824	518	518
q4	4681	364	252	252
q5	7543	1186	1000	1000
q6	167	176	148	148
q7	781	845	668	668
q8	9292	1441	1317	1317
q9	4781	4774	4701	4701
q10	6277	1897	1670	1670
q11	467	252	234	234
q12	681	586	467	467
q13	18036	2947	2158	2158
q14	226	236	221	221
q15	915	792	791	791
q16	748	719	672	672
q17	726	866	397	397
q18	5948	5399	5267	5267
q19	1268	987	602	602
q20	490	489	395	395
q21	4618	2066	1495	1495
q22	409	331	275	275
Total cold run time: 96364 ms
Total hot run time: 27535 ms

----- Round 2, with runtime_filter_mode=off -----
============================================
q1	4644	4628	4493	4493
q2	q3	3853	4298	3792	3792
q4	883	1221	762	762
q5	4013	4350	4314	4314
q6	204	177	140	140
q7	1756	1669	1523	1523
q8	2453	2724	2639	2639
q9	7748	7275	7329	7275
q10	3748	3972	3607	3607
q11	508	445	409	409
q12	486	592	432	432
q13	2742	3131	2384	2384
q14	290	296	270	270
q15	882	849	793	793
q16	710	748	689	689
q17	1123	1402	1330	1330
q18	7007	6835	6553	6553
q19	876	871	869	869
q20	2104	2145	1982	1982
q21	4014	3431	3394	3394
q22	443	427	390	390
Total cold run time: 50487 ms
Total hot run time: 48040 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 153336 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2ae4d283ed635820528bfe2d7fefa746cb91a8ec, data reload: false

query5	4335	627	523	523
query6	327	238	226	226
query7	4210	468	268	268
query8	340	242	232	232
query9	8714	2752	2756	2752
query10	516	382	353	353
query11	7393	5917	5599	5599
query12	198	133	133	133
query13	1270	492	357	357
query14	6311	3839	3607	3607
query14_1	2826	2829	2841	2829
query15	197	199	184	184
query16	1004	482	415	415
query17	1104	732	612	612
query18	2513	462	352	352
query19	215	213	185	185
query20	137	128	131	128
query21	232	148	136	136
query22	4871	5037	4911	4911
query23	16501	16148	15918	15918
query23_1	16172	16025	15799	15799
query24	7398	1621	1241	1241
query24_1	1236	1240	1252	1240
query25	571	471	483	471
query26	1226	262	149	149
query27	2788	471	287	287
query28	4511	1860	1854	1854
query29	858	565	479	479
query30	307	250	211	211
query31	1349	1278	1211	1211
query32	78	69	71	69
query33	508	322	285	285
query34	924	912	555	555
query35	641	674	588	588
query36	1071	1111	1006	1006
query37	140	96	85	85
query38	2951	2886	2882	2882
query39	875	875	857	857
query39_1	827	834	827	827
query40	230	159	134	134
query41	62	62	60	60
query42	309	301	305	301
query43	236	241	225	225
query44	
query45	231	194	184	184
query46	877	982	602	602
query47	2106	2167	2026	2026
query48	314	310	226	226
query49	629	458	381	381
query50	667	264	213	213
query51	4189	4064	4032	4032
query52	284	291	279	279
query53	291	335	280	280
query54	292	264	266	264
query55	93	89	85	85
query56	318	321	298	298
query57	1351	1326	1267	1267
query58	297	288	274	274
query59	1324	1431	1268	1268
query60	335	344	327	327
query61	154	148	145	145
query62	636	572	546	546
query63	311	286	283	283
query64	5101	1273	974	974
query65	
query66	1446	458	355	355
query67	16202	16397	16295	16295
query68	
query69	385	319	286	286
query70	938	966	942	942
query71	346	318	308	308
query72	2708	2680	2481	2481
query73	536	547	324	324
query74	9984	9898	9784	9784
query75	2856	2788	2479	2479
query76	2298	1032	691	691
query77	369	376	346	346
query78	11141	11331	10636	10636
query79	1127	774	588	588
query80	1205	636	526	526
query81	536	279	247	247
query82	1321	149	118	118
query83	334	264	239	239
query84	252	121	97	97
query85	983	498	432	432
query86	402	342	296	296
query87	3194	3094	3061	3061
query88	3480	2630	2654	2630
query89	422	372	343	343
query90	1839	185	182	182
query91	169	167	144	144
query92	82	81	71	71
query93	911	849	491	491
query94	543	316	293	293
query95	586	400	322	322
query96	634	517	230	230
query97	2461	2478	2414	2414
query98	235	223	220	220
query99	1000	1011	920	920
Total cold run time: 234018 ms
Total hot run time: 153336 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants