Skip to content

[Fix](warmup) Fix wrong rowset data size when calculating timeout of waiting delay compaction#61188

Open
bobhan1 wants to merge 1 commit intoapache:masterfrom
bobhan1:fix-delay-compaction
Open

[Fix](warmup) Fix wrong rowset data size when calculating timeout of waiting delay compaction#61188
bobhan1 wants to merge 1 commit intoapache:masterfrom
bobhan1:fix-delay-compaction

Conversation

@bobhan1
Copy link
Contributor

@bobhan1 bobhan1 commented Mar 10, 2026

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Mar 10, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@bobhan1
Copy link
Contributor Author

bobhan1 commented Mar 10, 2026

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 27625 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e42d253d8aa0673e3a96dcda0c802e51c15569ca, data reload: false

------ Round 1 ----------------------------------
============================================
q1	17684	4538	4294	4294
q2	q3	10647	780	502	502
q4	4671	366	252	252
q5	7562	1211	1041	1041
q6	176	177	144	144
q7	787	836	676	676
q8	9788	1465	1346	1346
q9	5198	4695	4741	4695
q10	6331	1914	1633	1633
q11	463	272	259	259
q12	746	568	461	461
q13	18056	2941	2187	2187
q14	231	231	225	225
q15	946	812	830	812
q16	778	725	685	685
q17	742	847	424	424
q18	5954	5468	5257	5257
q19	1259	970	595	595
q20	490	487	399	399
q21	4529	2115	1458	1458
q22	388	348	280	280
Total cold run time: 97426 ms
Total hot run time: 27625 ms

----- Round 2, with runtime_filter_mode=off -----
============================================
q1	4688	4672	4598	4598
q2	q3	3903	4419	3807	3807
q4	881	1194	772	772
q5	4051	4335	4306	4306
q6	182	178	149	149
q7	1775	1664	1609	1609
q8	2522	2715	2545	2545
q9	7733	7378	7437	7378
q10	3809	4048	3607	3607
q11	515	450	409	409
q12	486	607	450	450
q13	3075	3171	2303	2303
q14	283	298	277	277
q15	879	854	856	854
q16	736	766	740	740
q17	1174	1427	1330	1330
q18	7237	6792	6685	6685
q19	907	894	993	894
q20	2105	2158	1995	1995
q21	3965	3556	3396	3396
q22	487	422	386	386
Total cold run time: 51393 ms
Total hot run time: 48490 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 153195 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e42d253d8aa0673e3a96dcda0c802e51c15569ca, data reload: false

query5	4326	638	526	526
query6	331	227	210	210
query7	4223	464	268	268
query8	350	254	229	229
query9	8690	2736	2742	2736
query10	464	377	337	337
query11	7376	5857	5637	5637
query12	185	129	122	122
query13	1261	439	349	349
query14	5562	3846	3610	3610
query14_1	2887	2853	2847	2847
query15	210	195	176	176
query16	980	488	385	385
query17	1110	723	615	615
query18	2434	449	353	353
query19	213	215	186	186
query20	139	133	131	131
query21	231	142	121	121
query22	4911	5126	4930	4930
query23	16681	16278	15806	15806
query23_1	15905	15754	15734	15734
query24	8674	1680	1264	1264
query24_1	1311	1319	1288	1288
query25	619	512	481	481
query26	1273	309	169	169
query27	2712	499	293	293
query28	4456	1894	1908	1894
query29	826	562	467	467
query30	310	242	211	211
query31	1355	1289	1216	1216
query32	86	72	72	72
query33	503	325	271	271
query34	928	928	574	574
query35	636	679	618	618
query36	1041	1151	943	943
query37	130	93	83	83
query38	2905	2883	2873	2873
query39	875	1017	845	845
query39_1	814	823	834	823
query40	231	160	157	157
query41	64	60	58	58
query42	302	298	291	291
query43	250	249	226	226
query44	
query45	197	181	181	181
query46	865	985	615	615
query47	2136	2157	2046	2046
query48	319	314	227	227
query49	655	452	369	369
query50	716	282	224	224
query51	4113	4114	4074	4074
query52	285	294	283	283
query53	290	337	286	286
query54	300	270	257	257
query55	94	85	87	85
query56	324	320	306	306
query57	1375	1344	1313	1313
query58	290	277	271	271
query59	1373	1421	1252	1252
query60	349	336	323	323
query61	147	144	142	142
query62	616	593	536	536
query63	304	278	275	275
query64	5061	1250	967	967
query65	
query66	1448	471	354	354
query67	16396	16344	16305	16305
query68	
query69	404	330	292	292
query70	1020	974	992	974
query71	337	311	298	298
query72	2834	2686	2393	2393
query73	561	551	324	324
query74	9988	9922	9746	9746
query75	2858	2756	2439	2439
query76	2318	1019	651	651
query77	363	391	301	301
query78	11247	11461	10667	10667
query79	3022	811	604	604
query80	1738	676	548	548
query81	594	286	249	249
query82	984	159	117	117
query83	340	266	246	246
query84	257	115	102	102
query85	945	481	433	433
query86	496	310	297	297
query87	3151	3095	2974	2974
query88	3617	2681	2662	2662
query89	419	372	342	342
query90	2004	178	176	176
query91	179	159	134	134
query92	85	71	68	68
query93	1707	810	509	509
query94	648	312	280	280
query95	591	330	379	330
query96	643	520	225	225
query97	2494	2497	2432	2432
query98	236	219	218	218
query99	1035	945	933	933
Total cold run time: 238531 ms
Total hot run time: 153195 ms

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 10, 2026
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@bobhan1
Copy link
Contributor Author

bobhan1 commented Mar 12, 2026

run cloud_p0

@bobhan1
Copy link
Contributor Author

bobhan1 commented Mar 12, 2026

run beut

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.66% (19692/37397)
Line Coverage 36.19% (183585/507223)
Region Coverage 32.31% (141736/438652)
Branch Coverage 33.49% (61892/184818)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 57.20% (20939/36607)
Line Coverage 40.24% (203191/504995)
Region Coverage 37.00% (163627/442205)
Branch Coverage 37.72% (69795/185052)

Copy link
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.x dev/4.1.x reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants