[fix](build) Fix Boost sigtimedwait compile error on macOS#61285
Merged
airborne12 merged 1 commit intoapache:masterfrom Mar 13, 2026
Merged
[fix](build) Fix Boost sigtimedwait compile error on macOS#61285airborne12 merged 1 commit intoapache:masterfrom
airborne12 merged 1 commit intoapache:masterfrom
Conversation
macOS does not implement sigtimedwait despite declaring _POSIX_C_SOURCE >= 199309L. Boost 1.81's config.hpp incorrectly enables BOOST_POSIX_HAS_SIGTIMEDWAIT on macOS, causing compile failures in boost/process/detail/posix/wait_for_exit.hpp when boost/process.hpp is included (newly introduced by Python UDF feature apache#59543). Add a patch to exclude __APPLE__ from the sigtimedwait detection macro, so Boost falls back to its fork-based wait_for_exit implementation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Member
Author
|
run buildall |
TPC-H: Total hot run time: 27853 ms |
TPC-DS: Total hot run time: 153544 ms |
Member
Author
|
run check_coverage |
zclllyybb
approved these changes
Mar 13, 2026
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
16 tasks
yiguolei
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: N/A
Related PR: N/A
Problem Summary:
macOS does not implement
sigtimedwaitdespite declaring_POSIX_C_SOURCE >= 199309L. Boost 1.81'sconfig.hppincorrectly enablesBOOST_POSIX_HAS_SIGTIMEDWAITon macOS, causing compile failures inboost/process/detail/posix/wait_for_exit.hpp.This issue was newly exposed by the Python UDF feature (#59543), which introduced the first usage of
boost/process.hppin the BE codebase via the include chain:aggregate_function_python_udaf.cpp → python_udaf_client.h → python_client.h → python_udf_runtime.h → boost/process.hppThis PR adds a thirdparty patch to exclude
__APPLE__from the sigtimedwait detection macro, so Boost falls back to its fork-basedwait_for_exitimplementation. The patch is only applied on Darwin and does not affect Linux builds.Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)