[Enhancement](mv-rewrite) Replace naive set-containment residual#61345
Open
foxtail463 wants to merge 1 commit intoapache:masterfrom
Open
[Enhancement](mv-rewrite) Replace naive set-containment residual#61345foxtail463 wants to merge 1 commit intoapache:masterfrom
foxtail463 wants to merge 1 commit intoapache:masterfrom
Conversation
compensation with DNF implication The old residual compensation simply checks whether the query residual set contains all view residual predicates. This breaks on real-world MV rewrites where query and view residuals are structurally different but logically implicative -- e.g. query residual A OR (B AND C) vs view residual A OR B The old code sees two different expression trees and bails out, even though the query side is strictly stronger. This patch introduces DNF-based implication checking (impliesByDnf) to replace the set-containment approach, so compensation succeeds whenever the query candidates logically imply the view residual regardless of structural differences. A hard cap (MAX_DNF_BRANCHES=1024) guards against exponential expansion; when the proof is too expensive the compensation fails conservatively rather than hanging the optimizer. The three separate compensate calls in AbstractMaterializedViewRule are collapsed into a single Predicates.compensatePredicates entry point that encapsulates candidate collection and residual finalization.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compensation with DNF implication
The old residual compensation simply checks whether the query residual set contains all view residual predicates. This breaks on real-world MV rewrites where query and view residuals are structurally different but logically implicative -- e.g. query residual
A OR (B AND C)
vs view residual
A OR B
The old code sees two different expression trees and bails out, even though the query side is strictly stronger.
This patch introduces DNF-based implication checking (impliesByDnf) to replace the set-containment approach, so compensation succeeds whenever the query candidates logically imply the view residual regardless of structural differences. A hard cap (MAX_DNF_BRANCHES=1024) guards against exponential expansion; when the proof is too expensive the compensation fails conservatively rather than hanging the optimizer.
The three separate compensate calls in AbstractMaterializedViewRule are collapsed into a single Predicates.compensatePredicates entry point that encapsulates candidate collection and residual finalization.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)