[Enhancement](file-cache) Add fine-grained control for compaction file cache#61354
Open
gavinchou wants to merge 2 commits intoapache:branch-4.0from
Open
[Enhancement](file-cache) Add fine-grained control for compaction file cache#61354gavinchou wants to merge 2 commits intoapache:branch-4.0from
gavinchou wants to merge 2 commits intoapache:branch-4.0from
Conversation
…e cache
Support selective caching of index files only during compaction in cloud mode.
Changes:
- Add two mBool configs to control index-only caching for base and cumulative compaction:
* enable_file_cache_write_base_compaction_index_only (default: false)
* enable_file_cache_write_cumu_compaction_index_only (default: false)
- Extend RowsetWriterContext with compaction_output_write_index_only field
to mark whether only index files should be cached
- Modify get_file_writer_options() to accept is_index_file parameter:
* When compaction_output_write_index_only=true and is_index_file=false,
set write_file_cache=false to skip caching data files
* Index files continue to be cached normally
- Update file writer creation call sites to pass is_index_file parameter:
* Index file writers: pass true
* Segment (data) file writers: pass false
Benefits:
- Reduces cache pressure by avoiding caching large data files during compaction
- Preserves index file caching for query performance
- Provides separate control for base and cumulative compaction strategies
- Maintains backward compatibility with default settings
Cherry-picked from apache#60609
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support selective caching of index files only during compaction in cloud mode.
Cherry-picked from #60609
Changes:
Add two mBool configs to control index-only caching for base and cumulative compaction:
Extend RowsetWriterContext with compaction_output_write_index_only field
to mark whether only index files should be cached
Modify get_file_writer_options() to accept is_index_file parameter:
set write_file_cache=false to skip caching data files
Update file writer creation call sites to pass is_index_file parameter:
Benefits: