Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Improve](Streamingjob) support only snapshot sync for mysql and pg #61389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[Improve](Streamingjob) support only snapshot sync for mysql and pg #61389
Changes from all commits
643e585File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug (High): Early return from
before()when offset is null leaves the job stuckWhen
getNextOffset()returns null (snapshot-only completed), this task returns early frombefore(), thenrun()also returns early, thenonSuccess()returnsfalsewithout callingonStreamTaskSuccess(). TheStreamingMultiTblTask.onSuccess()never callsonStreamTaskSuccess()— it always returns false (line 243).The job completion signal for multi-table tasks only comes via the external
commitOffset()→successCallback()→onStreamTaskSuccess()callback path, which is never triggered for a no-op task (no data sent to BE, no offset committed).Result: The task finishes silently, the job stays in
RUNNINGwith a dead task reference, eventually times out toPAUSED, auto-resumes toPENDING, creates another null-offset task, and loops forever.Suggested fix: In
StreamingMultiTblTask.onSuccess(), whenrunningOffset == null, directly callstreamingInsertJob.onStreamTaskSuccess(this)(after acquiring the write lock via the appropriate path). Alternatively, handle this inbefore()by checkingoffsetProvider.hasReachedEnd()and signaling the job directly.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note:
hasReachedEnd()callscurrentOffset.snapshotSplit()which requires non-null, non-empty splits (enforced byPreconditions.checkStateinJdbcOffset.snapshotSplit()). After crash recovery for a completed snapshot-only job,currentOffsethas null splits (see comment onreplayIfNeed), so this method will throwIllegalStateException.Consider either:
currentOffset.getSplits() != null && !currentOffset.getSplits().isEmpty() && currentOffset.snapshotSplit()replayIfNeedalways leavescurrentOffsetin a valid state with actual splits set.Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.