[fix](test) Fix BDB JE resource leak in BDBEnvironmentTest causing FE UT timeout#61404
Merged
morningman merged 1 commit intoapache:masterfrom Mar 17, 2026
Merged
Conversation
… UT timeout The following resource leak issues in BDBEnvironmentTest cause BDB JE checkpoint threads to enter an infinite VLSN consistency retry loop during JVM shutdown, blocking the Maven Surefire process from exiting and triggering TeamCity execution timeout (~3 hours): 1. testReadTxnIsNotMatched: reopens BDB JE master environment and database at the end but never closes them. 2. testRollbackException: has an early 'return' when fe1 is elected as master, which exits the method without closing any of the 3 BDB JE environments. Fix by wrapping the test logic of both multi-node cluster tests (testRollbackException, testReadTxnIsNotMatched) with try/finally blocks that guarantee all BDB JE environments are closed, regardless of whether the test passes, fails an assertion, or returns early.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run feut |
Contributor
FE UT Coverage ReportIncrement line coverage `` 🎉 |
Contributor
|
skip buildall |
hello-stephen
approved these changes
Mar 17, 2026
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
suxiaogang223
approved these changes
Mar 17, 2026
github-actions bot
pushed a commit
that referenced
this pull request
Mar 17, 2026
… UT timeout (#61404) ### What problem does this PR solve? The following resource leak issues in BDBEnvironmentTest cause BDB JE checkpoint threads to enter an infinite VLSN consistency retry loop during JVM shutdown, blocking the Maven Surefire process from exiting and triggering TeamCity execution timeout (~3 hours): 1. testReadTxnIsNotMatched: reopens BDB JE master environment and database at the end but never closes them. 2. testRollbackException: has an early 'return' when fe1 is elected as master, which exits the method without closing any of the 3 BDB JE environments. Fix by wrapping the test logic of both multi-node cluster tests (testRollbackException, testReadTxnIsNotMatched) with try/finally blocks that guarantee all BDB JE environments are closed, regardless of whether the test passes, fails an assertion, or returns early.
github-actions bot
pushed a commit
that referenced
this pull request
Mar 17, 2026
… UT timeout (#61404) ### What problem does this PR solve? The following resource leak issues in BDBEnvironmentTest cause BDB JE checkpoint threads to enter an infinite VLSN consistency retry loop during JVM shutdown, blocking the Maven Surefire process from exiting and triggering TeamCity execution timeout (~3 hours): 1. testReadTxnIsNotMatched: reopens BDB JE master environment and database at the end but never closes them. 2. testRollbackException: has an early 'return' when fe1 is elected as master, which exits the method without closing any of the 3 BDB JE environments. Fix by wrapping the test logic of both multi-node cluster tests (testRollbackException, testReadTxnIsNotMatched) with try/finally blocks that guarantee all BDB JE environments are closed, regardless of whether the test passes, fails an assertion, or returns early.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
The following resource leak issues in BDBEnvironmentTest cause BDB JE checkpoint threads to enter an infinite VLSN consistency retry loop during JVM shutdown, blocking the Maven Surefire process from exiting and triggering TeamCity execution timeout (~3 hours):
testReadTxnIsNotMatched: reopens BDB JE master environment and database at the end but never closes them.
testRollbackException: has an early 'return' when fe1 is elected as master, which exits the method without closing any of the 3 BDB JE environments.
Fix by wrapping the test logic of both multi-node cluster tests (testRollbackException, testReadTxnIsNotMatched) with try/finally blocks that guarantee all BDB JE environments are closed, regardless of whether the test passes, fails an assertion, or returns early.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)