branch-4.1: [feature](score) support BM25 scoring in inverted index query_v2 #59847#61472
Merged
yiguolei merged 4 commits intoapache:branch-4.1from Mar 19, 2026
Merged
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Member
Author
|
run buildall |
airborne12
force-pushed
the
pick/branch-4.1/59847
branch
from
4a5d6d0 to
094e120
Compare
Member
Author
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
…M25 scoring 1. Update contrib/clucene from 8b57674 to c51b5cc to include: - ac9475a: block max WAND algorithm with BM25 similarity - aef5c9c: Fix GCC -Werror compilation errors - c51b5cc: Fix GCC -Werror=overloaded-virtual in FieldForMerge Required for readBlock, getMaxBlockFreq, getMaxBlockNorm, getLastDocInBlock APIs used by segment_postings.h 2. Fix doc_set_collector: When context.readers is empty (e.g., AllQuery for MATCH_ALL_DOCS), for_each_index_segment returns immediately without iterating. Added fallback to create scorer directly from weight, which allows AllScorer to work without an IndexReader.
airborne12
force-pushed
the
pick/branch-4.1/59847
branch
from
46d977d to
6cb69d6
Compare
Member
Author
|
run buildall |
Contributor
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
Member
Author
|
run buildall |
Contributor
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
The branch-4.0 stub (static, returns false) conflicts with the real implementation in the anonymous namespace added by the BM25 scoring PR. On branch-4.1 the real implementation is correct, so remove the stub to fix the ambiguous call compilation error.
Member
Author
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
FE UT Coverage ReportIncrement line coverage |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
yiguolei
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Cherry-pick #59847 to branch-4.1.
Original PR: #59847
Further comments
Resolved cherry-pick conflicts (minor differences from branch-4.0 pick):
IndexQueryContextPtrmember andset/get_index_query_contexttoIndexExecContextevaluate_inverted_index_with_search_paramwithindex_query_contextparameterenable_inverted_index_wand_queryto thrift and SessionVariable (field 203)single_backend_queryfield 202) intact