[fix](tool) Fix meta_tool coredump and dead loop issues#61509
Open
wenzhenghu wants to merge 4 commits intoapache:masterfrom
Open
[fix](tool) Fix meta_tool coredump and dead loop issues#61509wenzhenghu wants to merge 4 commits intoapache:masterfrom
wenzhenghu wants to merge 4 commits intoapache:masterfrom
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 26839 ms |
TPC-DS: Total hot run time: 168316 ms |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 27112 ms |
TPC-DS: Total hot run time: 169489 ms |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
related issue：#61447
Proposed changes
This PR fixes several bugs in the offline tool
meta_tool, including coredumps caused by uninitialized ExecEnv components and a dead loop when loading tablet meta.Fix coredump in offline commands:
show_meta,batch_delete_meta,show_segment_footer,show_segment_data): These do not require a full StorageEngine environment but still rely on basic components likeTabletSchemaCache,TabletColumnObjectPool, andMemTracker. This PR introduces a lightweight initialization functioninit_common_components()for them to prevent coredumps caused by null pointer dereferences.get_meta,load_meta,delete_meta): These commands initialize aStorageEngineandDataDirinstance to read/write RocksDB. The PR ensures that they correctly load configurations frombe.conf(viaDORIS_HOME) and also callinit_common_components()to guarantee that both the global settings (e.g., memory limits, thread pools) and the ExecEnv components are properly set up before the engine starts.Fix dead loop in
load_meta:The
TabletMetaManager::load_json_metafunction previously usedinfile.getline()in awhile(!infile.eof())loop. If the file cannot be opened or an error occurs, thefailbitis set but not theeofbit, causing an infinite loop. This has been fixed by reading the file content safely usingstd::istreambuf_iteratorand adding anis_open()check.Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)