[cleanup](build) Replace #include exec_env.h with forward declaration in 15 headers#61556
Closed
shuke987 wants to merge 1 commit intoapache:masterfrom
Closed
[cleanup](build) Replace #include exec_env.h with forward declaration in 15 headers#61556shuke987 wants to merge 1 commit intoapache:masterfrom
shuke987 wants to merge 1 commit intoapache:masterfrom
Conversation
… in 15 headers Remove unused #include "runtime/exec_env.h" from 7 header files and replace with forward declaration class ExecEnv in 8 header files that only use ExecEnv*. Move the full include to corresponding .cpp files where needed. This reduces the include fan-out of exec_env.h (591 lines) across the codebase, improving incremental build times when exec_env.h changes. Headers with include removed (unused): - pipeline/exec/aggregation_sink_operator.h - vec/exec/scan/vscanner.h - vec/sink/load_stream_map_pool.h - vec/sink/load_stream_stub.h - vec/sink/writer/vtablet_writer_v2.h - vec/sink/writer/vtablet_writer.h - olap/wal/wal_info.h Headers with forward declaration added: - agent/workload_sched_policy_listener.h - runtime/group_commit_mgr.h - olap/wal/wal_manager.h - olap/wal/wal_table.h - runtime/query_context.h - runtime/workload_management/workload_sched_policy_mgr.h - http/action/compaction_score_action.h - http/http_handler_with_auth.h Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Author
|
run buildall |
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Collaborator
Author
|
Closing: file paths were wrong. Will resubmit with verified changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#include "runtime/exec_env.h"from 7 header files where ExecEnv is not referenced at all#include "runtime/exec_env.h"withclass ExecEnv;forward declaration in 8 header files that only useExecEnv*(pointer/reference)#include "runtime/exec_env.h"to corresponding.cppfiles where needed to maintain compilationThis reduces the include fan-out of
exec_env.h(591 lines) across the codebase, improving incremental build times whenexec_env.hor any of its transitive dependencies change.Headers with include removed (unused):
pipeline/exec/aggregation_sink_operator.hvec/exec/scan/vscanner.hvec/sink/load_stream_map_pool.hvec/sink/load_stream_stub.hvec/sink/writer/vtablet_writer_v2.hvec/sink/writer/vtablet_writer.holap/wal/wal_info.hHeaders with forward declaration added:
agent/workload_sched_policy_listener.hruntime/group_commit_mgr.holap/wal/wal_manager.holap/wal/wal_table.hruntime/query_context.hruntime/workload_management/workload_sched_policy_mgr.hhttp/action/compaction_score_action.hhttp/http_handler_with_auth.hTest plan
🤖 Generated with Claude Code