[fix](metrics) Fix prepared statement QPS metrics not counted when audit log disabled#61621
Open
Yukang-Lian wants to merge 2 commits intoapache:masterfrom
Open
[fix](metrics) Fix prepared statement QPS metrics not counted when audit log disabled#61621Yukang-Lian wants to merge 2 commits intoapache:masterfrom
Yukang-Lian wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
…dit log disabled When enable_prepared_stmt_audit_log is false (default), auditAfterExec() is skipped entirely for prepared statements. Since QPS metric counting (COUNTER_QUERY_ALL, COUNTER_QUERY_ERR, HISTO_QUERY_LATENCY, etc.) lives inside auditAfterExec -> AuditLogHelper.logAuditLog(), these metrics are also lost for prepared statement SELECT queries. Add AuditLogHelper.updateMetrics() to count metrics independently of audit log writing, and call it in the else branch when audit log is disabled.
Yukang-Lian
force-pushed
the
fix/prepared-stmt-qps-metric-missing
branch
from
bbc8651 to
a53c421
Compare
dataroaring
reviewed
Mar 23, 2026
…minate duplicate code Let logAuditLogImpl() call updateMetricsImpl() for metric counting instead of duplicating the same logic. Only audit-specific fields (setSqlDigest, setScanBytes) remain in logAuditLogImpl.
Collaborator
Author
|
run buildall |
TPC-H: Total hot run time: 26741 ms |
TPC-DS: Total hot run time: 169386 ms |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enable_prepared_stmt_audit_log = false(default),auditAfterExec()is entirely skipped for prepared statements. Since QPS metric counting (COUNTER_QUERY_ALL,COUNTER_QUERY_ERR,HISTO_QUERY_LATENCY, etc.) lives insideAuditLogHelper.logAuditLog(), these metrics are also lost for prepared statement SELECT queries.AuditLogHelper.updateMetrics()to count metrics independently of audit log writing, and call it in theelsebranch when audit log is disabled.logAuditLogImpl()logic.Changes
updateMetrics()+updateMetricsImpl()methods for standalone metric counting withenable_bdbje_debug_modeshort-circuit and catch-all exception isolation (matchingauditAfterExecprotection semantics).elsebranch inhandleExecute()to callupdateMetrics()when audit log is disabled.Test plan
AuditLogHelperTest- 4 cases)insert_group_commit_with_prepare_stmt.groovy)🤖 Generated with Claude Code