Skip to content

branch-4.0: [fix](fe) Fix bugs in SummaryProfile and StmtExecutor metric reporting #61601#61643

Merged
yiguolei merged 1 commit intobranch-4.0from
auto-pick-61601-branch-4.0
Mar 24, 2026
Merged

branch-4.0: [fix](fe) Fix bugs in SummaryProfile and StmtExecutor metric reporting #61601#61643
yiguolei merged 1 commit intobranch-4.0from
auto-pick-61601-branch-4.0

Conversation

@github-actions
Copy link
Contributor

Cherry-picked from #61601

#61601)

### What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

Fix three bugs found in SummaryProfile and StmtExecutor:

1. **Wrong field assignment in `addNereidsPartitiionPruneTime()`**
(SummaryProfile.java):
The method was incorrectly accumulating partition prune time into
`externalTvfInitTime`
   instead of `nereidsPartitiionPruneTime`. This caused:
- `nereidsPartitiionPruneTime` to always be 0, so
`HISTO_PLAN_PARTITION_PRUNE_DURATION`
     metric never collected correct data
- `externalTvfInitTime` to be polluted with unrelated partition prune
time data

2. **Wrong guard variable for translate metric** (StmtExecutor.java):
   When reporting `HISTO_PLAN_TRANSLATE_DURATION`, the condition checked
`nereidsOptimizeTimeMs >= 0` instead of `nereidsTranslateTimeMs >= 0`.
   This means the translate metric was gated by the optimize time value
   rather than the translate time value itself.
@github-actions github-actions bot requested a review from yiguolei as a code owner March 24, 2026 03:04
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Mar 24, 2026
@hello-stephen
Copy link
Contributor

run buildall

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 100.00% (2/2) 🎉
Increment coverage report
Complete coverage report

@yiguolei
Copy link
Contributor

skip buildall

@yiguolei yiguolei merged commit 38ae4a9 into branch-4.0 Mar 24, 2026
28 of 30 checks passed
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 24, 2026
@github-actions
Copy link
Contributor Author

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor Author

PR approved by anyone and no changes requested.

@github-actions github-actions bot deleted the auto-pick-61601-branch-4.0 branch March 24, 2026 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants