Skip to content

branch-4.0: [chore](topn) check column type before merging lazy materialization columns #61633#61667

Merged
yiguolei merged 1 commit intobranch-4.0from
auto-pick-61633-branch-4.0
Mar 25, 2026
Merged

branch-4.0: [chore](topn) check column type before merging lazy materialization columns #61633#61667
yiguolei merged 1 commit intobranch-4.0from
auto-pick-61633-branch-4.0

Conversation

@github-actions
Copy link
Contributor

Cherry-picked from #61633

…olumns (#61633)

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Check column type before merging lazy materialization columns, to avoid
coredump in case of any column type mismatch.

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@github-actions github-actions bot requested a review from yiguolei as a code owner March 24, 2026 09:12
@Thearas
Copy link
Contributor

Thearas commented Mar 24, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Mar 24, 2026
@Thearas
Copy link
Contributor

Thearas commented Mar 24, 2026

run buildall

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 100.00% (7/7) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.93% (19204/36281)
Line Coverage 36.11% (178909/495513)
Region Coverage 32.73% (138665/423679)
Branch Coverage 33.71% (60262/178788)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (7/7) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.32% (25333/35518)
Line Coverage 54.02% (267196/494630)
Region Coverage 51.55% (220620/427955)
Branch Coverage 53.02% (95137/179431)

@yiguolei
Copy link
Contributor

skip buildall

@yiguolei yiguolei merged commit 52609b9 into branch-4.0 Mar 25, 2026
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants