Skip to content

[fix](view) ALTER VIEW definition not synced to follower FE when COMMENT is specified#61670

Open
englefly wants to merge 1 commit intoapache:masterfrom
englefly:follower-replay-bug
Open

[fix](view) ALTER VIEW definition not synced to follower FE when COMMENT is specified#61670
englefly wants to merge 1 commit intoapache:masterfrom
englefly:follower-replay-bug

Conversation

@englefly
Copy link
Contributor

What problem does this PR solve?

before this fix, if alter view statement contains COMMENTS, follower FE will skip updating the view body.

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@englefly
Copy link
Contributor Author

run buildall

@englefly englefly changed the title [fix](view) replay modify view bug [fix](view) ALTER VIEW definition not synced to follower FE when COMMENT is specified Mar 24, 2026
@doris-robot
Copy link

TPC-H: Total hot run time: 26870 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d535c9f0e1305cf0fccb46dbe899991dcea066e5, data reload: false

------ Round 1 ----------------------------------
orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	17575	4570	4355	4355
q2	q3	10655	827	529	529
q4	4677	351	249	249
q5	7568	1217	1021	1021
q6	178	178	153	153
q7	782	853	694	694
q8	9295	1523	1327	1327
q9	4866	4793	4710	4710
q10	6252	1939	1631	1631
q11	465	250	242	242
q12	711	576	469	469
q13	18029	2718	1936	1936
q14	228	235	221	221
q15	q16	731	741	672	672
q17	732	795	497	497
q18	6081	5416	5358	5358
q19	1103	975	615	615
q20	541	500	381	381
q21	4483	1829	1416	1416
q22	346	394	466	394
Total cold run time: 95298 ms
Total hot run time: 26870 ms

----- Round 2, with runtime_filter_mode=off -----
orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	4793	4606	4645	4606
q2	q3	3875	4352	3836	3836
q4	899	1221	763	763
q5	4081	4362	4388	4362
q6	186	176	145	145
q7	1755	1673	1529	1529
q8	2489	2718	2571	2571
q9	7749	7487	7469	7469
q10	3777	4017	3630	3630
q11	506	454	426	426
q12	491	587	527	527
q13	2645	2893	2060	2060
q14	313	307	274	274
q15	q16	754	795	733	733
q17	1239	1341	1338	1338
q18	7125	6907	6734	6734
q19	892	919	918	918
q20	2087	2135	1971	1971
q21	3974	3528	3353	3353
q22	480	431	377	377
Total cold run time: 50110 ms
Total hot run time: 47622 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 169186 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d535c9f0e1305cf0fccb46dbe899991dcea066e5, data reload: false

query5	4344	645	497	497
query6	332	237	215	215
query7	4218	477	277	277
query8	343	246	237	237
query9	8693	2664	2699	2664
query10	494	408	340	340
query11	6961	5139	4867	4867
query12	197	129	121	121
query13	1265	434	337	337
query14	5686	3694	3446	3446
query14_1	2811	2806	2832	2806
query15	201	188	173	173
query16	988	472	444	444
query17	1121	702	628	628
query18	2435	449	354	354
query19	213	205	177	177
query20	134	126	128	126
query21	214	131	108	108
query22	13297	14175	14659	14175
query23	16698	16457	15994	15994
query23_1	15973	15764	15942	15764
query24	7306	1612	1232	1232
query24_1	1229	1220	1237	1220
query25	608	464	403	403
query26	1244	258	144	144
query27	2788	476	291	291
query28	4518	1826	1817	1817
query29	829	564	474	474
query30	294	225	189	189
query31	1008	956	878	878
query32	81	77	76	76
query33	517	334	281	281
query34	889	868	533	533
query35	626	701	610	610
query36	1077	1105	904	904
query37	133	96	82	82
query38	2945	2953	2852	2852
query39	843	829	811	811
query39_1	802	796	806	796
query40	235	154	144	144
query41	65	59	57	57
query42	258	260	250	250
query43	244	245	218	218
query44	
query45	196	192	185	185
query46	897	973	603	603
query47	2099	2136	2081	2081
query48	322	328	233	233
query49	630	475	385	385
query50	703	288	214	214
query51	4124	4059	3974	3974
query52	258	264	255	255
query53	295	337	285	285
query54	298	275	272	272
query55	98	92	81	81
query56	319	333	336	333
query57	1934	1732	1703	1703
query58	283	279	274	274
query59	2804	2965	2758	2758
query60	348	345	323	323
query61	159	151	153	151
query62	632	595	543	543
query63	305	280	279	279
query64	5048	1292	1008	1008
query65	
query66	1468	457	354	354
query67	24291	24301	24285	24285
query68	
query69	409	341	298	298
query70	931	996	905	905
query71	347	307	303	303
query72	3003	2860	2635	2635
query73	547	555	320	320
query74	9628	9562	9448	9448
query75	2889	2782	2491	2491
query76	2322	1024	697	697
query77	392	371	305	305
query78	11012	11224	10521	10521
query79	1108	760	590	590
query80	987	628	554	554
query81	547	263	229	229
query82	1341	152	123	123
query83	332	257	244	244
query84	253	119	98	98
query85	979	491	457	457
query86	388	309	282	282
query87	3144	3100	3006	3006
query88	3531	2658	2684	2658
query89	436	370	336	336
query90	1871	184	172	172
query91	177	177	140	140
query92	80	74	70	70
query93	910	837	490	490
query94	555	333	313	313
query95	593	345	320	320
query96	662	518	232	232
query97	2496	2481	2392	2392
query98	236	227	217	217
query99	1023	992	911	911
Total cold run time: 250092 ms
Total hot run time: 169186 ms

@englefly
Copy link
Contributor Author

run p0

@englefly
Copy link
Contributor Author

run external

1 similar comment
@englefly
Copy link
Contributor Author

run external

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants