[Fix](Regression) reduce duplicate hive2/hive3 regression runs#61671
Open
xylaaaaa wants to merge 1 commit intoapache:masterfrom
Open
[Fix](Regression) reduce duplicate hive2/hive3 regression runs#61671xylaaaaa wants to merge 1 commit intoapache:masterfrom
xylaaaaa wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
There was a problem hiding this comment.
Pull request overview
This PR reduces CI workload for external Hive regression testing by removing the duplicated Hive3 run from a set of “general” suites, keeping Hive3-only coverage to dedicated suites.
Changes:
- Update multiple external Hive regression suites to iterate over
["hive2"]instead of["hive2", "hive3"]. - Apply the same hive2-only change to selected MTMV Hive suites.
Reviewed changes
Copilot reviewed 55 out of 55 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| regression-test/suites/mtmv_p0/test_hive_rewrite_mtmv.groovy | Run MTMV rewrite coverage against Hive2 only |
| regression-test/suites/mtmv_p0/test_hive_olap_mtmv.groovy | Run MTMV Hive↔Olap coverage against Hive2 only |
| regression-test/suites/mtmv_p0/test_hive_mtmv.groovy | Run MTMV basic coverage against Hive2 only |
| regression-test/suites/external_table_p0/hive/test_wide_table.groovy | Hive wide-table suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_utf8_check.groovy | UTF-8 validation suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_upper_case_column_name.groovy | Upper-case column name suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_truncate_char_or_varchar_columns.groovy | Truncate CHAR/VARCHAR suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_text_skip_header.groovy | Text skip-header suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_text_garbled_file.groovy | Garbled text file suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_string_dict_filter.groovy | String dict filter suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_special_orc_formats.groovy | Special ORC formats suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_parquet_nested_types.groovy | Parquet nested types suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_parquet_bloom_filter.groovy | Parquet bloom filter suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_orc_nested_types.groovy | ORC nested types suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_open_csv_serde.groovy | OpenCSV serde suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_multi_delimit_serde.groovy | Multi-delimiter serde suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_mixed_par_locations.groovy | Mixed partition locations suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_hive_varbinary_type.groovy | VARBINARY type suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_hive_to_date.groovy | to_date compatibility suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_hive_to_array.groovy | to_array compatibility suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_hive_text_complex_type.groovy | Text complex type suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_hive_tablesample_p0.groovy | TABLESAMPLE suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_hive_statistics_p0.groovy | Hive statistics suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_hive_statistics_all_type_p0.groovy | Hive statistics (all types) suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_hive_statistic_timeout.groovy | Hive statistic timeout suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_hive_statistic_clean.groovy | Hive statistic clean suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_hive_statistic_auto.groovy | Hive statistic auto suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_hive_statistic.groovy | Hive statistic suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_hive_schema_evolution.groovy | Hive schema evolution suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_hive_same_db_table_name.groovy | Same DB/table name suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_hive_runtime_filter_partition_pruning.groovy | Runtime filter partition pruning suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_hive_remove_partition.groovy | Remove partition suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_hive_query_cache.groovy | Query cache suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_hive_partition_location.groovy | Partition location suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_hive_partition_column_analyze.groovy | Partition-column analyze suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_hive_parquet_skip_page.groovy | Parquet skip-page suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_hive_parquet_alter_column.groovy | Parquet alter-column suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_hive_parquet.groovy | Parquet suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_hive_other.groovy | Misc Hive suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_hive_orc.groovy | ORC suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_hive_get_schema_from_table.groovy | Get-schema-from-table suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_hive_default_partition.groovy | Default partition suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_hive_broker_scan.groovy | Broker scan suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_hive_basic_type.groovy | Basic types suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_hive_analyze_db.groovy | Analyze database suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_external_credit_data.groovy | External credit data suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_external_catalog_hive_partition.groovy | External catalog partition suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_external_catalog_hive.groovy | External catalog suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_drop_expired_table_stats.groovy | Drop expired stats suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_different_parquet_types.groovy | Different parquet types suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_different_column_orders.groovy | Different column orders suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/test_complex_types.groovy | Complex types suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/hive_tpch_sf1_parquet.groovy | TPC-H SF1 parquet suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/hive_tpch_sf1_orc.groovy | TPC-H SF1 ORC suite: Hive2 only |
| regression-test/suites/external_table_p0/hive/hive_json_basic_test.groovy | Hive JSON basic suite: Hive2 only |
Comments suppressed due to low confidence (2)
regression-test/suites/external_table_p0/hive/test_hive_analyze_db.groovy:47
- This suite is
test_hive_analyze_db, butcatalog_nameis${hivePrefix}_test_hive_partition_column_analyze(same astest_hive_partition_column_analyze). Reusing another suite’s catalog name risks collisions/flaky behavior if suites run concurrently and makes test output confusing. Rename the catalog to something unique totest_hive_analyze_db.
String extHiveHmsHost = context.config.otherConfigs.get("externalEnvIp")
String extHiveHmsPort = context.config.otherConfigs.get(hivePrefix + "HmsPort")
String catalog_name = "${hivePrefix}_test_hive_partition_column_analyze"
sql """drop catalog if exists ${catalog_name};"""
regression-test/suites/external_table_p0/hive/test_text_skip_header.groovy:30
catalog_nameis set to${hivePrefix}_test_utf8_check, which is the same catalog name used bytest_utf8_checkand does not match this suite (test_hive_text_skip_header). This can cause cross-suite interference (dropping/recreating another suite’s catalog) and makes failures harder to diagnose. Use a suite-specific catalog name (e.g., based ontest_hive_text_skip_header).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
run buildall |
1 similar comment
Contributor
Author
|
run buildall |
Keep general external Hive coverage on hive3-only and preserve the more version-sensitive suites separately.
04a5b62 to
d229063
Compare
Contributor
Author
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing