[test] reduce redundant hive3 runs in external regression#61672
Closed
xylaaaaa wants to merge 1 commit intoapache:masterfrom
Closed
[test] reduce redundant hive3 runs in external regression#61672xylaaaaa wants to merge 1 commit intoapache:masterfrom
xylaaaaa wants to merge 1 commit intoapache:masterfrom
Conversation
Keep version-agnostic external Hive regression suites on hive2 only while preserving hive3-specific coverage elsewhere.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
There was a problem hiding this comment.
Pull request overview
Reduces runtime of external Hive regression by running version-agnostic suites only against Hive2, while keeping Hive3 coverage for dedicated Hive3-specific suites elsewhere.
Changes:
- Updated multiple regression suites to iterate over
["hive2"]instead of["hive2", "hive3"]. - Keeps suite logic otherwise unchanged (single-line loop updates across suites).
Reviewed changes
Copilot reviewed 55 out of 55 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| regression-test/suites/mtmv_p0/test_hive_rewrite_mtmv.groovy | Run MTMV rewrite suite only on Hive2 |
| regression-test/suites/mtmv_p0/test_hive_olap_mtmv.groovy | Run MTMV OLAP suite only on Hive2 |
| regression-test/suites/mtmv_p0/test_hive_mtmv.groovy | Run MTMV suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_wide_table.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_utf8_check.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_upper_case_column_name.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_truncate_char_or_varchar_columns.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_text_skip_header.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_text_garbled_file.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_string_dict_filter.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_special_orc_formats.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_parquet_nested_types.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_parquet_bloom_filter.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_orc_nested_types.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_open_csv_serde.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_multi_delimit_serde.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_mixed_par_locations.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_hive_varbinary_type.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_hive_to_date.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_hive_to_array.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_hive_text_complex_type.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_hive_tablesample_p0.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_hive_statistics_p0.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_hive_statistics_all_type_p0.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_hive_statistic_timeout.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_hive_statistic_clean.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_hive_statistic_auto.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_hive_statistic.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_hive_schema_evolution.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_hive_same_db_table_name.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_hive_runtime_filter_partition_pruning.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_hive_remove_partition.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_hive_query_cache.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_hive_partition_location.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_hive_partition_column_analyze.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_hive_parquet_skip_page.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_hive_parquet_alter_column.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_hive_parquet.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_hive_other.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_hive_orc.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_hive_get_schema_from_table.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_hive_default_partition.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_hive_broker_scan.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_hive_basic_type.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_hive_analyze_db.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_external_credit_data.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_external_catalog_hive_partition.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_external_catalog_hive.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_drop_expired_table_stats.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_different_parquet_types.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_different_column_orders.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/test_complex_types.groovy | Run suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/hive_tpch_sf1_parquet.groovy | Run TPC-H parquet suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/hive_tpch_sf1_orc.groovy | Run TPC-H ORC suite only on Hive2 |
| regression-test/suites/external_table_p0/hive/hive_json_basic_test.groovy | Run JSON suite only on Hive2 |
Comments suppressed due to low confidence (2)
regression-test/suites/external_table_p0/hive/test_text_skip_header.groovy:30
catalog_nameis set to${hivePrefix}_test_utf8_check, which appears to be copied fromtest_utf8_checkand will cause this suite to drop/recreate the same catalog name as that suite. This can lead to flaky interference between suites; please rename the catalog to match this suite (e.g.,${hivePrefix}_test_hive_text_skip_header) so it is unique.
regression-test/suites/external_table_p0/hive/test_hive_analyze_db.groovy:47- This suite uses
catalog_name = "${hivePrefix}_test_hive_partition_column_analyze", which is the same catalog name used bytest_hive_partition_column_analyze.groovy. Using the same catalog name across suites means they can drop/overwrite each other’s catalogs when tests run in parallel; please change this to a suite-specific name (e.g.,${hivePrefix}_test_hive_analyze_db).
for (String hivePrefix : ["hive2"]) {
String extHiveHmsHost = context.config.otherConfigs.get("externalEnvIp")
String extHiveHmsPort = context.config.otherConfigs.get(hivePrefix + "HmsPort")
String catalog_name = "${hivePrefix}_test_hive_partition_column_analyze"
sql """drop catalog if exists ${catalog_name};"""
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -65,7 +65,7 @@ suite("test_hive_get_schema_from_table", "p0,external") { | |||
| } | |||
|
|
|||
| // test get scheam from table | |||
There was a problem hiding this comment.
Typo in comment: scheam → schema.
Suggested change
| // test get scheam from table | |
| // test get schema from table |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing