Skip to content

[feat](cloud) add drop_snapshot http api#61687

Merged
w41ter merged 1 commit intoapache:masterfrom
w41ter:snapshot/feat/drop_snapshot_http_api
Mar 25, 2026
Merged

[feat](cloud) add drop_snapshot http api#61687
w41ter merged 1 commit intoapache:masterfrom
w41ter:snapshot/feat/drop_snapshot_http_api

Conversation

@w41ter
Copy link
Contributor

@w41ter w41ter commented Mar 25, 2026

$ curl 'localhost:5000/MetaService/http/drop_snapshot?token=greedisgood9999&instance_id=default_instance_id&snapshot_id=0000000006a6a5810000'
{
    "code": "OK",
    "msg": ""
}

@w41ter
Copy link
Contributor Author

w41ter commented Mar 25, 2026

run buildall

@Thearas
Copy link
Contributor

Thearas commented Mar 25, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 25, 2026
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

return http_json_reply_message(resp.status(), resp);
}

static HttpResponse process_drop_snapshot(MetaServiceImpl* service, brpc::Controller* ctrl) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better adding a UT

@hello-stephen
Copy link
Contributor

Cloud UT Coverage Report

Increment line coverage 11.11% (2/18) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 78.67% (1796/2283)
Line Coverage 64.45% (32307/50128)
Region Coverage 65.34% (16179/24761)
Branch Coverage 55.78% (8620/15454)

@w41ter w41ter merged commit 40a5d1d into apache:master Mar 25, 2026
35 of 37 checks passed
@w41ter w41ter deleted the snapshot/feat/drop_snapshot_http_api branch March 25, 2026 06:36
github-actions bot pushed a commit that referenced this pull request Mar 25, 2026
```
$ curl 'localhost:5000/MetaService/http/drop_snapshot?token=greedisgood9999&instance_id=default_instance_id&snapshot_id=0000000006a6a5810000'
{
    "code": "OK",
    "msg": ""
}
```
yiguolei pushed a commit that referenced this pull request Mar 26, 2026
Cherry-picked from #61687

Co-authored-by: walter <maochuan@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. cloud dev/4.1.0-merged reviewed snapshot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants