branch-4.1: [fix](fe) Fix INSERT INTO local TVF ignoring backend_id during scheduling #61732#61735
Open
github-actions[bot] wants to merge 1 commit intobranch-4.1from
Open
branch-4.1: [fix](fe) Fix INSERT INTO local TVF ignoring backend_id during scheduling #61732#61735github-actions[bot] wants to merge 1 commit intobranch-4.1from
github-actions[bot] wants to merge 1 commit intobranch-4.1from
Conversation
…ling (#61732) ### What problem does this PR solve? Followup #60719 Problem Summary: When using `INSERT INTO local("backend_id" = "X" ...)`, the data should only be written to the BE node specified by `backend_id`. However, the Coordinator schedules the sink fragment to an arbitrary backend because the fragment uses `UNPARTITIONED` partition, which causes `SimpleScheduler.getHost()` to pick any available BE. This results in file creation failures when the target directory only exists on the intended BE. **Root Cause:** - The read path (`SELECT FROM local(...)`) correctly handles this via `TVFScanNode.initBackendPolicy()`, restricting the scan to the specified backend. - The write path (`INSERT INTO local(...)`) had no equivalent logic. `PhysicalPlanTranslator.visitPhysicalTVFTableSink()` creates the fragment as `UNPARTITIONED`, and `Coordinator.computeFragmentHosts()` assigns it to a random BE. **Fix:** Added backend_id-aware scheduling in `Coordinator.computeFragmentHosts()` for local `TVFTableSink`, forcing the sink fragment to execute on the designated backend. This is consistent with the existing `DictionarySink` pattern that also overrides fragment scheduling for specific sink types. **Changes:** 1. `TVFTableSink.java` - Added `getTvfName()` and `getBackendId()` accessor methods 2. `Coordinator.java` - Added check before UNPARTITIONED scheduling: if the sink is a local TVFTableSink with a specific backend_id, force the fragment onto that backend
Contributor
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #61732