[chore](fe) Remove dead code from analysis, common, nereids, planner, qe packages#61738
Merged
morrySnow merged 1 commit intoapache:masterfrom Mar 26, 2026
Merged
[chore](fe) Remove dead code from analysis, common, nereids, planner, qe packages#61738morrySnow merged 1 commit intoapache:masterfrom
morrySnow merged 1 commit intoapache:masterfrom
Conversation
… qe packages ### What problem does this PR solve? Issue Number: close #xxx Problem Summary: Clean up dead code across five FE packages. Removed: - 12 unused classes (never imported/referenced outside their own file) - 21 unused private methods (declared but never called) - 55 unused public methods (never called from any other file) - 19 unused fields (declared but never read, including write-only fields) - Associated orphaned imports All persistence-related code (Gson, Writable, SerializedName, EditLog, etc.) was excluded from removal. FE clean build verified. ### Release note None ### Check List (For Author) - Test: No need to test - pure dead code removal, FE clean build verified - Behavior changed: No - Does this need documentation: No Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 26617 ms |
TPC-DS: Total hot run time: 169083 ms |
Contributor
Author
|
/review |
Contributor
Code Review: Dead Code RemovalReviewed all 92 changed files (1,781 lines deleted, 1 line added). This is a pure dead code removal PR with no behavioral changes. Critical Checkpoint Conclusions (Part 1.3)
Verification Summary
Result: No issues found. Clean dead code removal. |
924060929
approved these changes
Mar 26, 2026
starocean999
approved these changes
Mar 26, 2026
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Remove dead code across five FE packages:
analysis,common,nereids,planner,qe.What problem does this PR solve?
Problem Summary: Accumulated dead code in FE modules increases maintenance burden and cognitive load. This PR removes:
NotLiteralExprPredicate,BaseProcNode,MysqlUtil,CommandResult,ExprCostModel,FileDumpConsumer,ParentTypeIdMapping,DecimalWiderPrecision,BucketSpecifyInstances,DefaultSpecifyInstances,CustomAssignmentJob,ScanRange(nereids),ExportSinkAlterTableOp.needTableStableandDistributionDesc.type)92 files changed, 1,781 lines deleted.
Safety guarantees
All persistence-related code was excluded from removal:
@SerializedName,@JsonProperty,implements Writable/GsonPostProcessablereadFields,writeObject,readObject,SerializableKnown special cases intentionally preserved:
PatternDescribableProcessPoint.java— annotation processor trigger referenced in pom.xmlParserContext.java— used by fe_plugins (spark/trino converters)SessionVariablegetters — accessed via reflection through@VarAttrReview verification
Reviewed by 4 independent AI models (Claude Opus 4.6, GPT-5.4, GPT-5.3-Codex, Gemini 3 Pro):
CommandResultclass after getter removal) was fixedRelease note
None
Check List (For Author)