[opt](load) disable enable_strict_consistency_dml by default in cloud mode#61814
Merged
liaoxin01 merged 1 commit intoapache:masterfrom Mar 30, 2026
Merged
[opt](load) disable enable_strict_consistency_dml by default in cloud mode#61814liaoxin01 merged 1 commit intoapache:masterfrom
liaoxin01 merged 1 commit intoapache:masterfrom
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
sollhui
changed the title
Contributor
Author
|
run buildall |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
sollhui
force-pushed
the
opt_cloud_load_memory
branch
from
88fccba to
398950e
Compare
github-actions
bot
removed
the
approved
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 26284 ms |
TPC-DS: Total hot run time: 168803 ms |
Contributor
FE UT Coverage ReportIncrement line coverage |
sollhui
force-pushed
the
opt_cloud_load_memory
branch
from
398950e to
f94dc5c
Compare
Contributor
Author
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
TPC-H: Total hot run time: 26669 ms |
TPC-DS: Total hot run time: 169665 ms |
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
0AyanamiRei
approved these changes
Mar 30, 2026
HappenLee
pushed a commit
to HappenLee/incubator-doris
that referenced
this pull request
Mar 31, 2026
… mode (apache#61814) ## Problem `enable_strict_consistency_dml` is designed to handle multi-replica consistency for DML operations. In cloud mode (store-compute separation), data has only a single copy, so there is no multi-replica consistency concern. Keeping this variable `true` in cloud mode causes unnecessary data shuffling overhead. ## Solution Override `isEnableStrictConsistencyDml()` to return `false` when running in cloud mode (`Config.isCloudMode()`), regardless of the session variable's value. This follows the same pattern as `isDisableFileCache()`. Update all call sites in `RequestPropertyDeriver` to use the getter instead of direct field access so the cloud-mode check takes effect. ## Tests Added two unit tests in `SessionVariablesTest`: - Verify `isEnableStrictConsistencyDml()` returns `false` in cloud mode (even when field is `true`) - Verify `isEnableStrictConsistencyDml()` follows the field value in non-cloud mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
enable_strict_consistency_dmlis designed to handle multi-replica consistency for DMLoperations. In cloud mode (store-compute separation), data has only a single copy, so
there is no multi-replica consistency concern. Keeping this variable
truein cloud modecauses unnecessary data shuffling overhead.
Solution
Override
isEnableStrictConsistencyDml()to returnfalsewhen running in cloud mode(
Config.isCloudMode()), regardless of the session variable's value. This follows thesame pattern as
isDisableFileCache().Update all call sites in
RequestPropertyDeriverto use the getter instead of directfield access so the cloud-mode check takes effect.
Tests
Added two unit tests in
SessionVariablesTest:isEnableStrictConsistencyDml()returnsfalsein cloud mode (even when field istrue)isEnableStrictConsistencyDml()follows the field value in non-cloud mode