[refine](expr) Migrate old VExpr execute interface to new execute_column (Part 1)#61912
Merged
BiteTheDDDDt merged 3 commits intoapache:masterfrom Mar 31, 2026
Merged
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 26687 ms |
TPC-DS: Total hot run time: 168011 ms |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 26612 ms |
TPC-DS: Total hot run time: 168842 ms |
Contributor
Author
|
run cloud_p0 |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
BiteTheDDDDt
approved these changes
Mar 31, 2026
16 tasks
morningman
pushed a commit
that referenced
this pull request
Apr 2, 2026
…umn (Part 1) (#61912) | File | Description | |------|-------------| | `exec/operator/hashjoin_build_sink.cpp` | ASOF join build-side expr: use `ColumnPtr` directly, remove `result_col_idx` and the subsequent `block->get_by_position` indirection | | `exec/operator/join/process_hash_table_probe_impl.h` | ASOF join probe-side expr: same pattern as above | | `exec/sink/vrow_distribution.cpp` | Where-clause filter: remove `result_index` tracking and the `block->erase` cleanup loop (no longer needed with new interface) | | `storage/segment/segment_iterator.cpp` | Virtual column materialization: remove `prev_block_columns` tracking and `erase_tail` call; fix stale `result_cid` reference in log message | | `format/transformer/iceberg_partition_function.cpp` | Iceberg insert/delete partition hash: change `vector<int> results` to `vector<ColumnWithTypeAndName> results`, use `ColumnWithTypeAndName` overload | | `exprs/table_function/vjson_each.cpp` | `VExpr::execute` (3-arg) → `execute_column` | | `exprs/table_function/vexplode_numbers.cpp` | Same as above | | `exprs/table_function/vexplode_map.cpp` | Same as above; also fix error message to use `_collection_column->get_name()` instead of stale block position lookup | | `exec/operator/operator.cpp` | **Bug fix**: Remove dead `result_column_id = -1` that was never updated after migration to new interface; `bytes_usage` was never accumulated due to `if (result_column_id >= origin_columns_count)` always being false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Changes
exec/operator/hashjoin_build_sink.cppColumnPtrdirectly, removeresult_col_idxand the subsequentblock->get_by_positionindirectionexec/operator/join/process_hash_table_probe_impl.hexec/sink/vrow_distribution.cppresult_indextracking and theblock->erasecleanup loop (no longer needed with new interface)storage/segment/segment_iterator.cppprev_block_columnstracking anderase_tailcall; fix staleresult_cidreference in log messageformat/transformer/iceberg_partition_function.cppvector<int> resultstovector<ColumnWithTypeAndName> results, useColumnWithTypeAndNameoverloadexprs/table_function/vjson_each.cppVExpr::execute(3-arg) →execute_columnexprs/table_function/vexplode_numbers.cppexprs/table_function/vexplode_map.cpp_collection_column->get_name()instead of stale block position lookupexec/operator/operator.cppresult_column_id = -1that was never updated after migration to new interface;bytes_usagewas never accumulated due toif (result_column_id >= origin_columns_count)always being falseRelease note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)