[improvement](fe) Evaluate protobuf 4 with Arrow 19#61943
Open
CalvinKirs wants to merge 3 commits intoapache:masterfrom
Open
[improvement](fe) Evaluate protobuf 4 with Arrow 19#61943CalvinKirs wants to merge 3 commits intoapache:masterfrom
CalvinKirs wants to merge 3 commits intoapache:masterfrom
Conversation
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: Align FE-side protobuf and Arrow Java dependencies for the protobuf 4 / Arrow 19 evaluation, add the required Gson exclusion for protobuf 4 builders, and cover the behavior with a focused FE unit test.
### Release note
None
### Check List (For Author)
- Test: FE unit test
- Regression test / Unit Test / Manual test / No need to test (with reason): Unit Test via ./run-fe-ut.sh --run org.apache.doris.persist.gson.GsonProtobufCompatibilityTest and ./run-fe-ut.sh --run org.apache.doris.persist.gson.GsonSerializationTest,org.apache.doris.persist.gson.GsonDerivedClassSerializationTest,org.apache.doris.persist.gson.ThriftToJsonTest,org.apache.doris.persist.gson.GsonProtobufCompatibilityTest,org.apache.doris.mysql.ConnectionExceedTest
- Behavior changed: Yes (FE protobuf runtime is aligned to 4.33.4 for this evaluation branch, and protobuf builders are excluded from Gson persistence output)
- Does this need documentation: No
Member
Author
|
run buildall |
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
### What problem does this PR solve? Issue Number: None Related PR: None Problem Summary: Update the default FE and BE JDK 17 runtime configs to open java.base/java.nio to the Arrow memory module as well as unnamed modules, so the shipped conf files match the desired Arrow MemoryUtil access pattern. ### Release note None ### Check List (For Author) - Test: No need to test (config-only JVM option adjustment) - Behavior changed: Yes (default FE and BE conf now target the Arrow memory module explicitly) - Does this need documentation: No
Member
Author
|
run buildall |
TPC-H: Total hot run time: 26317 ms |
TPC-DS: Total hot run time: 169083 ms |
Contributor
FE UT Coverage ReportIncrement line coverage |
CalvinKirs
added
4.1.x-tbd
Member
Author
|
run buildall |
TPC-H: Total hot run time: 26540 ms |
TPC-DS: Total hot run time: 168866 ms |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: Align FE-side protobuf and Arrow Java dependencies for the protobuf 4 / Arrow 19 evaluation, add the required Gson exclusion for protobuf 4 builders, and cover the behavior with a focused FE unit test.
Release note
None
Check List (For Author)
Test: FE unit test
Behavior changed: Yes (FE protobuf runtime is aligned to 4.33.4 for this evaluation branch, and protobuf builders are excluded from Gson persistence output)
Does this need documentation: No
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)